From patchwork Fri Mar 20 10:33:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 452558 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 28FA6140182 for ; Fri, 20 Mar 2015 21:33:24 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=YakJ1S1e; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=Iho7YDcWXqjfG2VYX Mu7SxXAlWVWgtpBHDmyHNxEQCc+9EzhjVJRNsiwZPvPNSNTYzsQzjqHtd0mOvXFN GC1BFvWRJL2MwdbbXzR/A8dkuhhb34bUUSlok11UcCG2/3wYxcOQXocWxNDI5dc0 NDIuImmQOaT4c51qMJUlArDMVA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=wlD68caVl02zQgUb/Wb7GCC 1tvI=; b=YakJ1S1ey9ljvbT6N2qZ+uZvLmGhaeJpF0KnR/D6ZWDBmBybkCfbiqK pXutC4W2arkI0zSKAmUK2pM68z7XLDa3fhetRW0uGwvtM/jB3pD0Am09zJd4fQZL NFzNlR/k6uktjJeHu+8vdLZl2Ko/kwNt/rMFQNNKnW/5QgSPYurA= Received: (qmail 112738 invoked by alias); 20 Mar 2015 10:33:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 112716 invoked by uid 89); 20 Mar 2015 10:33:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-HELO: mx2.suse.de Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Fri, 20 Mar 2015 10:33:12 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 9F6BEAC82; Fri, 20 Mar 2015 10:33:09 +0000 (UTC) Message-ID: <550BF765.2070705@suse.cz> Date: Fri, 20 Mar 2015 11:33:09 +0100 From: =?windows-1252?Q?Martin_Li=9Aka?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: gcc-patches@gcc.gnu.org CC: Jan Hubicka Subject: Re: [PATCH] Speed-up def_builtin_const (ix86_valid_target_attribute) References: <54FE1B94.9080208@suse.cz> <20150313044257.GB55012@kam.mff.cuni.cz> <550B3DDC.4030408@suse.cz> <20150320000959.GC48586@kam.mff.cuni.cz> In-Reply-To: <20150320000959.GC48586@kam.mff.cuni.cz> X-IsSubscribed: yes On 03/20/2015 01:10 AM, Jan Hubicka wrote: >> Hi. >> >> Explanation of the patch is introduced. > > thanks >> >>>> >>>> mask &= ~OPTION_MASK_ISA_64BIT; >>>> if (mask == 0 >>>> @@ -30670,6 +30673,14 @@ def_builtin_const (HOST_WIDE_INT mask, const char *name, >>>> static void >>>> ix86_add_new_builtins (HOST_WIDE_INT isa) >>>> { >>>> + /* Last cached isa value. */ >>>> + static HOST_WIDE_INT last_tested_isa_value = 0; >>>> + >>>> + if ((isa & defined_isa_values) == 0 || isa == last_tested_isa_value) >>> >>> Heer you need to compare (isa & defined_isa_values) == (isa & >>> last_tested_isa_value) right, because we have isa flags that enable no >>> builtins. >> >> I do not understand why, the guard simply ignores last value, which is already processed and >> 'isa' with any intersection with defined_isa_values. Maybe I miss something? > > I think you can also skip processing in cases ISA changed but the change has empty intersection with > defined_isa_values. > > Honza > Good idea. I've integrated this part to upgraded patch, which can survive regression tests on x86_64-linux-pc and can bootstrap. Ready for trunk? Thanks, Martin From 5df909a7d06e91c9506a7d7186015b431f9db04a Mon Sep 17 00:00:00 2001 From: marxin Date: Sun, 8 Mar 2015 19:39:55 -0500 Subject: [PATCH] def_builtin_const: speed-up. gcc/ChangeLog: 2015-03-09 Martin Liska * config/i386/i386.c (def_builtin): Collect union of all possible masks. (ix86_add_new_builtins): Do not iterate over all builtins in cases that isa value has no intersection with possible masks and(or) last passed value is equal to the provided. --- gcc/config/i386/i386.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index ab8f03a..afb2fa4 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -30592,6 +30592,8 @@ struct builtin_isa { static struct builtin_isa ix86_builtins_isa[(int) IX86_BUILTIN_MAX]; +/* Union of all masks that are part of builtin_isa structures. */ +static HOST_WIDE_INT defined_isa_values = 0; /* Add an ix86 target builtin function with CODE, NAME and TYPE. Save the MASK of which isa_flags to use in the ix86_builtins_isa array. Stores the @@ -30619,6 +30621,7 @@ def_builtin (HOST_WIDE_INT mask, const char *name, if (!(mask & OPTION_MASK_ISA_64BIT) || TARGET_64BIT) { ix86_builtins_isa[(int) code].isa = mask; + defined_isa_values |= mask; mask &= ~OPTION_MASK_ISA_64BIT; if (mask == 0 @@ -30670,6 +30673,20 @@ def_builtin_const (HOST_WIDE_INT mask, const char *name, static void ix86_add_new_builtins (HOST_WIDE_INT isa) { + /* Last cached isa value. */ + static HOST_WIDE_INT last_tested_isa_value = 0; + + /* We iterate through all defined builtins just if the last tested + values is different from ISA and just in case there is any intersection + between ISA value and union of all possible configurations. + Last condition skips iterations if ISA is changed by the change has + empty intersection with defined_isa_values. */ + if ((isa & defined_isa_values) == 0 || isa == last_tested_isa_value + || ((isa ^ last_tested_isa_value) & defined_isa_values) == 0) + return; + + last_tested_isa_value = isa; + int i; tree saved_current_target_pragma = current_target_pragma; current_target_pragma = NULL_TREE; -- 2.1.2