From patchwork Thu Mar 12 01:46:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sandra Loosemore X-Patchwork-Id: 449274 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 171E0140140 for ; Thu, 12 Mar 2015 12:46:53 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=OkBEFMdd; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; q= dns; s=default; b=YszwGBSeK23PQxFN6SFtPfhxtbhkOXjt1KBE1fS4QTaRwF FOkKSOX3bNVMDknU1kUqo+Lplr4OL5Rm6sVvkIBN8XVwkmFroo16rQ9R30YsYuty b2KXjpUrxLMvIqIT3p7L9Jg2EE2W0P/LYY/9hQ60Dmsme0hvVztb5HFjlXGbA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:subject:content-type; s= default; bh=aydbXP4ZEXAX0BLWoqA4avaq5AA=; b=OkBEFMddACqgk62aoc5e qj0f3OwepZaB24l/1eDEPF76tOdxd+6kuggACbBXcWu2DN8U6Z/zCjt3pHI9eq7v 7nkAD/nfwx2Rd643H1tkvMph4Oq8CAleuG07zy/DC+7Ai7Ix8bB9wyHZvSeB57GO BcnVi9SAzOX5SMDSUf/LgDo= Received: (qmail 3406 invoked by alias); 12 Mar 2015 01:46:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 3396 invoked by uid 89); 12 Mar 2015 01:46:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Mar 2015 01:46:42 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1YVsCs-0003hz-JE from Sandra_Loosemore@mentor.com for gcc-patches@gcc.gnu.org; Wed, 11 Mar 2015 18:46:38 -0700 Received: from [IPv6:::1] (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Wed, 11 Mar 2015 18:46:35 -0700 Message-ID: <5500EFDD.9040103@codesourcery.com> Date: Wed, 11 Mar 2015 19:46:05 -0600 From: Sandra Loosemore User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: GCC Patches Subject: [testsuite, committed] require fpic support for g++.dg/ipa/pr64146.C I noticed that g++.dg/ipa/pr64146.C was FAILing on nios2-elf because this target doesn't support -fpic; the ABI defines the PIC relocations for GNU/Linux only, so -fpic gives a "sorry" in the bare-metal toolchain. From reading the PR, my understanding is that the bug is specific to PIC and the behavior being tested for in the testcase is also specific to PIC, so I think the attached patch to skip the test if PIC isn't supported qualifies as obvious, and I've checked it in. -Sandra Index: gcc/testsuite/g++.dg/ipa/pr64146.C =================================================================== --- gcc/testsuite/g++.dg/ipa/pr64146.C (revision 221276) +++ gcc/testsuite/g++.dg/ipa/pr64146.C (working copy) @@ -1,5 +1,6 @@ /* { dg-do compile } */ /* { dg-require-alias "" } */ +/* { dg-require-effective-target fpic } */ /* { dg-options "-fpic -fdump-ipa-icf-details -fipa-icf" } */ extern "C" const char*