| Message ID | 546F41E7.8030007@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Fri, 2014-11-21 08:45:11 -0500, Andrew MacLeod <amacleod@redhat.com> wrote: > During the flattening of optabs.h, I updated all the config/* files > which were affected. I've been getting spurious failures with > config-list.mk where my changes would "disappear" and tracked down > why. > > I was blissfully unaware that the tilepro ports mul-tables.c file is > actually generated from gen-mul-tables.cc. > > This patch fixes the include issue by adding "#include insn-codes.h" > to the generated files. I also added a comment indicating these are > generated files, and to make changes in the generator. > > This allows all the tile* ports to compile properly again. > > OK for trunk? Seems this wasn't ever ACKed or applied up to now? I'm still seeing compilation errors for the tile targets, see eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=382169 MfG, JBG
On 12/8/2014 11:23 AM, Jan-Benedict Glaw wrote: > On Fri, 2014-11-21 08:45:11 -0500, Andrew MacLeod <amacleod@redhat.com> wrote: >> During the flattening of optabs.h, I updated all the config/* files >> which were affected. I've been getting spurious failures with >> config-list.mk where my changes would "disappear" and tracked down >> why. >> >> I was blissfully unaware that the tilepro ports mul-tables.c file is >> actually generated from gen-mul-tables.cc. >> >> This patch fixes the include issue by adding "#include insn-codes.h" >> to the generated files. I also added a comment indicating these are >> generated files, and to make changes in the generator. >> >> This allows all the tile* ports to compile properly again. >> >> OK for trunk? > Seems this wasn't ever ACKed or applied up to now? I'm still seeing > compilation errors for the tile targets, see eg. > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=382169 Sorry about that. Looks good to me. Walter
On 12/08/2014 11:23 AM, Jan-Benedict Glaw wrote: > On Fri, 2014-11-21 08:45:11 -0500, Andrew MacLeod <amacleod@redhat.com> wrote: >> During the flattening of optabs.h, I updated all the config/* files >> which were affected. I've been getting spurious failures with >> config-list.mk where my changes would "disappear" and tracked down >> why. >> >> I was blissfully unaware that the tilepro ports mul-tables.c file is >> actually generated from gen-mul-tables.cc. >> >> This patch fixes the include issue by adding "#include insn-codes.h" >> to the generated files. I also added a comment indicating these are >> generated files, and to make changes in the generator. >> >> This allows all the tile* ports to compile properly again. >> >> OK for trunk? > Seems this wasn't ever ACKed or applied up to now? I'm still seeing > compilation errors for the tile targets, see eg. > http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=382169 > > MfG, JBG > Now checked in, revision 218624 Andrew
* config/tilepro/gen-mul-tables.cc: Add insn-codes.h to include list for generator file. Add comment indicating it is a generated file. * config/tilepro/mul-tables.c: Update generated file. * config/tilegx/mul-tables.c: Likewise. Index: config/tilepro/gen-mul-tables.cc =================================================================== *** config/tilepro/gen-mul-tables.cc (revision 217787) --- config/tilepro/gen-mul-tables.cc (working copy) *************** main () *** 1249,1258 **** --- 1249,1262 ---- printf (" along with GCC; see the file COPYING3. If not see\n"); printf (" <http://www.gnu.org/licenses/>. */\n"); printf ("\n"); + printf ("/* Note this file is auto-generated from gen-mul-tables.cc.\n"); + printf (" Make any required changes there. */\n"); + printf ("\n"); printf ("#include \"config.h\"\n"); printf ("#include \"system.h\"\n"); printf ("#include \"coretypes.h\"\n"); printf ("#include \"expr.h\"\n"); + printf ("#include \"insn-codes.h\"\n"); printf ("#include \"optabs.h\"\n"); printf ("#include \"%s-multiply.h\"\n\n", ARCH); create_insn_code_compression_table (); Index: config/tilepro/mul-tables.c =================================================================== *** config/tilepro/mul-tables.c (revision 217787) --- config/tilepro/mul-tables.c (working copy) *************** *** 18,23 **** --- 18,26 ---- along with GCC; see the file COPYING3. If not see <http://www.gnu.org/licenses/>. */ + /* Note this file is auto-generated from gen-mul-tables.cc. + Make any required changes there. */ + #include "config.h" #include "system.h" #include "coretypes.h" Index: config/tilegx/mul-tables.c =================================================================== *** config/tilegx/mul-tables.c (revision 217787) --- config/tilegx/mul-tables.c (working copy) *************** *** 18,23 **** --- 18,26 ---- along with GCC; see the file COPYING3. If not see <http://www.gnu.org/licenses/>. */ + /* Note this file is auto-generated from gen-mul-tables.cc. + Make any required changes there. */ + #include "config.h" #include "system.h" #include "coretypes.h"