From patchwork Mon Nov 3 20:16:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 406354 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 56DB41400A0 for ; Tue, 4 Nov 2014 07:17:03 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=SrnlHBn4GzebnhgyM gjNK7o4keAYhXApgySCMnF4S4UrtXOCPrNXNgUvOToN6rr5yi9YnMrvGliFQbKu8 1rPI5oB4/5nItMlc4f9uAj5eg9REjB0Wq6ZwSzflQH8nqJVVsYrtyJD7siERl3co 7G1FG2po+MndtG/8UQRVYEzi+c= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=nf/pKI3RsndzasxbknV8qEy ClNI=; b=LX4rcwqcJhWn5dKNWPGOhddjkYtnPDpndmEb8LbscpuAfC1lGvVrrw1 P7G5+Y+s4McD+QWktk/VsTSUpAPG9W31vGx6KaH4HUkH4LRVG0NPv7qmufuP0LnJ qZ9viuBHpQCBHRMfmm2f/1W1H5pBdnAQPGi/X2mtFI5Hlsl1RV2I= Received: (qmail 16129 invoked by alias); 3 Nov 2014 20:16:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 16107 invoked by uid 89); 3 Nov 2014 20:16:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx01.qsc.de Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 03 Nov 2014 20:16:52 +0000 Received: from tux.net-b.de (port-92-194-240-118.dynamic.qsc.de [92.194.240.118]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx01.qsc.de (Postfix) with ESMTPSA id 62BF43CDA0; Mon, 3 Nov 2014 21:16:48 +0100 (CET) Message-ID: <5457E2AF.7030406@net-b.de> Date: Mon, 03 Nov 2014 21:16:47 +0100 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andreas Schwab CC: gfortran , gcc-patches Subject: Re: [Patch, Fortran] Add CO_REDUCE References: <54456EFE.5000903@net-b.de> <87egtwm498.fsf@igel.home> In-Reply-To: <87egtwm498.fsf@igel.home> Andreas Schwab wrote: > Tobias Burnus writes: > >> diff --git a/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 b/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 >> new file mode 100644 >> index 0000000..f0ab932 >> --- /dev/null >> +++ b/gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 > FAIL: gfortran.dg/coarray_collectives_14.f90 -O (test for errors, line 55) Sorry for the test failure. One shouldn't do last-minute commits before leaving for vacation. Fixed by the attached patch and in Rev. 217053. I will fill a PR for the FIXME item. Tobias Index: gcc/testsuite/ChangeLog =================================================================== --- gcc/testsuite/ChangeLog (Revision 217051) +++ gcc/testsuite/ChangeLog (Arbeitskopie) @@ -1,3 +1,7 @@ +2014-11-03 Tobias Burnus + + * gfortran.dg/coarray_collectives_14.f90: Fix testcase. + 2014-11-03 Marek Polacek PR c/52769 Index: gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 =================================================================== --- gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 (Revision 217052) +++ gcc/testsuite/gfortran.dg/coarray_collectives_14.f90 (Arbeitskopie) @@ -15,24 +15,24 @@ program test external ext type t - procedure(), nopass :: ext - procedure(valid), nopass :: valid - procedure(sub), nopass :: sub - procedure(nonpure), nopass :: nonpure - procedure(arg1), nopass :: arg1 - procedure(arg2), nopass :: arg2 - procedure(elem), nopass :: elem - procedure(realo), nopass :: realo - procedure(int8), nopass :: int8 - procedure(arr), nopass :: arr - procedure(ptr), nopass :: ptr - procedure(alloc), nopass :: alloc - procedure(opt), nopass :: opt - procedure(val), nopass :: val - procedure(async), nopass :: async - procedure(tgt), nopass :: tgt - procedure(char44), nopass :: char44 - procedure(char34), nopass :: char34 + procedure(), pointer, nopass :: ext + procedure(valid), pointer, nopass :: valid + procedure(sub), pointer, nopass :: sub + procedure(nonpure), pointer, nopass :: nonpure + procedure(arg1), pointer, nopass :: arg1 + procedure(arg3), pointer, nopass :: arg3 + procedure(elem), pointer, nopass :: elem + procedure(realo), pointer, nopass :: realo + procedure(int8), pointer, nopass :: int8 + procedure(arr), pointer, nopass :: arr + procedure(ptr), pointer, nopass :: ptr + procedure(alloc), pointer, nopass :: alloc + procedure(opt), pointer, nopass :: opt + procedure(val), pointer, nopass :: val + procedure(async), pointer, nopass :: async + procedure(tgt), pointer, nopass :: tgt + procedure(char44), pointer, nopass :: char44 + procedure(char34), pointer, nopass :: char34 end type t type(t) :: dt @@ -62,7 +62,7 @@ program test call co_reduce(caf, arg3) ! { dg-error "shall have two arguments" } call co_reduce(caf, dt%arg3) ! { dg-error "shall have two arguments" } call co_reduce(caf, elem) ! { dg-error "ELEMENTAL non-INTRINSIC procedure 'elem' is not allowed as an actual argument" } - call co_reduce(caf, dt%elem) ! { dg-error "ELEMENTAL non-INTRINSIC procedure 'elem' is not allowed as an actual argument" } + call co_reduce(caf, dt%elem) ! { FIXME: "ELEMENTAL non-INTRINSIC procedure 'elem' is not allowed as an actual argument" } call co_reduce(caf, realo) ! { dg-error "A argument at .1. has type INTEGER.4. but the function passed as OPERATOR at .2. returns REAL.4." } call co_reduce(caf, dt%realo) ! { dg-error "A argument at .1. has type INTEGER.4. but the function passed as OPERATOR at .2. returns REAL.4." } call co_reduce(caf, int8) ! { dg-error "A argument at .1. has type INTEGER.4. but the function passed as OPERATOR at .2. returns INTEGER.8." }