[2/3] Re-submission of Altera Nios II port, testsuite parts

On 2013/10/17 10:20 PM, Bernd Schmidt wrote:
> On 07/14/2013 09:54 AM, Chung-Lin Tang wrote:
>> These are nios2 patches for the gcc testsuite. Some new testcases were
>> added since the last posting.
> 
>> Index: gcc/testsuite/gcc.c-torture/execute/builtins/lib/chk.c
>> ===================================================================
>> --- gcc/testsuite/gcc.c-torture/execute/builtins/lib/chk.c	(revision 200946)
>> +++ gcc/testsuite/gcc.c-torture/execute/builtins/lib/chk.c	(working copy)
>> @@ -124,16 +124,17 @@ __memmove_chk (void *dst, const void *src, __SIZE_
>>  void *
>>  memset (void *dst, int c, __SIZE_TYPE__ n)
>>  {
>> +  while (n-- != 0)
>> +    n[(char *) dst] = c;
>> +
>>    /* Single-byte memsets should be done inline when optimisation
>> -     is enabled.  */
>> +     is enabled.  Do this after the copy in case we're being called to
>> +     initialize bss.  */
>>  #ifdef __OPTIMIZE__
>>    if (memset_disallowed && inside_main && n < 2)
>>      abort ();
>>  #endif
>>  
>> -  while (n-- != 0)
>> -    n[(char *) dst] = c;
>> -
>>    return dst;
>>  }
> 
> I'm not sure I understand this change. Is nios2 the only target calling
> memset to initialize bss, and memset_disallowed is nonzero at the start
> of execution?

This appears to be for the nios2-elf bare metal testing. Looking at the
upstream libgloss sources, nios2 is indeed not the only target that
calls memset for zeroing bss.

Note that however, in a somewhat reverse of situation:
https://sourceware.org/ml/newlib/2013/msg00264.html

It appears that due to the presumed usage model for Nios II, Sandra did
not contribute the libgloss port. So the original code that needed this
testsuite change is probably not there.

OTOH, if this change is not deemed harmful, than it might further
robustify the testsuite.

>> Index: gcc/testsuite/gcc.target/nios2/nios2-int-types.c
>> ===================================================================
>> --- gcc/testsuite/gcc.target/nios2/nios2-int-types.c	(revision 0)
>> +++ gcc/testsuite/gcc.target/nios2/nios2-int-types.c	(revision 0)
>> @@ -0,0 +1,34 @@
>> +/* Test that various types are all derived from int.  */
>> +/* { dg-do compile { target nios2-*-* } } */
> 
> I think you can lose the { target nios2-*-* } for everything inside
> gcc.target/nios2.

Done.

The new attached patch also has the Dxx constraint test removed, as that
feature is now removed from the compiler. The memset() change mentioned
above is still in the patch, but will remove before committing if not
approved.

Thanks,
Chung-Lin

2013-11-16  Sandra Loosemore  <sandra@codesourcery.com>
            Chung-Lin Tang  <cltang@codesourcery.com>
            Based on patches from Altera Corporation

        * gcc.dg/stack-usage-1.c (SIZE): Define case for __nios2__.
        * gcc.dg/20040813-1.c: Skip for nios2-*-*.
        * gcc.dg/20020312-2.c: Add __nios2__ case.
        * g++.dg/other/PR23205.C: Skip for nios2-*-*.
        * g++.dg/other/pr23205-2.C: Skip for nios2-*-*.
        * g++.dg/cpp0x/constexpr-rom.C: Skip for nios2-*-*.
        * g++.dg/cpp0x/alias-decl-debug-0.C: Skip for nios2-*-*.
        * g++.old-deja/g++.jason/thunk3.C: Skip for nios2-*-*.
        * lib/target-supports.exp (check_profiling_available): Check for
        nios2-*-elf.
        * gcc.c-torture/execute/pr47237.x:: Skip for nios2-*-*.
        * gcc.c-torture/execute/20101011-1.c: Skip for nios2-*-*.
        * gcc.c-torture/execute/builtins/lib/chk.c (memset): Place
	char-based memset loop before inline check, to prevent
	problems when called to initialize .bss. Update comments.
        * gcc.target/nios2/nios2.exp: New DejaGNU file.
        * gcc.target/nios2/nios2-custom-1.c: New test.
        * gcc.target/nios2/nios2-trap-insn.c: New test.
        * gcc.target/nios2/nios2-builtin-custom.c: New test.
        * gcc.target/nios2/nios2-builtin-io.c: New test.
        * gcc.target/nios2/nios2-stack-check-1.c: New test.
        * gcc.target/nios2/nios2-stack-check-2.c: New test.
        * gcc.target/nios2/nios2-rdctl.c: New test.
        * gcc.target/nios2/nios2-wrctl.c: New test.
        * gcc.target/nios2/nios2-wrctl-zero.c: New test.
        * gcc.target/nios2/nios2-wrctl-not-zero.c: New test.
        * gcc.target/nios2/nios2-rdwrctl-1.c: New test.
        * gcc.target/nios2/nios2-ashlsi3-one_shift.c: New test.
        * gcc.target/nios2/nios2-mul-options-1.c: New test.
        * gcc.target/nios2/nios2-mul-options-2.c: New test.
        * gcc.target/nios2/nios2-mul-options-3.c: New test.
        * gcc.target/nios2/nios2-mul-options-4.c: New test.
        * gcc.target/nios2/nios2-nor.c: New test.
        * gcc.target/nios2/nios2-stxio.c: New test.
        * gcc.target/nios2/custom-fp-1.c: New test.
        * gcc.target/nios2/custom-fp-2.c: New test.
        * gcc.target/nios2/custom-fp-3.c: New test.
        * gcc.target/nios2/custom-fp-4.c: New test.
        * gcc.target/nios2/custom-fp-5.c: New test.
        * gcc.target/nios2/custom-fp-6.c: New test.
        * gcc.target/nios2/custom-fp-7.c: New test.
        * gcc.target/nios2/custom-fp-8.c: New test.
        * gcc.target/nios2/custom-fp-cmp-1.c: New test.
        * gcc.target/nios2/custom-fp-conversion.c: New test.
        * gcc.target/nios2/custom-fp-double.c: New test.
        * gcc.target/nios2/custom-fp-float.c: New test.
        * gcc.target/nios2/nios2-int-types.c: New test.
        * gcc.target/nios2/nios2-cache-1.c: New test.
        * gcc.target/nios2/nios2-cache-2.c: New test.

[2/3] Re-submission of Altera Nios II port, testsuite parts

Commit Message

Patch