From patchwork Fri Jul 24 23:25:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Segher Boessenkool X-Patchwork-Id: 1336024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4BD50z3syxz9sR4 for ; Sat, 25 Jul 2020 09:25:53 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A2C2E3858D35; Fri, 24 Jul 2020 23:25:49 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from gcc1-power7.osuosl.org (gcc1-power7.osuosl.org [140.211.15.137]) by sourceware.org (Postfix) with ESMTP id B95CF3858D35 for ; Fri, 24 Jul 2020 23:25:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B95CF3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=segher@gcc1-power7.osuosl.org Received: by gcc1-power7.osuosl.org (Postfix, from userid 10019) id D4246124013C; Fri, 24 Jul 2020 23:25:45 +0000 (UTC) From: Segher Boessenkool To: gcc-patches@gcc.gnu.org Subject: [PATCH] rs6000: Remove -mpower10 option (PR95907) Date: Fri, 24 Jul 2020 23:25:43 +0000 Message-Id: <4e577910050d6e18977525f0302a175542ffd610.1595633048.git.segher@kernel.crashing.org> X-Mailer: git-send-email 1.8.3.1 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TVD_SUBJ_WIPE_DEBT, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Segher Boessenkool , dje.gcc@gmail.com Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" The only way to enable or disable Power10 insns (ISA 3.1 insns) should be via the -mcpu= switch. This patch disables the -mpower10 options the same way the -mdirect-move switch is neutered already. That is not an ideal way, but it works, it is not the first, and doing it properly is more work, and will happen later. Tested on powerpc64-linux {-m32,-m64}; committed. (Testcase is from Peter Bergner originally; all mangling is mine). 2020-07-24 Segher Boessenkool * config/rs6000/rs6000.opt: Delete -mpower10. gcc/testsuite/ * gcc.target/powerpc/pr95907.c: New. --- gcc/config/rs6000/rs6000.opt | 3 +-- gcc/testsuite/gcc.target/powerpc/pr95907.c | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/powerpc/pr95907.c diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt index 6b426f2..5910675 100644 --- a/gcc/config/rs6000/rs6000.opt +++ b/gcc/config/rs6000/rs6000.opt @@ -568,8 +568,7 @@ mspeculate-indirect-jumps Target Undocumented Var(rs6000_speculate_indirect_jumps) Init(1) Save mpower10 -Target Report Mask(POWER10) Var(rs6000_isa_flags) -Use instructions added in ISA 3.1. +Target Undocumented Mask(POWER10) Var(rs6000_isa_flags) WarnRemoved mprefixed Target Report Mask(PREFIXED) Var(rs6000_isa_flags) diff --git a/gcc/testsuite/gcc.target/powerpc/pr95907.c b/gcc/testsuite/gcc.target/powerpc/pr95907.c new file mode 100644 index 0000000..f2512b0 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr95907.c @@ -0,0 +1,7 @@ +/* PR target/95907 */ +/* { dg-do compile } */ +/* { dg-require-effective-target power10_ok } */ +/* { dg-options "-mpower10" } */ +/* { dg-warning "switch .-mpower10. is no longer supported" "" {target *-*-*} 0 } */ + +void f(void) { }