From patchwork Sat Mar 3 14:17:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 144424 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7C10D1007D3 for ; Sun, 4 Mar 2012 01:17:56 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1331389081; h=Comment: DomainKey-Signature:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=b4/38OJiiohDFkAA97P9+vKvWs4=; b=J17HNPo2fjEvLdL hMRXnfEwyV43cn+iz5HqmrsYLvUhmUXK4zMWiAAXKXgpS4hCIXKSfYx5qPxM7MyA Luy8CVSo4Znx5DnUXhPQIdWqVdr0AKv1qScXQCY/LXo/IdDpJjFsOrMKLiWfRHTp FcHTdiPHvy/7H1krfl8ikQ3r6HcU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=EY/tZSTQ1owdWYWieqxxBxpeKWCgnJSXrzTmdfAVHwSw0uI1PYNyc9BiM7r1GB NIQ3rEMsLI2Aem54og2iti4k3vYKFURu+74Vr09G5sxffT40RJfF1LOkyM33C5Ld QpvsIRkEv+RiPweLc12Eb8scS9rw+1JXN/L+ofAhVvGic=; Received: (qmail 28579 invoked by alias); 3 Mar 2012 14:17:44 -0000 Received: (qmail 28563 invoked by uid 22791); 3 Mar 2012 14:17:41 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mx01.qsc.de (HELO mx01.qsc.de) (213.148.129.14) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 03 Mar 2012 14:17:27 +0000 Received: from [192.168.178.22] (port-92-204-104-94.dynamic.qsc.de [92.204.104.94]) by mx01.qsc.de (Postfix) with ESMTP id 67F9E3D357; Sat, 3 Mar 2012 15:17:24 +0100 (CET) Message-ID: <4F5227F4.3050809@net-b.de> Date: Sat, 03 Mar 2012 15:17:24 +0100 From: Tobias Burnus User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 MIME-Version: 1.0 To: fortran@gcc.gnu.org CC: gcc patches Subject: Re: [4.8, Fortran, Patch] PR 48820 - Support TYPE(*) of TS29113 References: <4F50AEDB.2010008@net-b.de> <4F51EECF.9090803@net-b.de> In-Reply-To: <4F51EECF.9090803@net-b.de> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Tobias Burnus wrote: > thanks for the review. > > Paul Richard Thomas wrote: > [...] Something is odd. The test case didn't regtest, but I could swear that it did so yesterday. _1.f90: That was correctly failing because one cannot pass an assumed-size array to an assumed-shape array. _4.f90: Somehow, the line has changed. _3.f90: Besides some more obvious issues, there is: "fourteen" is really odd: Depending on the position of that subroutine in file, I get an error or not. I think one should try to better understand why that happens. Tobias Index: gcc/testsuite/ChangeLog =================================================================== --- gcc/testsuite/ChangeLog (Revision 184855) +++ gcc/testsuite/ChangeLog (Arbeitskopie) @@ -1,6 +1,13 @@ 2012-03-03 Tobias Burnus PR fortran/48820 + * gfortran.dg/assumed_type_1.f90: Correct dg-error. + * gfortran.dg/assumed_type_3.f90: Correct dg-error. + * gfortran.dg/assumed_type_4.f90: Correct dg-error. + +2012-03-03 Tobias Burnus + + PR fortran/48820 * gfortran.dg/assumed_type_1.f90: New. * gfortran.dg/assumed_type_2.f90: New. * gfortran.dg/assumed_type_3.f90: New. Index: gcc/testsuite/gfortran.dg/assumed_type_1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/assumed_type_1.f90 (Revision 184855) +++ gcc/testsuite/gfortran.dg/assumed_type_1.f90 (Arbeitskopie) @@ -49,7 +49,6 @@ use mpi_interface contains subroutine foo(x) type(*):: x(*) - call MPI_Send(x, 1, 1,1,1,j,i) call MPI_Send2(x, 1, 1,1,1,j,i) end end Index: gcc/testsuite/gfortran.dg/assumed_type_4.f90 =================================================================== --- gcc/testsuite/gfortran.dg/assumed_type_4.f90 (Revision 184855) +++ gcc/testsuite/gfortran.dg/assumed_type_4.f90 (Arbeitskopie) @@ -5,6 +5,6 @@ ! ! Test TYPE(*) -subroutine one(a) ! { dg-error "TS 29113: Assumed type" } - type(*) :: a +subroutine one(a) + type(*) :: a ! { dg-error "TS 29113: Assumed type" } end subroutine one Index: gcc/testsuite/gfortran.dg/assumed_type_3.f90 =================================================================== --- gcc/testsuite/gfortran.dg/assumed_type_3.f90 (Revision 184855) +++ gcc/testsuite/gfortran.dg/assumed_type_3.f90 (Arbeitskopie) @@ -5,6 +5,11 @@ ! ! Test TYPE(*) +subroutine fourteen(x) + type(*) :: x + x = x ! { dg-error "Invalid expression with assumed-type variable" } +end subroutine fourteen + subroutine one(a) ! { dg-error "may not have the ALLOCATABLE, CODIMENSION, POINTER or VALUE attribute" } type(*), value :: a end subroutine one @@ -52,10 +57,10 @@ subroutine nine() subroutine okay2(x) type(*) :: x(*) end subroutine okay2 - subroutine okay2(x,y) + subroutine okay3(x,y) integer :: x type(*) :: y - end subroutine okay2 + end subroutine okay3 end interface interface two subroutine okok1(x) @@ -100,10 +105,10 @@ end subroutine eleven subroutine twelf(x) type(*) :: x - call bar(x) + call bar(x) ! { dg-error "Type mismatch in argument" } contains subroutine bar(x) - integer :: x ! { dg-error "Type mismatch in argument" } + integer :: x end subroutine bar end subroutine twelf @@ -113,7 +118,4 @@ subroutine thirteen(x, y) print *, ubound(y, dim=x) ! { dg-error "must be INTEGER" } end subroutine thirteen -subroutine fourteen(x) - type(*) :: x - x = x ! { dg-error "Invalid expression with assumed-type variable" } -end subroutine fourteen +