From patchwork Sat Jan 21 22:57:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Marlier X-Patchwork-Id: 137215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id D1C15B6FB6 for ; Sun, 22 Jan 2012 09:59:23 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1327791564; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC: Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=6OFNNpIikoZ6O95jvn7ND2L45+s=; b=n9R1xY65b0nwKfkCSYc1DFGYIiERc0VoiTwWq6F2afVnokrVOqGQJiQantMe5+ 7oj6xWqE7XeY7OzVsvJge/kgZsYpycmYsbwCvjTB2YBgzvTqr3Kj99xToJ8xTD91 lLWt+s31W7iyJqax0DnmIUoq+v9XBE3XYoQr+Hes2RjkA= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=xTgwpbKpvfBuqI6ZGR8bDEC+KJzyeyzb4S+1p/2tC0l6KyHKRK+yWqy8bC+U50 hrJjMBaxh7bNXlFh1QQGV0YZJauaHr8DEYB8jgWd7Vp7CML/CC0SXATHWimTIWb0 S2Uuk+YYyw6hzZgJqX5YPpSH+ZJmKze7E6gvvGBAlgRQA=; Received: (qmail 26200 invoked by alias); 21 Jan 2012 22:59:20 -0000 Received: (qmail 26190 invoked by uid 22791); 21 Jan 2012 22:59:19 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qy0-f175.google.com (HELO mail-qy0-f175.google.com) (209.85.216.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Jan 2012 22:59:07 +0000 Received: by qcsp14 with SMTP id p14so907169qcs.20 for ; Sat, 21 Jan 2012 14:59:07 -0800 (PST) Received: by 10.229.69.70 with SMTP id y6mr944816qci.48.1327186637970; Sat, 21 Jan 2012 14:57:17 -0800 (PST) Received: from [192.168.2.2] (cpe-69-207-95-157.rochester.res.rr.com. [69.207.95.157]) by mx.google.com with ESMTPS id dk2sm16037330qab.12.2012.01.21.14.57.16 (version=SSLv3 cipher=OTHER); Sat, 21 Jan 2012 14:57:17 -0800 (PST) Message-ID: <4F1B42CC.60808@gmail.com> Date: Sat, 21 Jan 2012 17:57:16 -0500 From: Patrick Marlier User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: Dominique Dhumieres CC: gcc-patches@gcc.gnu.org, aldyh@redhat.com, Iain Sandoe Subject: Re: [PATCH] PR51280 LTO/trans-mem ICE with TM builtins References: <20120120130449.5729E3BE18@mailhost.lps.ens.fr> In-Reply-To: <20120120130449.5729E3BE18@mailhost.lps.ens.fr> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 01/20/2012 08:04 AM, Dominique Dhumieres wrote: >> The following patch fixes the problem. > > The test fails on *-apple-darwin*: pr51916. > > TIA > > Dominique Dominique or Iain, may I ask you to test this patch on darwin? I have a sporadic access to a darwin machine. Bootstrapped and tested on x86_64-unknown-linux-gnu. --- Patrick. PR lto/51916 * lto-object.c (LTO_SEGMENT_NAME): Define segment name. (lto_obj_file_open): Use it. Index: lto-wrapper.c =================================================================== --- lto-wrapper.c (revision 183345) +++ lto-wrapper.c (working copy) @@ -54,6 +54,11 @@ along with GCC; see the file COPYING3. If not see /* End of lto-streamer.h copy. */ +/* Segment name for LTO sections. This is only used for Mach-O. + FIXME: This needs to be kept in sync with darwin.c. */ + +#define LTO_SEGMENT_NAME "__GNU_LTO" + int debug; /* true if -save-temps. */ int verbose; /* true if -v. */ @@ -479,7 +484,8 @@ run_gcc (unsigned argc, char *argv[]) fd = open (argv[i], O_RDONLY); if (fd == -1) continue; - sobj = simple_object_start_read (fd, file_offset, NULL, &errmsg, &err); + sobj = simple_object_start_read (fd, file_offset, LTO_SEGMENT_NAME, + &errmsg, &err); if (!sobj) { close (fd);