From patchwork Mon Mar 23 13:10:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 1259996 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48mF9m3MzLz9sSh for ; Tue, 24 Mar 2020 00:10:34 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D6E43937424; Mon, 23 Mar 2020 13:10:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 9BA2A3885C19 for ; Mon, 23 Mar 2020 13:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9BA2A3885C19 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: YXMVHf1mY7kI+njLrkp+C161rklRV/nKsUKrKs8JReJJ9ALhE8CccLpgiXUCURc27I0m2NQCkt l08ds8bEk7h2lAi/j2OkNbWCUOTRdUzu8lNatmSiyZAQ9rfgyPGX0iMut6o4fl+P+GmzRDJK7R Xcs9DzpPpxHrl9vJYZCGReHF0h8EFFBYO7eFbSo2z6gsHeNK8Da9BJBJlAKCzCGOkhxfWDXIBt 1iM4ZVCbYqiw2wI68ZAHpPYEs5hJGm6LxiwrM8/bKk27HImb3K2vb9jSowCUMDPfPZ0hU+ihLX cKI= X-IronPort-AV: E=Sophos;i="5.72,296,1580803200"; d="diff'?scan'208";a="47042850" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa4.mentor.iphmx.com with ESMTP; 23 Mar 2020 05:10:27 -0800 IronPort-SDR: bJU+g6yGJbUQckfHc/40K1eHImkf4QiE0fVMbMhq388+/yFq3uTRsWNkS7XtZziEc5+qHA4skL NLsD0xelx3OcvPoeu49d2K0LjPJaegkbwLBDWwqbqZLwcvZwKZm8L2KQX67KkOYXIvR7oncMQI 9lNs6eXWcIX8puixVxOhG1f0Oer6GM8XFk1uai9XUyLUvpB4V0yH5HnJFBFc3hEvQEy8Foc0ud 90rPDaAu36lekHhI+OkauEdm8yLuw6AcMwdY9EEbh1qQw/GFAIkzIrWi4oSlWu5F+Bp2KXTnkO +ZA= To: gcc-patches , Jakub Jelinek , Richard Biener From: Tobias Burnus Subject: =?utf-8?b?W1BhdGNoXSBsdG8vbHRvLmMg4oCTIHVzZWQgJCBvciAuIGluIGdl?= =?utf-8?q?nerated_linkptr_name?= Message-ID: <4156ecb6-4f7c-a7a7-12a1-d41a42b41975@codesourcery.com> Date: Mon, 23 Mar 2020 14:10:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-34.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" As discussed in IRC, it makes sense to use '$' or '.' as separator instead of '_' – and, if it is not available, use a '__' prefix besides the '_' suffix separator. OK? Tobias ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter lto/lto.c – used $ or . in generated linkptr name * lto.c (offload_handle_link_vars): Reduce chance of naming clashes of generated linkptr variable. diff --git a/gcc/lto/lto.c b/gcc/lto/lto.c index 467b922eedf..cd34d6c9e7a 100644 --- a/gcc/lto/lto.c +++ b/gcc/lto/lto.c @@ -561,11 +561,9 @@ offload_handle_link_vars (void) DECL_ATTRIBUTES (var->decl))) { tree type = build_pointer_type (TREE_TYPE (var->decl)); - tree var_name = DECL_ASSEMBLER_NAME (var->decl); - char *new_name - = ACONCAT ((IDENTIFIER_POINTER (var_name), "_linkptr", NULL)); tree link_ptr_var = build_decl (UNKNOWN_LOCATION, VAR_DECL, - get_identifier (new_name), type); + clone_function_name (var->decl, + "linkptr"), type); TREE_USED (link_ptr_var) = 1; TREE_STATIC (link_ptr_var) = 1; DECL_ARTIFICIAL (link_ptr_var) = 1;