diff mbox series

combine: Don't generate IF_THEN_ELSE

Message ID 38963ab67c2fa28a6d57b710d70cab77d3309ab9.1557446601.git.segher@kernel.crashing.org
State New
Headers show
Series combine: Don't generate IF_THEN_ELSE | expand

Commit Message

Segher Boessenkool May 10, 2019, 12:04 a.m. UTC 
On all targets I managed to test (21) this results in better code.  Only
alpha ends up with slightly bigger code.

Committing to trunk.


Segher


2019-05-10  Segher Boessenkool  <segher@kernel.crashing.org>

	* combine.c (combine_simplify_rtx): Don't make IF_THEN_ELSE RTL.

---
 gcc/combine.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Andrew Pinski Nov. 4, 2019, 1:50 a.m. UTC | #1 
On Thu, May 9, 2019 at 5:05 PM Segher Boessenkool
<segher@kernel.crashing.org> wrote:
>
> On all targets I managed to test (21) this results in better code.  Only
> alpha ends up with slightly bigger code.
>
> Committing to trunk.

This introduced:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92342

Thanks,
Andrew Pinski

>
>
> Segher
>
>
> 2019-05-10  Segher Boessenkool  <segher@kernel.crashing.org>
>
>         * combine.c (combine_simplify_rtx): Don't make IF_THEN_ELSE RTL.
>
> ---
>  gcc/combine.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/gcc/combine.c b/gcc/combine.c
> index 7b236225..8c4375f 100644
> --- a/gcc/combine.c
> +++ b/gcc/combine.c
> @@ -5937,14 +5937,6 @@ combine_simplify_rtx (rtx x, machine_mode op0_mode, int in_dest,
>                                                                  mode, VOIDmode,
>                                                                  cond, cop1),
>                                         mode);
> -             else
> -               return gen_rtx_IF_THEN_ELSE (mode,
> -                                            simplify_gen_relational (cond_code,
> -                                                                     mode,
> -                                                                     VOIDmode,
> -                                                                     cond,
> -                                                                     cop1),
> -                                            true_rtx, false_rtx);
>
>               code = GET_CODE (x);
>               op0_mode = VOIDmode;
> --
> 1.8.3.1
>
diff mbox series

Patch

diff --git a/gcc/combine.c b/gcc/combine.c
index 7b236225..8c4375f 100644
--- a/gcc/combine.c
+++ b/gcc/combine.c
@@ -5937,14 +5937,6 @@  combine_simplify_rtx (rtx x, machine_mode op0_mode, int in_dest,
 								 mode, VOIDmode,
 								 cond, cop1),
 					mode);
-	      else
-		return gen_rtx_IF_THEN_ELSE (mode,
-					     simplify_gen_relational (cond_code,
-								      mode,
-								      VOIDmode,
-								      cond,
-								      cop1),
-					     true_rtx, false_rtx);
 
 	      code = GET_CODE (x);
 	      op0_mode = VOIDmode;