From patchwork Wed Apr 8 16:02:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 1268158 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48y8Dl1nwvz9sRN for ; Thu, 9 Apr 2020 02:02:31 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12CA1394443F; Wed, 8 Apr 2020 16:02:26 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 54E1F385B835; Wed, 8 Apr 2020 16:02:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 54E1F385B835 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Tobias_Burnus@mentor.com IronPort-SDR: Q195gESXoJ739gE6XD+3qCgFDrscgffA/gAlP9UqlSgMCoFwSeNPeSztVNaU/yubER8OPeO3cK dkE9gh08A+AsLlZr5sIpXZPqUQ4AVNS0NDpFKbamM+stgE3E91lFBhxJSEpgCiFrV3Mml5v/77 qz4w1w7QnCaqeaCAXX9r7ABNa1K7QUNZBfkNwx3zU4wu3NGrJ1GWhUX9u3YLB7lZqtP6V+Af2o 6t4NzBdVpTZvyPugI7nwP+1OukRssvLuT9qisg29+cj2wnU8dhUJSo1jniNiSkpZNpNWfDiKk3 iKY= X-IronPort-AV: E=Sophos;i="5.72,359,1580803200"; d="diff'?scan'208";a="47481786" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 08 Apr 2020 08:02:21 -0800 IronPort-SDR: JfMkCHIYXEACpasQzzmk3ovJb3BMre+P+Cg4Bh6LWPod7Jb21iPVGHRaj9KGngjJtSCF7hc4Js y1TDz1VtGmTdsh/xke+tXqgl67QyXnUlW5Q4kcZ6U+X8buLnj+xbFMpzAdtNLiPQzBEhgCecIJ /KVq0wR6CJORDJs7fLIDo4+MF4iGAP2DIzolYnfGHAlbJcjnOq3lDrnD1MOBwHkXr1oFzI6CVy h9uCqUA4L1F+CK/zclEP1+MdAatsesW0Z4qh8Hvs7Q7BMYwesLHmUWZ1YIUfkPqiV4N7SvoGeF EmE= Subject: [patch, committed] Move gfortran.dg/dec_math_5.f90 to ./ieee/ (was: Re: PATCH -- Fix degree trignometric functions) To: Andreas Schwab , Fritz Reese via Fortran References: <20200306231819.GA66443@troutmask.apl.washington.edu> <87pncim32g.fsf@igel.home> From: Tobias Burnus Message-ID: <2f397750-bbdc-1a80-d3a8-33119df495cb@codesourcery.com> Date: Wed, 8 Apr 2020 18:02:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <87pncim32g.fsf@igel.home> Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-Spam-Status: No, score=-25.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fritz Reese , gcc-patches , Steve Kargl Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Hi Andreas, thanks for the report. In principle, it would be helpful to know on which target you are running the test case. However, I assume that either of the following went wrong: * Target does not support IEEE * It supports it, but gfortran's intrinsic search path does not point to directory in which the ieee modules are That's solved by moving the test case to the ieee/ subdirectory which has a check whether IEEE works and also sets the intrinsic module include path (-fintrinsic-modules-path $specpath/libgfortran/). I have now committed it as obvious – but I would be good when you can confirm that it works (PASS if it should support IEEE or, if not, UNSUPPORTED). See r10-7631-gfaa0817311f43e0d4d223d53c816b0c74ec35c4e or attachment. Cheers, Tobias On 4/8/20 5:04 PM, Andreas Schwab wrote: > FAIL: gfortran.dg/dec_math_5.f90 -O0 (test for excess errors) > Excess errors: > /opt/gcc/gcc-20200408/gcc/testsuite/gfortran.dg/dec_math_5.f90:132:9: Fatal Error: Cannot open module file 'ieee_arithmetic.mod' for reading at (1): No such file or directory > compilation terminated. > > Andreas. > ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter commit faa0817311f43e0d4d223d53c816b0c74ec35c4e Author: Tobias Burnus Date: Wed Apr 8 17:54:04 2020 +0200 Move gfortran.dg/dec_math_5.f90 to ./ieee/ PR fortran/93871 * gfortran.dg/dec_math_5.f90: Move to ... * gfortran.dg/ieee/dec_math_1.f90: ... here; change dg-options to dg-additional-options. --- gcc/testsuite/ChangeLog | 7 +++++++ gcc/testsuite/gfortran.dg/{dec_math_5.f90 => ieee/dec_math_1.f90} | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 557c81544e4..347181619a5 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2020-04-08 Tobias Burnus + + PR fortran/93871 + * gfortran.dg/dec_math_5.f90: Move to ... + * gfortran.dg/ieee/dec_math_1.f90: ... here; change + dg-options to dg-additional-options. + 2020-04-08 Alexandre Oliva * gcc.dg/tls/pr78796.c: Require tls_runtime. diff --git a/gcc/testsuite/gfortran.dg/dec_math_5.f90 b/gcc/testsuite/gfortran.dg/ieee/dec_math_1.f90 similarity index 97% rename from gcc/testsuite/gfortran.dg/dec_math_5.f90 rename to gcc/testsuite/gfortran.dg/ieee/dec_math_1.f90 index d761e039cc8..8587fd66eb1 100644 --- a/gcc/testsuite/gfortran.dg/dec_math_5.f90 +++ b/gcc/testsuite/gfortran.dg/ieee/dec_math_1.f90 @@ -1,8 +1,11 @@ -! { dg-options "-cpp -std=gnu" } ! { dg-do run } +! { dg-additional-options "-cpp -std=gnu" } ! ! Test values for degree-valued trigonometric intrinsics. ! +! Run under ieee/ as +! use ieee_arithmetic +! (used for result checking) is not available on all platforms) module dec_math_5