| Message ID | 2c27039b413c6b6125e5aa4e6a5ce4242681238b.1393381023.git.apinski@cavium.com |
|---|---|
| State | New |
| Headers | show |
On 26 February 2014 02:25, Andrew Pinski <apinski@cavium.com> wrote: > > Hi, > Just like most of the targets out there we should define > TRY_EMPTY_VM_SPACE to have better PCH support. > > OK? Built and tested on aarch64-linux-gnu with no regressions. This is OK for stage-1. /Marcus
On Tue, Feb 25, 2014 at 06:25:11PM -0800, Andrew Pinski wrote: > -#elif defined(__aarch64__) > +#elif defined(__aarch64__) && defined(__LP64__) > # define TRY_EMPTY_VM_SPACE 0x1000000000 > +#elif defined(__aarch64__) > +# define TRY_EMPTY_VM_SPACE 0x60000000 awesome. thanks andrew! --kyle
On 26/02/14 02:25, Andrew Pinski wrote: > > Hi, > Just like most of the targets out there we should define > TRY_EMPTY_VM_SPACE to have better PCH support. > > OK? Built and tested on aarch64-linux-gnu with no regressions. > > Thanks, > Andrew Pinski > > * config/host-linux.c (TRY_EMPTY_VM_SPACE): Change aarch64 ilp32 > definition. > --- > gcc/ChangeLog | 5 +++++ > gcc/config/host-linux.c | 4 +++- > 2 files changed, 8 insertions(+), 1 deletions(-) > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 616d8ec..fd2b6cd 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,8 @@ > +2014-02-25 Andrew Pinski <apinski@cavium.com> > + > + * config/host-linux.c (TRY_EMPTY_VM_SPACE): Change aarch64 ilp32 > + definition. > + > 2014-02-25 Vladimir Makarov <vmakarov@redhat.com> > > PR rtl-optimization/60317 > diff --git a/gcc/config/host-linux.c b/gcc/config/host-linux.c > index 17048d7..b298a17 100644 > --- a/gcc/config/host-linux.c > +++ b/gcc/config/host-linux.c > @@ -86,8 +86,10 @@ > # define TRY_EMPTY_VM_SPACE 0x60000000 > #elif defined(__mc68000__) > # define TRY_EMPTY_VM_SPACE 0x40000000 > -#elif defined(__aarch64__) > +#elif defined(__aarch64__) && defined(__LP64__) > # define TRY_EMPTY_VM_SPACE 0x1000000000 > +#elif defined(__aarch64__) > +# define TRY_EMPTY_VM_SPACE 0x60000000 > #elif defined(__ARM_EABI__) > # define TRY_EMPTY_VM_SPACE 0x60000000 > #elif defined(__mips__) && defined(__LP64__) > I'd prefer to see this written as: -#elif defined(__aarch64__) +#elif defined(__aarch64__) && defined(__ILP32__) # define TRY_EMPTY_VM_SPACE 0x60000000 +#elif defined(__aarch64__) +# define TRY_EMPTY_VM_SPACE 0x1000000000 Since I'd expect there to be a much higher likelihood of another variant that uses 64-bit pointers (eg LLP64) than of there being another variant that uses 32-bit. R.
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 616d8ec..fd2b6cd 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2014-02-25 Andrew Pinski <apinski@cavium.com> + + * config/host-linux.c (TRY_EMPTY_VM_SPACE): Change aarch64 ilp32 + definition. + 2014-02-25 Vladimir Makarov <vmakarov@redhat.com> PR rtl-optimization/60317 diff --git a/gcc/config/host-linux.c b/gcc/config/host-linux.c index 17048d7..b298a17 100644 --- a/gcc/config/host-linux.c +++ b/gcc/config/host-linux.c @@ -86,8 +86,10 @@ # define TRY_EMPTY_VM_SPACE 0x60000000 #elif defined(__mc68000__) # define TRY_EMPTY_VM_SPACE 0x40000000 -#elif defined(__aarch64__) +#elif defined(__aarch64__) && defined(__LP64__) # define TRY_EMPTY_VM_SPACE 0x1000000000 +#elif defined(__aarch64__) +# define TRY_EMPTY_VM_SPACE 0x60000000 #elif defined(__ARM_EABI__) # define TRY_EMPTY_VM_SPACE 0x60000000 #elif defined(__mips__) && defined(__LP64__)