From patchwork Wed Apr 26 19:26:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew MacLeod X-Patchwork-Id: 1774242 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=d/uCdwOC; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q684m57zWz23vF for ; Thu, 27 Apr 2023 05:26:48 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AFBF93854164 for ; Wed, 26 Apr 2023 19:26:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFBF93854164 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1682537206; bh=edUT3M6aGdYeYiOrHa9pQzeoKXs3t/mFLjBurcZaEVg=; h=Date:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=d/uCdwOCqA8CXJ89CgqkEnh71zgYIRecIZOzHfW6J9wgFV8cdD9KU6lZ1PCulVstg CQrvaVjR8XilXm8Q4wja46jP5G5/+FTbI4DzEk2ZA5jk/rnzQ1Gt3/tn/fUG9Fs0uo 5+XDbV+XeoKrqVcQnv+cYbIPIkl9MxUjRd51rLhE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 826F53856DD9 for ; Wed, 26 Apr 2023 19:26:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 826F53856DD9 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-c7nvi4m7O2SEG0n6vqH-AQ-1; Wed, 26 Apr 2023 15:26:25 -0400 X-MC-Unique: c7nvi4m7O2SEG0n6vqH-AQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-5f55eefb3b6so44174076d6.0 for ; Wed, 26 Apr 2023 12:26:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682537184; x=1685129184; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kULoy/svlVO/GsZ6rYzdF8RS5xu+JoF5fJ00CRHpo7g=; b=DXbMD+WxCeZGQ/fqtIa8a/fMBRfII/VyAoBZpl8NDVFwED0gFjWSitnw3g1h4ZtCnK QroomLfPRtT9NwRWuPmpM7bBLYmzBkFkZXKVaYDu2HBDj5txhrPpCTYNTwKzNJKxKCdq gdoh2JlET1jzptjjBG2PJDbRtmHNbxKul1CMT9L+UQbifz77D8Rs2ZLBmJ5PZCtHxZVb oWkCUGPilDbVgn2qkQqHHhMYL8eBB9qPSm5KtaH/wF8i9/zyIfVj7x6e27CEcBIPRjmI 75Vvt85Y8ynzjBeelyLFizppQ9V3ugIeg4QzPuXk5kHXSve+uUQzb9KlBq4b+y9Fw8ZQ pYwg== X-Gm-Message-State: AC+VfDxVAA3wuLDRxb6uvk80TpKXBzFT/nv0U4OUwnE408Htnt2WvJV4 KMkJ9aW/TOtngT6CLKuK281CVe+hSSTdIV+3Ta8HcJOsaMzAya1eSChQvVzcpIvYyS3oRFvAS7n BJ3QDagCqTwaP2NODf7x9mWvdYjv2zC3okd0PgMtuCmh7bKcyTK3Uf0qnkvEuHVeQBrn4S6wI5L 7vOQ== X-Received: by 2002:a05:6214:c4b:b0:616:58f1:2844 with SMTP id r11-20020a0562140c4b00b0061658f12844mr7415403qvj.45.1682537184621; Wed, 26 Apr 2023 12:26:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5pl7yaPhT+U7vkSp8rlgEEbu4tnyxS7kVC8vpA871a41bqVPop+fzpPJmBnCpVUMvjv+zwsw== X-Received: by 2002:a05:6214:c4b:b0:616:58f1:2844 with SMTP id r11-20020a0562140c4b00b0061658f12844mr7415226qvj.45.1682537182495; Wed, 26 Apr 2023 12:26:22 -0700 (PDT) Received: from ?IPV6:2607:fea8:51df:4200::1dcd? ([2607:fea8:51df:4200::1dcd]) by smtp.gmail.com with ESMTPSA id dz2-20020a05620a2b8200b0074d3233487dsm5356763qkb.114.2023.04.26.12.26.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 12:26:22 -0700 (PDT) Message-ID: <28bd16f7-f334-3245-c444-65a23e98d020@redhat.com> Date: Wed, 26 Apr 2023 15:26:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: gcc-patches Cc: "hernandez, aldy" Subject: [COMMITTED 2/5] Quicker relation check. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew MacLeod via Gcc-patches From: Andrew MacLeod Reply-To: Andrew MacLeod Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" If either of the SSA names in a comparison do not have any equivalences or relations, we can short-circuit the check slightly and be a bit faster. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew From ee03aca78fb5739f4cd76cb30332f8aff2c5243a Mon Sep 17 00:00:00 2001 From: Andrew MacLeod Date: Wed, 8 Feb 2023 12:36:23 -0500 Subject: [PATCH 2/5] Quicker relation check. If either of the SSA names in a comparison do not have any equivalences or relations, we can short-circuit the check slightly. * value-relation.cc (dom_oracle::query_relation): Check early for lack of any relation. * value-relation.h (equiv_oracle::has_equiv_p): New. --- gcc/value-relation.cc | 6 ++++++ gcc/value-relation.h | 1 + 2 files changed, 7 insertions(+) diff --git a/gcc/value-relation.cc b/gcc/value-relation.cc index 30a02d3c9d3..65cf7694d40 100644 --- a/gcc/value-relation.cc +++ b/gcc/value-relation.cc @@ -1374,6 +1374,12 @@ dom_oracle::query_relation (basic_block bb, tree ssa1, tree ssa2) if (v1 == v2) return VREL_EQ; + // If v1 or v2 do not have any relations or equivalences, a partial + // equivalence is the only possibility. + if ((!bitmap_bit_p (m_relation_set, v1) && !has_equiv_p (v1)) + || (!bitmap_bit_p (m_relation_set, v2) && !has_equiv_p (v2))) + return partial_equiv (ssa1, ssa2); + // Check for equivalence first. They must be in each equivalency set. const_bitmap equiv1 = equiv_set (ssa1, bb); const_bitmap equiv2 = equiv_set (ssa2, bb); diff --git a/gcc/value-relation.h b/gcc/value-relation.h index 3177ecb1ad0..be6e277421b 100644 --- a/gcc/value-relation.h +++ b/gcc/value-relation.h @@ -170,6 +170,7 @@ public: void dump (FILE *f) const override; protected: + inline bool has_equiv_p (unsigned v) { return bitmap_bit_p (m_equiv_set, v); } bitmap_obstack m_bitmaps; struct obstack m_chain_obstack; private: -- 2.39.2