| Message ID | 28b4689c-80c4-52df-d05d-f91fd9bb348d@acm.org |
|---|---|
| State | New |
| Headers | show |
| Series | libcody: Fix for dash | expand |
Nathan Sidwell <nathan@acm.org> writes: > Apparently 'var+=...' is not a dash thing. Fixed thusly. > > * config.m4: Avoid non-dash idiom > * configure: Rebuilt. > > pushed (2 patches, because I didn't look carefully enough the first time) Thanks. I think the other uses of += need the same treatment though: CXX+=" -I$tools/include" toollib+="/${os}" CXX+=" -std=c++11" [CXX+=" -std=c++20" AC_SEARCH_LIBS([bfd_openr],[bfd],[LIBS+="-lz -liberty -ldl"],,[-lz -liberty -ldl]) CONFIG_FILES+=" $dir/Makesub" test -f ${srcdir}/$dir/tests/Makesub.in && CONFIG_FILES+=" $dir/tests/Makesub" Richard
On 12/16/20 5:02 AM, Richard Sandiford wrote: > Nathan Sidwell <nathan@acm.org> writes: >> Apparently 'var+=...' is not a dash thing. Fixed thusly. >> >> * config.m4: Avoid non-dash idiom >> * configure: Rebuilt. >> >> pushed (2 patches, because I didn't look carefully enough the first time) > > Thanks. I think the other uses of += need the same treatment though: thanks, I think this gets them all. There were still some dash-killing uses of +=. Fixed thusly. * config.m4: Replace V+="..." with V="$V..." * configure: Rebuilt. nathan
diff --git i/libcody/config.m4 w/libcody/config.m4 index 0ae7b2665f0..801cfbdb593 100644 --- i/libcody/config.m4 +++ w/libcody/config.m4 @@ -173,7 +173,7 @@ AC_SUBST(EXCEPTIONS)]) AC_DEFUN([NMS_LINK_OPT], [AC_MSG_CHECKING([adding $1 to linker]) ORIG_LDFLAGS="$LDFLAGS" -LDFLAGS+=" $1" +LDFLAGS="$LDFLAGS $1" AC_LINK_IFELSE([AC_LANG_PROGRAM([])], [AC_MSG_RESULT([ok])], [LDFLAGS="$ORIG_LDFLAGS" @@ -229,8 +229,8 @@ elif test "$withval" = "no" ; then AC_MSG_RESULT(installed) else AC_MSG_RESULT(${withval}) - CPPFLAGS+=" -I${withval}/include" - LDFLAGS+=" -L${withval}/lib" + CPPFLAGS="$CPPFLAGS -I${withval}/include" + LDFLAGS="$LDFLAGS -L${withval}/lib" fi, AC_MSG_RESULT(installed))]) diff --git i/libcody/configure w/libcody/configure index 8f22dd78134..1a119c59b9f 100755 --- i/libcody/configure +++ w/libcody/configure @@ -2639,7 +2639,7 @@ fi { $as_echo "$as_me:${as_lineno-$LINENO}: checking adding -Wl,--no-undefined to linker" >&5 $as_echo_n "checking adding -Wl,--no-undefined to linker... " >&6; } ORIG_LDFLAGS="$LDFLAGS" -LDFLAGS+=" -Wl,--no-undefined" +LDFLAGS="$LDFLAGS -Wl,--no-undefined" cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */
Apparently 'var+=...' is not a dash thing. Fixed thusly. * config.m4: Avoid non-dash idiom * configure: Rebuilt. pushed (2 patches, because I didn't look carefully enough the first time)