From patchwork Sun Aug 25 20:11:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 269721 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "www.sourceware.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id B4BA52C0084 for ; Mon, 26 Aug 2013 06:11:18 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=hYxW3GYLeTL1g7CFgTDpYD8fUuADWJxSmsxSMq1sN6cL+b5kvYbQ4 Bd7K/mP90sGvMyd2yTTMQU0SjiONWVOaKTMkhVzgCGRvkeK5807pFMnXUqy3RflY 65gjebiPsbIvMk+Eui3jStPiwQMCqSSkjYwhVY14jwcoIOv/dxfw2U= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=SblL7YhfSKX+rEAm1OARn+eJ/LM=; b=uVrEfoR8Keg0VtN6B6kI4YliO9WJ NJ+Fyft8tNWX+I8XxWekxU76CtROuMn47gkqOHSJrVu2+nezqLl6jzVUO+4XUHl7 zBlKxYTQF8uyB0beCf8oaw0PUr7SoAAdzRrMfdPnCsYcuEWLP7EU5dysGj/HwO0j FOorkqWRp2eW6Qs= Received: (qmail 5427 invoked by alias); 25 Aug 2013 20:11:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5406 invoked by uid 89); 25 Aug 2013 20:11:11 -0000 X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 Received: from qmta08.emeryville.ca.mail.comcast.net (HELO qmta08.emeryville.ca.mail.comcast.net) (76.96.30.80) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 25 Aug 2013 20:11:10 +0000 Received: from omta12.emeryville.ca.mail.comcast.net ([76.96.30.44]) by qmta08.emeryville.ca.mail.comcast.net with comcast id H7rE1m0020x6nqcA88B8H1; Sun, 25 Aug 2013 20:11:08 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta12.emeryville.ca.mail.comcast.net with comcast id H8B71m00R0BKwT48Y8B7Wd; Sun, 25 Aug 2013 20:11:08 +0000 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: wide-int branch now up for public comment and review From: Mike Stump In-Reply-To: <87li3pd3p6.fsf@talisman.default> Date: Sun, 25 Aug 2013 13:11:06 -0700 Cc: Kenneth Zadeck , rguenther@suse.de, gcc-patches , r.sandiford@uk.ibm.com Message-Id: <28EEF185-4824-402C-BA76-48E0AE469ABE@comcast.net> References: <520A9DCC.6080609@naturalbridge.com> <87ppt4e9hg.fsf@talisman.default> <87li3pd3p6.fsf@talisman.default> To: Richard Sandiford On Aug 25, 2013, at 11:29 AM, Richard Sandiford wrote: > Looks like wide-int is just using BITS_PER_UNIT to get the number of > bits in "char". That's a host thing, so it should be CHAR_BIT instead. Oh, Kenny did point out one sin: which I fixed. diff --git a/gcc/wide-int.cc b/gcc/wide-int.cc index 37ce5b3..891c227 100644 --- a/gcc/wide-int.cc +++ b/gcc/wide-int.cc @@ -2056,7 +2056,7 @@ wide_int_ro::mul_internal (bool high, bool full, /* The 2 is for a full mult. */ memset (r, 0, half_blocks_needed * 2 - * HOST_BITS_PER_HALF_WIDE_INT / BITS_PER_UNIT); + * HOST_BITS_PER_HALF_WIDE_INT / CHAR_BIT); for (j = 0; j < half_blocks_needed; j++) {