From patchwork Tue Apr 23 14:35:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1089450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-499555-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="OoFqlZFt"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44pQwD4Vnxz9sNp for ; Wed, 24 Apr 2019 00:35:22 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type; q=dns; s= default; b=H2LgyRL6paF1LBriSHPmj034zreiTQKsg7tE+qF+7RIZhMRKP/XfS DCIrwacFRbMpHVz+nKl6VixAStLKFnVghFt/U8BfmGWXjSGz6Jd6KcT7ONgcNdzd ude/yhEPuiZg5eS3E2hkGYiokNzX8189umNBgHYX4odxfmIyUYvtQI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :subject:to:message-id:date:mime-version:content-type; s= default; bh=hfg49WiRRK5zAPatfh5+N5yw19A=; b=OoFqlZFtT3f3PcBiGki9 mUfWtZITQHO60ANxxYMIjAE+NMOEAQTinthVkOai33mKpmKQvm6ig65Iky3YP42m OsGIv7WajA2XzOtpOp6OxnJU4bSZiuEDPQfYd0LaXjzx7wEKw3F42eVk6qNNUV55 lRbNGRnRl6WH2o67TGL4PVw= Received: (qmail 92597 invoked by alias); 23 Apr 2019 14:35:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 92588 invoked by uid 89); 23 Apr 2019 14:35:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=logs, showed X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Apr 2019 14:35:14 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F97C307D934 for ; Tue, 23 Apr 2019 14:35:13 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-15.rdu2.redhat.com [10.10.112.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id A479460C8E for ; Tue, 23 Apr 2019 14:35:11 +0000 (UTC) From: Jeff Law Subject: [committed] Mark cr16 as keeping null pointer checks in target-supports.exp Openpgp: preference=signencrypt To: gcc-patches Message-ID: <26e2d70e-4ca4-952d-9867-a295c9532327@redhat.com> Date: Tue, 23 Apr 2019 08:35:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 X-IsSubscribed: yes My tester showed a spurious regression with a recent patch on cr16. In reviewing the logs I saw unexpected results for the proposed changes to isolate-2.c and isolate-4.c. The cr16 turns off NULL pointer check elimination, but isn't listed as doing so in target-supports.exp. As a result we run the tests, but they fail. This patch adds cr16 to the list of targets that keep null pointer checks and those tests are now skipped. I'm installing this on the trunk momentarily. Jeff * lib/target-supports.exp (check_effective_target_keeps_null_pointer_checks): Add cr16. diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 0dc1e184f55..4bb7da283f1 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -559,7 +559,7 @@ proc check_effective_target_keeps_null_pointer_checks { } { if [target_info exists keeps_null_pointer_checks] { return 1 } - if { [istarget msp430-*-*] } { + if { [istarget msp430-*-*] || [istarget cr16-*-*] } { return 1; } return 0