| Message ID | 227dcbda-843a-bcf1-5534-6ea2739e4355@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [OBVIOUS] rs6000: Remove redundant MEM_P predicate usage | expand |
On 7/10/23 11:47 AM, Peter Bergner wrote: > While helping someone on the team debug an issue, I noticed some redundant > tests in a couple of our predicates which can be removed. I'm going to > commit the following as obvious once bootstrap and regtesting come back > clean. > > Peter > > > rs6000: Remove redundant MEM_P predicate usage > > The quad_memory_operand and vsx_quad_dform_memory_operand predicates contain > a (match_code "mem") test, making their MEM_P usage redundant. Remove them. > > gcc/ > * config/rs6000/predicates.md (quad_memory_operand): Remove redundant > MEM_P usage. > (vsx_quad_dform_memory_operand): Likewise. Testing was clean as expected. Pushed to trunk. Peter
diff --git a/gcc/config/rs6000/predicates.md b/gcc/config/rs6000/predicates.md index 8479331482e..3552d908e9d 100644 --- a/gcc/config/rs6000/predicates.md +++ b/gcc/config/rs6000/predicates.md @@ -912,7 +912,7 @@ (define_predicate "quad_memory_operand" if (!TARGET_QUAD_MEMORY && !TARGET_SYNC_TI) return false; - if (GET_MODE_SIZE (mode) != 16 || !MEM_P (op) || MEM_ALIGN (op) < 128) + if (GET_MODE_SIZE (mode) != 16 || MEM_ALIGN (op) < 128) return false; return quad_address_p (XEXP (op, 0), mode, false); @@ -924,7 +924,7 @@ (define_predicate "quad_memory_operand" (define_predicate "vsx_quad_dform_memory_operand" (match_code "mem") { - if (!TARGET_P9_VECTOR || !MEM_P (op) || GET_MODE_SIZE (mode) != 16) + if (!TARGET_P9_VECTOR || GET_MODE_SIZE (mode) != 16) return false; return quad_address_p (XEXP (op, 0), mode, false);