diff mbox series

[committed] libstdc++: Reorder template params of std::optional comparisons (LWG 2945)

Message ID 20240725221241.151099-1-jwakely@redhat.com
State New
Headers show
Series [committed] libstdc++: Reorder template params of std::optional comparisons (LWG 2945) | expand

Commit Message

Jonathan Wakely July 25, 2024, 10:12 p.m. UTC 
Tested x86_64-linux. Pushed to trunk.

-- >8 --

libstdc++-v3/ChangeLog:

	* include/std/optional: Reorder parameters in comparison
	operators as per LWG 2945.
---
 libstdc++-v3/include/std/optional | 36 +++++++++++++++----------------
 1 file changed, 18 insertions(+), 18 deletions(-)
diff mbox series

Patch

diff --git a/libstdc++-v3/include/std/optional b/libstdc++-v3/include/std/optional
index 2cc0221865e..4694d594f98 100644
--- a/libstdc++-v3/include/std/optional
+++ b/libstdc++-v3/include/std/optional
@@ -1601,10 +1601,10 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { return __lhs && *__lhs == __rhs; }
 
   template<typename _Tp, typename _Up>
-    _REQUIRES_NOT_OPTIONAL(_Up)
+    _REQUIRES_NOT_OPTIONAL(_Tp)
     constexpr auto
-    operator==(const _Up& __lhs, const optional<_Tp>& __rhs)
-    -> __optional_eq_t<_Up, _Tp>
+    operator== [[nodiscard]] (const _Tp& __lhs, const optional<_Up>& __rhs)
+    -> __optional_eq_t<_Tp, _Up>
     { return __rhs && __lhs == *__rhs; }
 
   template<typename _Tp, typename _Up>
@@ -1615,10 +1615,10 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { return !__lhs || *__lhs != __rhs; }
 
   template<typename _Tp, typename _Up>
-    _REQUIRES_NOT_OPTIONAL(_Up)
+    _REQUIRES_NOT_OPTIONAL(_Tp)
     constexpr auto
-    operator!= [[nodiscard]] (const _Up& __lhs, const optional<_Tp>& __rhs)
-    -> __optional_ne_t<_Up, _Tp>
+    operator!= [[nodiscard]] (const _Tp& __lhs, const optional<_Up>& __rhs)
+    -> __optional_ne_t<_Tp, _Up>
     { return !__rhs || __lhs != *__rhs; }
 
   template<typename _Tp, typename _Up>
@@ -1629,10 +1629,10 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { return !__lhs || *__lhs < __rhs; }
 
   template<typename _Tp, typename _Up>
-    _REQUIRES_NOT_OPTIONAL(_Up)
+    _REQUIRES_NOT_OPTIONAL(_Tp)
     constexpr auto
-    operator< [[nodiscard]] (const _Up& __lhs, const optional<_Tp>& __rhs)
-    -> __optional_lt_t<_Up, _Tp>
+    operator< [[nodiscard]] (const _Tp& __lhs, const optional<_Up>& __rhs)
+    -> __optional_lt_t<_Tp, _Up>
     { return __rhs && __lhs < *__rhs; }
 
   template<typename _Tp, typename _Up>
@@ -1643,10 +1643,10 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { return __lhs && *__lhs > __rhs; }
 
   template<typename _Tp, typename _Up>
-    _REQUIRES_NOT_OPTIONAL(_Up)
+    _REQUIRES_NOT_OPTIONAL(_Tp)
     constexpr auto
-    operator> [[nodiscard]] (const _Up& __lhs, const optional<_Tp>& __rhs)
-    -> __optional_gt_t<_Up, _Tp>
+    operator> [[nodiscard]] (const _Tp& __lhs, const optional<_Up>& __rhs)
+    -> __optional_gt_t<_Tp, _Up>
     { return !__rhs || __lhs > *__rhs; }
 
   template<typename _Tp, typename _Up>
@@ -1657,10 +1657,10 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { return !__lhs || *__lhs <= __rhs; }
 
   template<typename _Tp, typename _Up>
-    _REQUIRES_NOT_OPTIONAL(_Up)
+    _REQUIRES_NOT_OPTIONAL(_Tp)
     constexpr auto
-    operator<= [[nodiscard]] (const _Up& __lhs, const optional<_Tp>& __rhs)
-    -> __optional_le_t<_Up, _Tp>
+    operator<= [[nodiscard]] (const _Tp& __lhs, const optional<_Up>& __rhs)
+    -> __optional_le_t<_Tp, _Up>
     { return __rhs && __lhs <= *__rhs; }
 
   template<typename _Tp, typename _Up>
@@ -1671,10 +1671,10 @@  _GLIBCXX_BEGIN_NAMESPACE_VERSION
     { return __lhs && *__lhs >= __rhs; }
 
   template<typename _Tp, typename _Up>
-    _REQUIRES_NOT_OPTIONAL(_Up)
+    _REQUIRES_NOT_OPTIONAL(_Tp)
     constexpr auto
-    operator>= [[nodiscard]] (const _Up& __lhs, const optional<_Tp>& __rhs)
-    -> __optional_ge_t<_Up, _Tp>
+    operator>= [[nodiscard]] (const _Tp& __lhs, const optional<_Up>& __rhs)
+    -> __optional_ge_t<_Tp, _Up>
     { return !__rhs || __lhs >= *__rhs; }
 
 #ifdef __cpp_lib_three_way_comparison