| Message ID | 20240514082328.833282-1-poulhies@adacore.com |
|---|---|
| State | New |
| Headers | show |
| Series | [COMMITTED] ada: Better error message for bad general case statements | expand |
diff --git a/gcc/ada/sem_ch5.adb b/gcc/ada/sem_ch5.adb index 2677a2c5a1c..65370ebfe7e 100644 --- a/gcc/ada/sem_ch5.adb +++ b/gcc/ada/sem_ch5.adb @@ -1497,6 +1497,15 @@ package body Sem_Ch5 is Resolve (Exp, Etype (Exp)); Exp_Type := Etype (Exp); Is_General_Case_Statement := True; + if not (Is_Record_Type (Exp_Type) or Is_Array_Type (Exp_Type)) then + Error_Msg_N + ("selecting expression of general case statement " & + "must be a record or an array", + Exp); + + -- Avoid cascading errors + return; + end if; else Analyze_And_Resolve (Exp, Any_Discrete); Exp_Type := Etype (Exp);
From: Steve Baird <baird@adacore.com> If -gnatX0 is specified, we allow case statements with a selector expression of a record or array type, but not of a private type. If the selector expression is of a private type then we should generate an appropriate error message instead of a bugbox. gcc/ada/ * sem_ch5.adb (Analyze_Case_Statement): Emit a message and return early in the case where general case statements are allowed but the selector expression is of a private type. This is done to avoid a bugbox. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_ch5.adb | 9 +++++++++ 1 file changed, 9 insertions(+)