From patchwork Mon May 13 12:55:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1934720 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=yV46/ZG+; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=TXsT8x4w; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ik0cBOCr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wa/1uS4M; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VdKGZ2SBYz1ymg for ; Mon, 13 May 2024 22:55:34 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2066A386F828 for ; Mon, 13 May 2024 12:55:32 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 1F98E3858432 for ; Mon, 13 May 2024 12:55:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F98E3858432 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F98E3858432 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715604912; cv=none; b=ihmYIDLaJnoPA/wmFVgVoHVjpdBEsKE/K7aZMQt1p7GdFHp3j2ftjcepzjwBPzr8a18rxSPwEcnKGHEo4CHrw2LIViS6UtPXlPsau45EfxbMGAdNr8Yso3udGanEzk01EXiVMJ28j6cfLpRbGA84mDLb8Dvzzkj/VAckj5eoRW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715604912; c=relaxed/simple; bh=USTy9NAUOlYiM5i1/4GQViZZj5qcElrqPAsau7wNKxY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=TsrmTxq/jTDkXyz1Ing0BDlgzAVCgeFgK0nXEYE7wZRwPl7X2PIQTSCV3Fck5jiuXsUgTGxRHZbIYxPKycqm1hgyPN8Nh+c4JhPOxV516wmaP+8NP7f7V/nREBe6N7ZkqJBQw3VhXGTMfJBRZOzYDWXaUQkHYEhSk1I+BaQV+pI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from murzim.nue2.suse.org (unknown [10.168.4.243]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EA853347AF for ; Mon, 13 May 2024 12:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715604906; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=u8N94NmFApFbmQThkCg6DtD8ntNKmMTiH4kVL8DS3bI=; b=yV46/ZG+vQfLiZOysNAufEupDDsAzvnvu/5sIbLyS/SLIQXBDryYYO6M0vJERIUTVSt8PL 6KvV6QIfa39pNvp3l8/yBEZToWON+aafbTjS3+297/GfmE6x1+6FFfASQcCnvxPRMQ6jUE vobUjNQZ4o27piEGs1IV1HVeObFVUO4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715604906; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=u8N94NmFApFbmQThkCg6DtD8ntNKmMTiH4kVL8DS3bI=; b=TXsT8x4wG08fquPxcRPfIG5eYsP/pl+BjLYPBJpGmE5w7fLJn6uNSiBMhed/r9mRu4sCER IKfNZSiCgfHIbWCQ== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1715604905; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=u8N94NmFApFbmQThkCg6DtD8ntNKmMTiH4kVL8DS3bI=; b=ik0cBOCrEQDKeV4KY5umGQe+CAzVlE2VNvJNPj/LVCpMIxH/GcL3c4Znj7X3cIRP+n0Dga dvpJDxnLYXtTkPj7MGPiTmMJU5NfB92vGv7PdqwxICJokkijfZRxOTiTeNa6Yg2fNRGcG2 Od7U3rBhxigqfWK1BstMay6XuJ61EDk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1715604905; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=u8N94NmFApFbmQThkCg6DtD8ntNKmMTiH4kVL8DS3bI=; b=wa/1uS4MMU1JWpTofJG444YZRHSnR+ZOph7ObR57v9N6EpUsvKEwXsQZnFRJPEU6yzQlGz 0gAOuR/dylgn3rDw== Date: Mon, 13 May 2024 14:55:05 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] PR60276 fix for single-lane SLP MIME-Version: 1.0 X-Spam-Score: -0.31 X-Spam-Level: X-Spamd-Result: default: False [-0.31 / 50.00]; MISSING_MID(2.50)[]; BAYES_HAM(-1.60)[92.46%]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.11)[-0.537]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_ZERO(0.00)[0]; ARC_NA(0.00)[]; MISSING_XM_UA(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[] X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Message-Id: <20240513125532.2066A386F828@sourceware.org> When enabling single-lane SLP and not splitting groups the fix for PR60276 is no longer effective since it for unknown reason exempted pure SLP. The following removes this exemption, making gcc.dg/vect/pr60276.c PASS even with --param vect-single-lane-slp=1 Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/60276 * tree-vect-stmts.cc (vectorizable_load): Do not exempt pure_slp grouped loads from the STMT_VINFO_MIN_NEG_DIST restriction. --- gcc/tree-vect-stmts.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 21e8fe98e44..b8a71605f1b 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -9995,8 +9995,7 @@ vectorizable_load (vec_info *vinfo, /* Invalidate assumptions made by dependence analysis when vectorization on the unrolled body effectively re-orders stmts. */ - if (!PURE_SLP_STMT (stmt_info) - && STMT_VINFO_MIN_NEG_DIST (stmt_info) != 0 + if (STMT_VINFO_MIN_NEG_DIST (stmt_info) != 0 && maybe_gt (LOOP_VINFO_VECT_FACTOR (loop_vinfo), STMT_VINFO_MIN_NEG_DIST (stmt_info))) {