From patchwork Sun Feb 25 16:01:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1903947 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=jKAUMvYo; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TjT5W3hCSz23d2 for ; Mon, 26 Feb 2024 03:01:51 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A172338582A6 for ; Sun, 25 Feb 2024 16:01:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id CF9343858296 for ; Sun, 25 Feb 2024 16:01:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF9343858296 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF9343858296 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708876888; cv=none; b=Rf/676apWRYm8GnL8Va9duvkGWHraD4B91dbuSOC4+CkK4pTHiiH/fpLYF+mFqfa5VZ4ynT8Vu/p9kxJpXW5QOS7y726kYc4IZmfLAvS+r/FN7cdHXn/07xf3fTVLNDz2pI/t9pmK0u5Abfyrrrc9l6XoS1AVyWqobqVHHISKmg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708876888; c=relaxed/simple; bh=cegYQ+jO4Nb7R6i6zP9TCJsZi9cME5sCOlzFK88sduM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QJHW0xTP5QcXgqFWAvtSEmm5J2wzNmu+lQOSkovZMEuScfTuyKn/bOEouKELbvJmdJfxiepsqabWyvetpwcOplSGApVVK9U82DQpb5pjX9cvN3/Q65ikhe2Uic5ASQyCsgq1EKgJilLh8O25HtvgFxORFIe/4owzZAkX5ZYv0Y8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1dba94f9201so16357395ad.0 for ; Sun, 25 Feb 2024 08:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708876882; x=1709481682; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZB6U1gIKKGtJKP/tsEFiKjOKU5tZLIYUL0s5MmmIO18=; b=jKAUMvYocfXkXQCzg2k3c954yYzBQgsYi52gvslLhFrvkUXFtpWds4uPn9hH+zQ/DV HLbEzJYwlcjarnvqAkQUoX6LBUi6Sl1sMoloOd6QeT2fmwfA6nyMsB2Zm4d6AD6dCHcy MYaGFKOOejun4rN0DVyk4foLkk3Riyum3NTDNByQSjw1Bj/GPa+n/Qxk8zAX8ih3teCT a3u6GWtRbi09G1ybKRQRWCftMl171b1uSpQgWIrBXS8FaZ/kKYPLBSjxXTRT7Gg79fW8 Z3RY2Jer/v9zCXPXPkEmku79N4QpNahotiOfiPBhT8Xx4bdWehaVAKcDXvuYUEVk+WaO D/nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708876882; x=1709481682; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZB6U1gIKKGtJKP/tsEFiKjOKU5tZLIYUL0s5MmmIO18=; b=ot6fj4EBKXU1vgcZhsWw6ul48KD0n4b5clL54AvzHHLKJmxCu1SZTbspZwdTSy6HmP Oh5KiZyCWwPlG1a1iRU0nj4k6AhVu3x4eoRFk+BxisiDBi6L+4FFlDtP6cK3kgFmzPhb D5bBfCChuExG7ALdwJCeke1yGx39gaOC6LaRnrj9Ci7ilEejeQijKvlbg0ev0N6gPkVa ViXgj6jfMuip4q+nPIeJpqTkOxTH+XiWPJV/95vWYjyf3SDYioujXWxVpN1feK9j9NMD NgdNQ7qkCEnlioMNi3XwOff33OA+fMmF+rG8fWtosDYfBGDg61+RcXiWF0YK4nP4iWa5 JHyg== X-Gm-Message-State: AOJu0YyZBFQBdLvsEEOMpdcPw6tLfXp6JAVOExkyUmqA5REvC7u0CH/w et8JHDNG8ufhQyuI8GxfosZ4dTpCDE0XpDyxBpv0TEpOtOvCB1RGwQb4QrEZ X-Google-Smtp-Source: AGHT+IEYifTeGeM/L183o4qCL0X7FZeSqP9xr6Jt11841XjWw+hdClYF9rNBRrgoHVeTYST3hXU+XA== X-Received: by 2002:a17:903:2784:b0:1db:d184:c45a with SMTP id jw4-20020a170903278400b001dbd184c45amr4699723plb.67.1708876882530; Sun, 25 Feb 2024 08:01:22 -0800 (PST) Received: from gnu-cfl-3.localdomain ([172.58.89.72]) by smtp.gmail.com with ESMTPSA id mq3-20020a170902fd4300b001d949e663d5sm2393767plb.31.2024.02.25.08.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 08:01:21 -0800 (PST) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 635FC74005D; Sun, 25 Feb 2024 08:01:20 -0800 (PST) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: ubizjak@gmail.com, hongtao.liu@intel.com Subject: [PATCH] x86: Check interrupt instead of noreturn attribute Date: Sun, 25 Feb 2024 08:01:20 -0800 Message-ID: <20240225160120.3328955-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.43.2 MIME-Version: 1.0 X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org ix86_set_func_type checks noreturn attribute to avoid incompatible attribute error in LTO1 on interrupt functions. Since TREE_THIS_VOLATILE is set also for _Noreturn without noreturn attribute, check interrupt attribute for interrupt functions instead. gcc/ PR target/114097 * config/i386/i386-options.cc (ix86_set_func_type): Check interrupt instead of noreturn attribute. gcc/testsuite/ PR target/114097 * gcc.target/i386/pr114097-1.c: New test. --- gcc/config/i386/i386-options.cc | 3 ++- gcc/testsuite/gcc.target/i386/pr114097-1.c | 26 ++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr114097-1.c diff --git a/gcc/config/i386/i386-options.cc b/gcc/config/i386/i386-options.cc index 93a01146db7..82fe0d228cd 100644 --- a/gcc/config/i386/i386-options.cc +++ b/gcc/config/i386/i386-options.cc @@ -3395,7 +3395,8 @@ ix86_set_func_type (tree fndecl) incompatible attribute error in LTO1. */ bool has_no_callee_saved_registers = ((TREE_THIS_VOLATILE (fndecl) - && lookup_attribute ("noreturn", DECL_ATTRIBUTES (fndecl)) + && !lookup_attribute ("interrupt", + TYPE_ATTRIBUTES (TREE_TYPE (fndecl))) && optimize && !optimize_debug && (TREE_NOTHROW (fndecl) || !flag_exceptions)) diff --git a/gcc/testsuite/gcc.target/i386/pr114097-1.c b/gcc/testsuite/gcc.target/i386/pr114097-1.c new file mode 100644 index 00000000000..b14c7b6214d --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr114097-1.c @@ -0,0 +1,26 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -mtune-ctrl=^prologue_using_move,^epilogue_using_move -fomit-frame-pointer" } */ + +#define ARRAY_SIZE 256 + +extern int array[ARRAY_SIZE][ARRAY_SIZE][ARRAY_SIZE]; +extern int value (int, int, int) +#ifndef __x86_64__ +__attribute__ ((regparm(3))) +#endif +; + +void +_Noreturn +no_return_to_caller (void) +{ + unsigned i, j, k; + for (i = ARRAY_SIZE; i > 0; --i) + for (j = ARRAY_SIZE; j > 0; --j) + for (k = ARRAY_SIZE; k > 0; --k) + array[i - 1][j - 1][k - 1] = value (i, j, k); + while (1); +} + +/* { dg-final { scan-assembler-not "push" } } */ +/* { dg-final { scan-assembler-not "pop" } } */