From patchwork Thu Feb 15 01:11:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edwin Lu X-Patchwork-Id: 1899118 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=E/ijfmfq; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TZxqn34ZLz23j8 for ; Thu, 15 Feb 2024 12:12:21 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5EC3F3861034 for ; Thu, 15 Feb 2024 01:12:19 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 4E1233861819 for ; Thu, 15 Feb 2024 01:11:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E1233861819 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4E1233861819 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707959500; cv=none; b=co9DByBQffGqEZnG+zVFw+4aq+nStcB+h2H6gF+bw89T3x4uwe4QoxDemncRJt4GU5YMnNWTAZl0xLm4iO3Ylg1OaCCSscfiW8Jklwy85AdF5VKizkmMJHtzVJFCYYbCemmRKOqOn7HVT+rl4/VlN7QrM+/EwUgQAqhuhaFnBOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707959500; c=relaxed/simple; bh=SvfFNBIzCUaTC5bR9qJkcIosvRV14WdZnmKC3DC6hOc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=GbCj/WMEAzzwb3uvte4UmRB82wnUellkPUbB6GzoAC/U9bTSVf4IhL16OHax2E0WVEoJdB2p0BKVrR690WmhUYWmIHAF71U1uVFc+qqT7PS7+jLejy34vYU7HIeiChG3b7NEINRJPl5Alqzj3czNNvzAP05oe+bT2nvOLa2rr2I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6e0cc8d740cso321840b3a.3 for ; Wed, 14 Feb 2024 17:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1707959495; x=1708564295; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s3SE4cSpQaJ6Srb682h3XUe7MFTVrgqyUDT+XVbq+KA=; b=E/ijfmfqKBV6k+37lwG2iyobp2542l9oDj4GNtEJBDKTnfEiz0JZAYZ5Bo6qX2wNUb W2mUFXTWYXIYX4RrXjN70qMsCEjGbygBCk4F3S9kQen9x5aL3jtKt++KHEVEQiDBKJjm 4JomOE7zySww3W6KhSQbvWSbJ8ftXRNlmWHmnhvBb5c/NH05ilvuZxCK+NzVc43bqDEH dlNWo/sT/wgeQfLPoqDdTu/5UR1FV71ZFqCteU4M3sFju99K9ffdxVmekTQPwPYMViYt RXNnqKVFxvke6pKO+8xETGwUeIfrwJqaJAP2y/F9KUX/+uyFTUG+uqJ2Dtdqid+KOupA dJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707959495; x=1708564295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s3SE4cSpQaJ6Srb682h3XUe7MFTVrgqyUDT+XVbq+KA=; b=JMDRp65PAxOksPaciYkWzgQBhrru0ciDvYeCC+9P1ZOcia+ctLQiRu1jSpfx6AQjsw BG6Vr62PkDQ4R7Nqp2h7JSgc+1oG7bgMEXPbB+wWwbIyhdKJ95YMKIWP6EkpT4jZw5Um FvePRjR/Ey6+HNIZqxWB/9++hmu+9FGZhyy2uZ/iVEYdOAVCXGBTUB+zGby1wV6qqKZG xgjtUhrDygHUBsXrEUFpwyJzRTfyo23ue4yl529mhVZdsjnw2Z1ARq4L5MmCTJcxm5cN 1euvVA+A1AtPGVPT6OJXsLsiKpTvfaMV/y9c2dO0zGUYk2BULWikv4oyV50aUooDWNHM FkZg== X-Gm-Message-State: AOJu0Yw3bdvrfYY0XS6p/oPej10JoO1BCN7DCirN+6E1W5M0CpbWIicO Y7g1d1NOHhCfikoJs2Lq4QacyCi49qHES/u7wJ/EPH9pKbJLzCL+qG9Lwy5PokNRCvhuV9wD9mp j X-Google-Smtp-Source: AGHT+IFBw/UB1WNG1sQtcVm2adFEL8bdS+m564DCSvADtPAlVGP32lZCOK+dCd9t5b5JXzhsgrltgw== X-Received: by 2002:a05:6a21:3a86:b0:19a:4935:458 with SMTP id zv6-20020a056a213a8600b0019a49350458mr471296pzb.35.1707959495102; Wed, 14 Feb 2024 17:11:35 -0800 (PST) Received: from ewlu.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 21-20020a170902c25500b001d8f12b0009sm60611plg.293.2024.02.14.17.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 17:11:34 -0800 (PST) From: Edwin Lu To: gcc-patches@gcc.gnu.org Cc: gnu-toolchain@rivosinc.com, Edwin Lu Subject: [PATCH V4 5/5] RISC-V: Enable assert for insn_has_dfa_reservation Date: Wed, 14 Feb 2024 17:11:21 -0800 Message-Id: <20240215011121.2434218-6-ewlu@rivosinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240215011121.2434218-1-ewlu@rivosinc.com> References: <20240215011121.2434218-1-ewlu@rivosinc.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Enables assert that every typed instruction is associated with a dfa reservation gcc/ChangeLog: * config/riscv/riscv.cc (riscv_sched_variable_issue): enable assert Signed-off-by: Edwin Lu --- V2: - No changes V3: - Remove debug statements V4: - no changes --- gcc/config/riscv/riscv.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 4100abc9dd1..5e984ee2a55 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -8269,9 +8269,7 @@ riscv_sched_variable_issue (FILE *, int, rtx_insn *insn, int more) /* If we ever encounter an insn without an insn reservation, trip an assert so we can find and fix this problem. */ -#if 0 gcc_assert (insn_has_dfa_reservation_p (insn)); -#endif return more - 1; }