From patchwork Thu Feb 1 15:28:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 1893995 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Iu7ZsoAv; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TQjX34G4pz1yQ0 for ; Fri, 2 Feb 2024 02:30:11 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D249385C301 for ; Thu, 1 Feb 2024 15:30:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 578ED3857C46 for ; Thu, 1 Feb 2024 15:29:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 578ED3857C46 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 578ED3857C46 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706801364; cv=none; b=wd4XEH4uWuyNu10tnj0nIlc2O4WTJf9YQuZ4AoKRMjYyMRBGw1sgUd6U8//Dgl4X2mvj4UKLtL0Ioi+71EolPwjgGDi6IeV8jTejLKStCzFBBNI7eLEiIbs9PS7yM6zhIpLJbCbBz4kHJpwTf4EbSyqP/J+DwjhCTFeMKXc0bv8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706801364; c=relaxed/simple; bh=IwYpfLajjt9UyE2AxN1KeKFWh7uDSQJZAs3JMJMJ7ZQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JKvP7vqABtLaOvt6yGX7DoGKl0Zve1fBPDcbomaXF+jW4oOaY6C1ZhnAl3kC4vZM64PlaLpRcxCFCUb8QGBgKVpV/+XsnV2gKifz0RuIcmRYhKCXW9V6CxWRVRltbcC1Z/kIB9joXkhvEEp8rCVyJrc/PVJG/YBYSe+UdUZQ9Yo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706801352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RorIYInUk/fE2P6W+m9lHcKCwTiE7C2LyjTZrnROIK4=; b=Iu7ZsoAv6rkniffsU/Nuj4jhXUrVy5m3EBWgpFsQMnzR/ps8pnOIH1w3DMa9fki9+4ENib dJvLCJXQ9PUgW+FwwH+KVrX3WoE6/fQnJLh3gBzocc+8+0Ec8C8jBHmR1DEPjofj0xfsAb +zfB8HrZbf7IRcYxgkf7swQ+aydDopY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-tFat2-GLNC62fmWmU3vGEw-1; Thu, 01 Feb 2024 10:29:10 -0500 X-MC-Unique: tFat2-GLNC62fmWmU3vGEw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3903738062A4; Thu, 1 Feb 2024 15:29:10 +0000 (UTC) Received: from localhost (unknown [10.42.28.13]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0658BC2590D; Thu, 1 Feb 2024 15:29:09 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Update expected error for debug/constexpr*_neg.cc tests Date: Thu, 1 Feb 2024 15:28:52 +0000 Message-ID: <20240201152905.2137594-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Tested x86_64-linux. Pushed to trunk. -- >8 -- We no longer hit a __builtin_unreachable() in these tests, so we need to update the dg-error patterns to match _Error_formatter::_M_error(). We can also remove some dg-prune-output directives matching notes saying "in 'constexpr' expansion" because that's done globally in prune.exp. libstdc++-v3/ChangeLog: * testsuite/25_algorithms/copy/debug/constexpr_neg.cc: Adjust dg-error pattern. * testsuite/25_algorithms/copy_backward/debug/constexpr_neg.cc: Likewise. * testsuite/25_algorithms/equal/debug/constexpr_neg.cc: Likewise. * testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_neg.cc: Likewise. * testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_pred_neg.cc: Likewise. * testsuite/25_algorithms/lower_bound/debug/constexpr_valid_range_neg.cc: Likewise. * testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_neg.cc: Likewise. * testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_pred_neg.cc: Likewise. * testsuite/25_algorithms/upper_bound/debug/constexpr_valid_range_neg.cc: Likewise. --- .../testsuite/25_algorithms/copy/debug/constexpr_neg.cc | 2 +- .../25_algorithms/copy_backward/debug/constexpr_neg.cc | 3 +-- .../testsuite/25_algorithms/equal/debug/constexpr_neg.cc | 2 +- .../lower_bound/debug/constexpr_partitioned_neg.cc | 2 +- .../lower_bound/debug/constexpr_partitioned_pred_neg.cc | 3 +-- .../lower_bound/debug/constexpr_valid_range_neg.cc | 3 +-- .../upper_bound/debug/constexpr_partitioned_neg.cc | 3 +-- .../upper_bound/debug/constexpr_partitioned_pred_neg.cc | 3 +-- .../upper_bound/debug/constexpr_valid_range_neg.cc | 3 +-- 9 files changed, 9 insertions(+), 15 deletions(-) diff --git a/libstdc++-v3/testsuite/25_algorithms/copy/debug/constexpr_neg.cc b/libstdc++-v3/testsuite/25_algorithms/copy/debug/constexpr_neg.cc index 2922d1ab1f9..6ae37b87ac5 100644 --- a/libstdc++-v3/testsuite/25_algorithms/copy/debug/constexpr_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/copy/debug/constexpr_neg.cc @@ -33,7 +33,7 @@ test1() } static_assert(test1()); // { dg-error "non-constant condition" } -// { dg-error "builtin_unreachable" "" { target *-*-* } 0 } +// { dg-error "_Error_formatter::_M_error()" "" { target *-*-* } 0 } constexpr bool test2() diff --git a/libstdc++-v3/testsuite/25_algorithms/copy_backward/debug/constexpr_neg.cc b/libstdc++-v3/testsuite/25_algorithms/copy_backward/debug/constexpr_neg.cc index 4b55b835ab4..52259aa50aa 100644 --- a/libstdc++-v3/testsuite/25_algorithms/copy_backward/debug/constexpr_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/copy_backward/debug/constexpr_neg.cc @@ -35,5 +35,4 @@ test() static_assert(test()); // { dg-error "non-constant condition" } -// { dg-prune-output "in 'constexpr' expansion" } -// { dg-prune-output "builtin_unreachable" } +// { dg-prune-output "_Error_formatter::_M_error()" } diff --git a/libstdc++-v3/testsuite/25_algorithms/equal/debug/constexpr_neg.cc b/libstdc++-v3/testsuite/25_algorithms/equal/debug/constexpr_neg.cc index 8fb225ecc85..82ec49c6f40 100644 --- a/libstdc++-v3/testsuite/25_algorithms/equal/debug/constexpr_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/equal/debug/constexpr_neg.cc @@ -32,7 +32,7 @@ test01() } static_assert(test01()); // { dg-error "non-constant condition" } -// { dg-error "builtin_unreachable" "" { target *-*-* } 0 } +// { dg-error "_Error_formatter::_M_error()" "" { target *-*-* } 0 } constexpr bool test02() diff --git a/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_neg.cc b/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_neg.cc index 184ae22ae24..8c2819d0554 100644 --- a/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_neg.cc @@ -43,5 +43,5 @@ test() static_assert(test()); // { dg-error "" } -// { dg-prune-output "builtin_unreachable" } +// { dg-prune-output "_Error_formatter::_M_error()" } // { dg-prune-output "in 'constexpr'" } diff --git a/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_pred_neg.cc b/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_pred_neg.cc index f7b2b7231d9..ab27cb17fb1 100644 --- a/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_pred_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_partitioned_pred_neg.cc @@ -33,5 +33,4 @@ test() static_assert(test()); // { dg-error "" } -// { dg-prune-output "builtin_unreachable" } -// { dg-prune-output "in 'constexpr'" } +// { dg-prune-output "_Error_formatter::_M_error()" } diff --git a/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_valid_range_neg.cc b/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_valid_range_neg.cc index 6996950d686..9fd3bcc070d 100644 --- a/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_valid_range_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/lower_bound/debug/constexpr_valid_range_neg.cc @@ -46,6 +46,5 @@ test2() static_assert(test2()); // { dg-error "" } -// { dg-prune-output "builtin_unreachable" } -// { dg-prune-output "in 'constexpr'" } +// { dg-prune-output "_Error_formatter::_M_error()" } diff --git a/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_neg.cc b/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_neg.cc index b4e56df9174..c1ee761f51e 100644 --- a/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_neg.cc @@ -43,5 +43,4 @@ test() static_assert(test()); // { dg-error "" } -// { dg-prune-output "builtin_unreachable" } -// { dg-prune-output "in 'constexpr'" } +// { dg-prune-output "_Error_formatter::_M_error()" } diff --git a/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_pred_neg.cc b/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_pred_neg.cc index 1ffeb326bfc..85fcde40b37 100644 --- a/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_pred_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_partitioned_pred_neg.cc @@ -33,5 +33,4 @@ test() static_assert(test()); // { dg-error "" } -// { dg-prune-output "builtin_unreachable" } -// { dg-prune-output "in 'constexpr'" } +// { dg-prune-output "_Error_formatter::_M_error()" } diff --git a/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_valid_range_neg.cc b/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_valid_range_neg.cc index 5b0e651d077..446073c314b 100644 --- a/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_valid_range_neg.cc +++ b/libstdc++-v3/testsuite/25_algorithms/upper_bound/debug/constexpr_valid_range_neg.cc @@ -46,5 +46,4 @@ test2() static_assert(test2()); // { dg-error "" } -// { dg-prune-output "builtin_unreachable" } -// { dg-prune-output "in 'constexpr'" } +// { dg-prune-output "_Error_formatter::_M_error()" }