From patchwork Thu Oct 5 11:43:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Zissulescu Ianculescu X-Patchwork-Id: 1843860 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=QMQjNaee; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4S1V8z1HK5z1yng for ; Thu, 5 Oct 2023 22:44:51 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0EB6338323D9 for ; Thu, 5 Oct 2023 11:44:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id CAF73385B513 for ; Thu, 5 Oct 2023 11:43:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CAF73385B513 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-32167a4adaaso823116f8f.1 for ; Thu, 05 Oct 2023 04:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696506230; x=1697111030; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wM26u+83rDCFdwQcrxtiuLNgIz3WsZYNZuklZ1PUYEU=; b=QMQjNaeeJDviVMU/Oty1undQ37b2oL8jsmeavdUOjJczQEfdZFRjfoKe81brutbqkO /WeHNp7l2q3Y2zz+jdkeZiFMhG0PmLEyIEfwzZGm4ceiYm0YVRta3g24OMB2KVAxHZ2T ceTyJwGlcWeWF7oPyXAnMBvtyfX0tSzd1/KV/l4LrWyzv+OFUDN0refzycDw+Jy9BQkM y4gQW8ZWpR/4YFk5m57rSkpcAhILNsNf3Z2imGSd8lJZCFU3lefXMB6CJu5sSLMNwsPB tvTKeg2Fqt17Lq9wK25h5zFsAC2sn0aAZanV3NJ4Dy6Oih5n/7EriXRWpQoHEJEyGX4r y4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696506230; x=1697111030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wM26u+83rDCFdwQcrxtiuLNgIz3WsZYNZuklZ1PUYEU=; b=SEXy6OezxupxGkQ6C5FD9bEiGyC7hfmvcBBrEcbc8k18j4pH/upbWTHQ0nbr/sI/Tl 2TWpDjnULa3HXzIcIvm0lkUuWyWqCRZEHTYqxpe5OQ9hQIswIKvPiUpVLD/9gbXFj71U jtNaixKbslSen1jdnZ9ghKkCB5QRB1Uw4UWWK5MINoFCSK1KdLv8BvRmBx1X8TvEdN6d Wtxsh8uwFBTjnnh4m/BUD95MVFmPTnc6mu70IHbDhR9DQisoQXyGaaQ56mKKUEvttsd7 W2DuE98o8rT15iZrG0943gn6HogngoEGOYDAZGjNrexUY5iHDgZTxFiFRuqNLotUieSc s3/Q== X-Gm-Message-State: AOJu0YyQHQIKbuSrsaMK+k6uI9BTHaug+2ubexcdKzVqBooJ8PYg2BOY 3eJmvpuVsGMUt7wyTyiA3zEZWKAc4hQ= X-Google-Smtp-Source: AGHT+IGhgm9Nj6uk2qsz6o5IFGGZqrE9srErtDIHe+auKX1dfwJNwbmmgg8fHGbXGImDmjnrMkzu0Q== X-Received: by 2002:a05:6000:1b07:b0:321:6450:62ea with SMTP id f7-20020a0560001b0700b00321645062eamr4783817wrz.36.1696506230179; Thu, 05 Oct 2023 04:43:50 -0700 (PDT) Received: from fatty.nomansland ([193.187.151.25]) by smtp.gmail.com with ESMTPSA id f22-20020a5d58f6000000b0031423a8f4f7sm1605821wrd.56.2023.10.05.04.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Oct 2023 04:43:49 -0700 (PDT) From: Claudiu Zissulescu To: gcc-patches@gcc.gnu.org Cc: fbedard@synopsys.com Subject: [committed 3/5] arc: Remove '^' print punct character Date: Thu, 5 Oct 2023 14:43:43 +0300 Message-Id: <20231005114345.1707504-3-claziss@gmail.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20231005114345.1707504-1-claziss@gmail.com> References: <20231005114345.1707504-1-claziss@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The '^' was used to print '@' character in the ouput assembly. This is not anylonger required by the ARC binutils. Remove it. gcc/ * config/arc/arc.cc (arc_init): Remove '^' punct char. (arc_print_operand): Remove related code. * config/arc/arc.md: Update patterns which uses '%&'. gcc/testsuite/ * gcc.target/arc/loop-3.c: Update test. Signed-off-by: Claudiu Zissulescu --- gcc/config/arc/arc.cc | 9 --------- gcc/config/arc/arc.md | 18 +++++++++--------- gcc/testsuite/gcc.target/arc/loop-3.c | 2 +- 3 files changed, 10 insertions(+), 19 deletions(-) diff --git a/gcc/config/arc/arc.cc b/gcc/config/arc/arc.cc index 5e597d1bfeb..a1428eb41c3 100644 --- a/gcc/config/arc/arc.cc +++ b/gcc/config/arc/arc.cc @@ -1130,7 +1130,6 @@ arc_init (void) arc_punct_chars['*'] = 1; arc_punct_chars['?'] = 1; arc_punct_chars['!'] = 1; - arc_punct_chars['^'] = 1; arc_punct_chars['+'] = 1; arc_punct_chars['_'] = 1; } @@ -4529,7 +4528,6 @@ static int output_sdata = 0; 'V': cache bypass indicator for volatile 'P' 'F' - '^' 'O': Operator 'o': original symbol - no @ prepending. */ @@ -4953,14 +4951,7 @@ arc_print_operand (FILE *file, rtx x, int code) case 'F': fputs (reg_names[REGNO (x)]+1, file); return; - case '^': - /* This punctuation character is needed because label references are - printed in the output template using %l. This is a front end - character, and when we want to emit a '@' before it, we have to use - this '^'. */ - fputc('@',file); - return; case 'O': /* Output an operator. */ switch (GET_CODE (x)) diff --git a/gcc/config/arc/arc.md b/gcc/config/arc/arc.md index 2a3ff05b66b..945cc4042d1 100644 --- a/gcc/config/arc/arc.md +++ b/gcc/config/arc/arc.md @@ -3934,9 +3934,9 @@ (define_insn "*branch_insn" { arc_ccfsm_record_condition (operands[1], false, insn, 0); if (get_attr_length (insn) == 2) - return \"b%d1%? %^%l0\"; + return \"b%d1%?\\t%l0\"; else - return \"b%d1%# %^%l0\"; + return \"b%d1%#\\t%l0\"; } }" [(set_attr "type" "branch") @@ -3984,9 +3984,9 @@ (define_insn "*rev_branch_insn" { arc_ccfsm_record_condition (operands[1], true, insn, 0); if (get_attr_length (insn) == 2) - return \"b%D1%? %^%l0\"; + return \"b%D1%?\\t%l0\"; else - return \"b%D1%# %^%l0\"; + return \"b%D1%#\\t%l0\"; } }" [(set_attr "type" "branch") @@ -4026,7 +4026,7 @@ (define_expand "jump" (define_insn "jump_i" [(set (pc) (label_ref (match_operand 0 "" "")))] "!TARGET_LONG_CALLS_SET || !CROSSING_JUMP_P (insn)" - "b%!%* %^%l0" + "b%!%*\\t%l0" [(set_attr "type" "uncond_branch") (set (attr "iscompact") (if_then_else (match_test "get_attr_length (insn) == 2") @@ -4990,13 +4990,13 @@ (define_insn "cbranchsi4_scratch" "* switch (get_attr_length (insn)) { - case 2: return \"br%d0%? %1, %2, %^%l3\"; - case 4: return \"br%d0%* %1, %B2, %^%l3\"; + case 2: return \"br%d0%?\\t%1,%2,%l3\"; + case 4: return \"br%d0%*\\t%1,%B2,%l3\"; case 8: if (!brcc_nolimm_operator (operands[0], VOIDmode)) - return \"br%d0%* %1, %B2, %^%l3\"; + return \"br%d0%*\\t%1,%B2,%l3\"; /* FALLTHRU */ case 6: case 10: - case 12:return \"cmp%? %1, %B2\\n\\tb%d0%* %^%l3 ;br%d0 out of range\"; + case 12:return \"cmp%? %1, %B2\\n\\tb%d0%*\\t%l3 ;br%d0 out of range\"; default: fprintf (stderr, \"unexpected length %d\\n\", get_attr_length (insn)); fflush (stderr); gcc_unreachable (); } " diff --git a/gcc/testsuite/gcc.target/arc/loop-3.c b/gcc/testsuite/gcc.target/arc/loop-3.c index 7f55e2f43fa..ae0d6110f18 100644 --- a/gcc/testsuite/gcc.target/arc/loop-3.c +++ b/gcc/testsuite/gcc.target/arc/loop-3.c @@ -23,5 +23,5 @@ void fn1(void) } } -/* { dg-final { scan-assembler "bne.*@.L2" } } */ +/* { dg-final { scan-assembler "bne.*\\.L2" } } */ /* { dg-final { scan-assembler-not "add.eq" } } */