diff mbox series

LoongArch: Fix unintentional bash-ism in r14-3665.

Message ID 20230906095747.25772-1-yangyujie@loongson.cn
State New
Headers show
Series LoongArch: Fix unintentional bash-ism in r14-3665. | expand

Commit Message

Yang Yujie Sept. 6, 2023, 9:57 a.m. UTC 
gcc/ChangeLog:

	* config.gcc: remove non-POSIX syntax "<<<".
---
 gcc/config.gcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sam James Sept. 6, 2023, 11 a.m. UTC | #1 
Yang Yujie <yangyujie@loongson.cn> writes:

> gcc/ChangeLog:
>
> 	* config.gcc: remove non-POSIX syntax "<<<".
> ---

Thanks, I was just about to report this.

>  gcc/config.gcc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index b2fe7c7ceef..6d4c8becd28 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -5189,7 +5189,7 @@ case "${target}" in
>  				if test x${parse_state} = x"abi-base"; then
>  					# Base ABI type
>  					case ${component} in
> -					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
> +					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
>  					*)
>  						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
>  						exit 1
Richard Sandiford Sept. 6, 2023, 12:19 p.m. UTC | #2 
Yang Yujie <yangyujie@loongson.cn> writes:
> gcc/ChangeLog:
>
> 	* config.gcc: remove non-POSIX syntax "<<<".

OK.  Thanks for the quick fix.

Richard.

> ---
>  gcc/config.gcc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index b2fe7c7ceef..6d4c8becd28 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -5189,7 +5189,7 @@ case "${target}" in
>  				if test x${parse_state} = x"abi-base"; then
>  					# Base ABI type
>  					case ${component} in
> -					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
> +					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
>  					*)
>  						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
>  						exit 1
Lulu Cheng Sept. 8, 2023, 9:54 a.m. UTC | #3 
Pushed to r14-3804.

在 2023/9/6 下午8:19, Richard Sandiford 写道:
> Yang Yujie <yangyujie@loongson.cn> writes:
>> gcc/ChangeLog:
>>
>> 	* config.gcc: remove non-POSIX syntax "<<<".
> OK.  Thanks for the quick fix.
>
> Richard.
>
>> ---
>>   gcc/config.gcc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/config.gcc b/gcc/config.gcc
>> index b2fe7c7ceef..6d4c8becd28 100644
>> --- a/gcc/config.gcc
>> +++ b/gcc/config.gcc
>> @@ -5189,7 +5189,7 @@ case "${target}" in
>>   				if test x${parse_state} = x"abi-base"; then
>>   					# Base ABI type
>>   					case ${component} in
>> -					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
>> +					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
>>   					*)
>>   						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
>>   						exit 1
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index b2fe7c7ceef..6d4c8becd28 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -5189,7 +5189,7 @@  case "${target}" in
 				if test x${parse_state} = x"abi-base"; then
 					# Base ABI type
 					case ${component} in
-					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(tr a-z A-Z <<< ${component}),";;
+					lp64d | lp64f | lp64s) elem_tmp="ABI_BASE_$(echo ${component} | tr a-z A-Z),";;
 					*)
 						echo "Unknown base ABI \"${component}\" in --with-multilib-list." 1>&2
 						exit 1