diff mbox series

[COMMITTED] ada: Suppress warning about Subprogram_Variant failing at run time

Message ID 20230523080747.1872885-1-poulhies@adacore.com
State New
Headers show
Series [COMMITTED] ada: Suppress warning about Subprogram_Variant failing at run time | expand

Commit Message

Marc Poulhiès May 23, 2023, 8:07 a.m. UTC
From: Piotr Trojanek <trojanek@adacore.com>

Warning about check failing at run time is likely spurious for mutually
recursive subprograms with multiple variant clauses. These will be
non-trivial to detect, so we simply suppress the warning altogether for
all subprogram variants.

gcc/ada/

	* exp_prag.adb (Expand_Pragma_Check): Suppress warning for checks of
	subprogram variants.

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/ada/exp_prag.adb | 7 +++++++
 1 file changed, 7 insertions(+)
diff mbox series

Patch

diff --git a/gcc/ada/exp_prag.adb b/gcc/ada/exp_prag.adb
index ceb27848dad..c6b3bed5425 100644
--- a/gcc/ada/exp_prag.adb
+++ b/gcc/ada/exp_prag.adb
@@ -564,6 +564,13 @@  package body Exp_Prag is
          then
             null;
 
+         --  For Subprogram_Variant suppress the warning altogether, because
+         --  for mutually recursive subprograms with multiple variant clauses
+         --  some of the clauses might have expressions that are only meant for
+         --  verification and would always fail when executed.
+
+         elsif Nam = Name_Subprogram_Variant then
+            null;
          elsif Nam = Name_Assert then
             Error_Msg_N ("?.a?assertion will fail at run time", N);
          else