Message ID | 20220523192834.3785673-4-dmalcolm@redhat.com |
---|---|
State | New |
Headers | show |
Series | Add 'final' and 'override' where missing | expand |
Ping on this patch: https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595434.html OK for trunk? Thanks Dave On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > gcc/ChangeLog: > * expr.cc: Add "final" and "override" to op_by_pieces_d vfunc > implementations as appropriate. > > Signed-off-by: David Malcolm <dmalcolm@redhat.com> > --- > gcc/expr.cc | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gcc/expr.cc b/gcc/expr.cc > index 7197996cec7..ce58728862a 100644 > --- a/gcc/expr.cc > +++ b/gcc/expr.cc > @@ -1357,8 +1357,8 @@ op_by_pieces_d::run () > class move_by_pieces_d : public op_by_pieces_d > { > insn_gen_fn m_gen_fun; > - void generate (rtx, rtx, machine_mode); > - bool prepare_mode (machine_mode, unsigned int); > + void generate (rtx, rtx, machine_mode) final override; > + bool prepare_mode (machine_mode, unsigned int) final override; > > public: > move_by_pieces_d (rtx to, rtx from, unsigned HOST_WIDE_INT len, > @@ -1453,8 +1453,8 @@ move_by_pieces (rtx to, rtx from, unsigned > HOST_WIDE_INT len, > class store_by_pieces_d : public op_by_pieces_d > { > insn_gen_fn m_gen_fun; > - void generate (rtx, rtx, machine_mode); > - bool prepare_mode (machine_mode, unsigned int); > + void generate (rtx, rtx, machine_mode) final override; > + bool prepare_mode (machine_mode, unsigned int) final override; > > public: > store_by_pieces_d (rtx to, by_pieces_constfn cfn, void *cfn_data, > @@ -1650,9 +1650,9 @@ class compare_by_pieces_d : public op_by_pieces_d > rtx m_accumulator; > int m_count, m_batch; > > - void generate (rtx, rtx, machine_mode); > - bool prepare_mode (machine_mode, unsigned int); > - void finish_mode (machine_mode); > + void generate (rtx, rtx, machine_mode) final override; > + bool prepare_mode (machine_mode, unsigned int) final override; > + void finish_mode (machine_mode) final override; > public: > compare_by_pieces_d (rtx op0, rtx op1, by_pieces_constfn op1_cfn, > void *op1_cfn_data, HOST_WIDE_INT len, int > align,
On Mon, 2022-06-13 at 14:25 -0400, David Malcolm wrote: > Ping on this patch: > https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595434.html > > OK for trunk? > > Thanks > Dave > > On Mon, 2022-05-23 at 15:28 -0400, David Malcolm wrote: > > gcc/ChangeLog: > > * expr.cc: Add "final" and "override" to op_by_pieces_d > > vfunc > > implementations as appropriate. > > > > Signed-off-by: David Malcolm <dmalcolm@redhat.com> > > --- > > gcc/expr.cc | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/gcc/expr.cc b/gcc/expr.cc > > index 7197996cec7..ce58728862a 100644 > > --- a/gcc/expr.cc > > +++ b/gcc/expr.cc > > @@ -1357,8 +1357,8 @@ op_by_pieces_d::run () > > class move_by_pieces_d : public op_by_pieces_d > > { > > insn_gen_fn m_gen_fun; > > - void generate (rtx, rtx, machine_mode); > > - bool prepare_mode (machine_mode, unsigned int); > > + void generate (rtx, rtx, machine_mode) final override; > > + bool prepare_mode (machine_mode, unsigned int) final override; > > > > public: > > move_by_pieces_d (rtx to, rtx from, unsigned HOST_WIDE_INT len, > > @@ -1453,8 +1453,8 @@ move_by_pieces (rtx to, rtx from, unsigned > > HOST_WIDE_INT len, > > class store_by_pieces_d : public op_by_pieces_d > > { > > insn_gen_fn m_gen_fun; > > - void generate (rtx, rtx, machine_mode); > > - bool prepare_mode (machine_mode, unsigned int); > > + void generate (rtx, rtx, machine_mode) final override; > > + bool prepare_mode (machine_mode, unsigned int) final override; > > > > public: > > store_by_pieces_d (rtx to, by_pieces_constfn cfn, void > > *cfn_data, > > @@ -1650,9 +1650,9 @@ class compare_by_pieces_d : public > > op_by_pieces_d > > rtx m_accumulator; > > int m_count, m_batch; > > > > - void generate (rtx, rtx, machine_mode); > > - bool prepare_mode (machine_mode, unsigned int); > > - void finish_mode (machine_mode); > > + void generate (rtx, rtx, machine_mode) final override; > > + bool prepare_mode (machine_mode, unsigned int) final override; > > + void finish_mode (machine_mode) final override; > > public: > > compare_by_pieces_d (rtx op0, rtx op1, by_pieces_constfn > > op1_cfn, > > void *op1_cfn_data, HOST_WIDE_INT len, int > > align, >
diff --git a/gcc/expr.cc b/gcc/expr.cc index 7197996cec7..ce58728862a 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -1357,8 +1357,8 @@ op_by_pieces_d::run () class move_by_pieces_d : public op_by_pieces_d { insn_gen_fn m_gen_fun; - void generate (rtx, rtx, machine_mode); - bool prepare_mode (machine_mode, unsigned int); + void generate (rtx, rtx, machine_mode) final override; + bool prepare_mode (machine_mode, unsigned int) final override; public: move_by_pieces_d (rtx to, rtx from, unsigned HOST_WIDE_INT len, @@ -1453,8 +1453,8 @@ move_by_pieces (rtx to, rtx from, unsigned HOST_WIDE_INT len, class store_by_pieces_d : public op_by_pieces_d { insn_gen_fn m_gen_fun; - void generate (rtx, rtx, machine_mode); - bool prepare_mode (machine_mode, unsigned int); + void generate (rtx, rtx, machine_mode) final override; + bool prepare_mode (machine_mode, unsigned int) final override; public: store_by_pieces_d (rtx to, by_pieces_constfn cfn, void *cfn_data, @@ -1650,9 +1650,9 @@ class compare_by_pieces_d : public op_by_pieces_d rtx m_accumulator; int m_count, m_batch; - void generate (rtx, rtx, machine_mode); - bool prepare_mode (machine_mode, unsigned int); - void finish_mode (machine_mode); + void generate (rtx, rtx, machine_mode) final override; + bool prepare_mode (machine_mode, unsigned int) final override; + void finish_mode (machine_mode) final override; public: compare_by_pieces_d (rtx op0, rtx op1, by_pieces_constfn op1_cfn, void *op1_cfn_data, HOST_WIDE_INT len, int align,
gcc/ChangeLog: * expr.cc: Add "final" and "override" to op_by_pieces_d vfunc implementations as appropriate. Signed-off-by: David Malcolm <dmalcolm@redhat.com> --- gcc/expr.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)