Message ID | 20220523174410.1979523-1-hjl.tools@gmail.com |
---|---|
State | New |
Headers | show |
Series | x86: Avoid uninitialized variable in PR target/104441 test | expand |
On Mon, May 23, 2022 at 7:44 PM H.J. Lu <hjl.tools@gmail.com> wrote: > > PR target/104441 > * gcc.target/i386/pr104441-1a.c (load8bit_4x4_avx2): Initialize > src23. LGTM. Thanks, Uros. > --- > gcc/testsuite/gcc.target/i386/pr104441-1a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/i386/pr104441-1a.c b/gcc/testsuite/gcc.target/i386/pr104441-1a.c > index 83734f710bd..0931029f2bb 100644 > --- a/gcc/testsuite/gcc.target/i386/pr104441-1a.c > +++ b/gcc/testsuite/gcc.target/i386/pr104441-1a.c > @@ -8,7 +8,7 @@ __attribute__((always_inline, target("avx2"))) > static __m256i > load8bit_4x4_avx2(const uint8_t *const src, const uint32_t stride) > { > - __m128i src01, src23; > + __m128i src01, src23 = _mm_setzero_si128(); > src01 = _mm_cvtsi32_si128(*(int32_t*)(src + 0 * stride)); > src23 = _mm_insert_epi32(src23, *(int32_t *)(src + 3 * stride), 1); > return _mm256_setr_m128i(src01, src23); > -- > 2.36.1 >
On Mon, 23 May 2022, H.J. Lu wrote: > PR target/104441 > * gcc.target/i386/pr104441-1a.c (load8bit_4x4_avx2): Initialize > src23. OK. Thanks for fixing. Richard. > --- > gcc/testsuite/gcc.target/i386/pr104441-1a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.target/i386/pr104441-1a.c b/gcc/testsuite/gcc.target/i386/pr104441-1a.c > index 83734f710bd..0931029f2bb 100644 > --- a/gcc/testsuite/gcc.target/i386/pr104441-1a.c > +++ b/gcc/testsuite/gcc.target/i386/pr104441-1a.c > @@ -8,7 +8,7 @@ __attribute__((always_inline, target("avx2"))) > static __m256i > load8bit_4x4_avx2(const uint8_t *const src, const uint32_t stride) > { > - __m128i src01, src23; > + __m128i src01, src23 = _mm_setzero_si128(); > src01 = _mm_cvtsi32_si128(*(int32_t*)(src + 0 * stride)); > src23 = _mm_insert_epi32(src23, *(int32_t *)(src + 3 * stride), 1); > return _mm256_setr_m128i(src01, src23); >
diff --git a/gcc/testsuite/gcc.target/i386/pr104441-1a.c b/gcc/testsuite/gcc.target/i386/pr104441-1a.c index 83734f710bd..0931029f2bb 100644 --- a/gcc/testsuite/gcc.target/i386/pr104441-1a.c +++ b/gcc/testsuite/gcc.target/i386/pr104441-1a.c @@ -8,7 +8,7 @@ __attribute__((always_inline, target("avx2"))) static __m256i load8bit_4x4_avx2(const uint8_t *const src, const uint32_t stride) { - __m128i src01, src23; + __m128i src01, src23 = _mm_setzero_si128(); src01 = _mm_cvtsi32_si128(*(int32_t*)(src + 0 * stride)); src23 = _mm_insert_epi32(src23, *(int32_t *)(src + 3 * stride), 1); return _mm256_setr_m128i(src01, src23);