| Message ID | 20220122115929.GV2646553@tucnak |
|---|---|
| State | New |
| Headers | show |
| Series | bootstrap: Fix bootstrap with --disable-plugin [PR104176] | expand |
> Am 22.01.2022 um 13:00 schrieb Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org>: > > Hi! > > With --disable-plugin, bootstrap fails on x86_64-linux or probably > all other targets with: > ../../gcc/opts-global.cc: In function ‘void handle_common_deferred_options()’: > ../../gcc/opts-global.cc:420:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag] > 420 | error ("plugin support is disabled; configure with --enable-plugin"); > | ^~~~~~~~~~~~~~~ > ../../gcc/opts-global.cc:428:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag] > 428 | error ("plugin support is disabled; configure with --enable-plugin"); > | ^~~~~~~~~~~~~~~ > > The following patch fixes that, bootstrapped on x86_64-linux with > --disable-plugin --enable-languages=c,c++ > without the patch (where it failed as above) and with it (where it > succeeded), ok for trunk Ok. Richard > 2022-01-22 Jakub Jelinek <jakub@redhat.com> > > PR other/104176 > * opts-global.cc (handle_common_deferred_options): Quote > --enable-plugin in diagnostics to avoid -Werror=format-diag. > > --- gcc/opts-global.cc.jj 2022-01-18 11:58:59.741979785 +0100 > +++ gcc/opts-global.cc 2022-01-22 02:18:39.116047945 +0100 > @@ -417,7 +417,8 @@ handle_common_deferred_options (void) > #ifdef ENABLE_PLUGIN > add_new_plugin (opt->arg); > #else > - error ("plugin support is disabled; configure with --enable-plugin"); > + error ("plugin support is disabled; configure with " > + "%<--enable-plugin%>"); > #endif > break; > > @@ -425,7 +426,8 @@ handle_common_deferred_options (void) > #ifdef ENABLE_PLUGIN > parse_plugin_arg_opt (opt->arg); > #else > - error ("plugin support is disabled; configure with --enable-plugin"); > + error ("plugin support is disabled; configure with " > + "%<--enable-plugin%>"); > #endif > break; > > > > Jakub >
--- gcc/opts-global.cc.jj 2022-01-18 11:58:59.741979785 +0100 +++ gcc/opts-global.cc 2022-01-22 02:18:39.116047945 +0100 @@ -417,7 +417,8 @@ handle_common_deferred_options (void) #ifdef ENABLE_PLUGIN add_new_plugin (opt->arg); #else - error ("plugin support is disabled; configure with --enable-plugin"); + error ("plugin support is disabled; configure with " + "%<--enable-plugin%>"); #endif break; @@ -425,7 +426,8 @@ handle_common_deferred_options (void) #ifdef ENABLE_PLUGIN parse_plugin_arg_opt (opt->arg); #else - error ("plugin support is disabled; configure with --enable-plugin"); + error ("plugin support is disabled; configure with " + "%<--enable-plugin%>"); #endif break;
Hi! With --disable-plugin, bootstrap fails on x86_64-linux or probably all other targets with: ../../gcc/opts-global.cc: In function ‘void handle_common_deferred_options()’: ../../gcc/opts-global.cc:420:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag] 420 | error ("plugin support is disabled; configure with --enable-plugin"); | ^~~~~~~~~~~~~~~ ../../gcc/opts-global.cc:428:62: error: unquoted option name ‘--enable-plugin’ in format [-Werror=format-diag] 428 | error ("plugin support is disabled; configure with --enable-plugin"); | ^~~~~~~~~~~~~~~ The following patch fixes that, bootstrapped on x86_64-linux with --disable-plugin --enable-languages=c,c++ without the patch (where it failed as above) and with it (where it succeeded), ok for trunk? 2022-01-22 Jakub Jelinek <jakub@redhat.com> PR other/104176 * opts-global.cc (handle_common_deferred_options): Quote --enable-plugin in diagnostics to avoid -Werror=format-diag. Jakub