diff mbox series

arm: Fix __arm_vctp16q return type in arm_mve.h

Message ID 20210816131247.3046746-1-christophe.lyon@foss.st.com
State New
Headers show
Series arm: Fix __arm_vctp16q return type in arm_mve.h | expand

Commit Message

Christophe Lyon Aug. 16, 2021, 1:12 p.m. UTC 
__arm_vctp16q actually returns mve_pred16_t rather than int64_t.

2021-08-16  Christophe Lyon  <christophe.lyon@foss.st.com>

	gcc/
	* config/arm/arm_mve.h: Fix __arm_vctp16q return type.
---
 gcc/config/arm/arm_mve.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christophe Lyon Aug. 23, 2021, 8:59 a.m. UTC | #1 
ping?


On 16/08/2021 15:12, Christophe Lyon wrote:
> __arm_vctp16q actually returns mve_pred16_t rather than int64_t.
>
> 2021-08-16  Christophe Lyon  <christophe.lyon@foss.st.com>
>
> 	gcc/
> 	* config/arm/arm_mve.h: Fix __arm_vctp16q return type.
> ---
>   gcc/config/arm/arm_mve.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
> index 83f10036990..e04d46218d0 100644
> --- a/gcc/config/arm/arm_mve.h
> +++ b/gcc/config/arm/arm_mve.h
> @@ -3524,7 +3524,7 @@ __arm_vaddlvq_u32 (uint32x4_t __a)
>     return __builtin_mve_vaddlvq_uv4si (__a);
>   }
>   
> -__extension__ extern __inline int64_t
> +__extension__ extern __inline mve_pred16_t
>   __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
>   __arm_vctp16q (uint32_t __a)
>   {
Kyrylo Tkachov Aug. 23, 2021, 9:30 a.m. UTC | #2 
> -----Original Message-----
> From: Gcc-patches <gcc-patches-
> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Christophe
> Lyon via Gcc-patches
> Sent: 16 August 2021 14:13
> To: gcc-patches@gcc.gnu.org
> Subject: [PATCH] arm: Fix __arm_vctp16q return type in arm_mve.h
> 
> __arm_vctp16q actually returns mve_pred16_t rather than int64_t.
> 

Ok. Does this need a backport?
Thanks,
Kyrill

> 2021-08-16  Christophe Lyon  <christophe.lyon@foss.st.com>
> 
> 	gcc/
> 	* config/arm/arm_mve.h: Fix __arm_vctp16q return type.
> ---
>  gcc/config/arm/arm_mve.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
> index 83f10036990..e04d46218d0 100644
> --- a/gcc/config/arm/arm_mve.h
> +++ b/gcc/config/arm/arm_mve.h
> @@ -3524,7 +3524,7 @@ __arm_vaddlvq_u32 (uint32x4_t __a)
>    return __builtin_mve_vaddlvq_uv4si (__a);
>  }
> 
> -__extension__ extern __inline int64_t
> +__extension__ extern __inline mve_pred16_t
>  __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
>  __arm_vctp16q (uint32_t __a)
>  {
> --
> 2.25.1
Christophe Lyon Aug. 23, 2021, 9:41 a.m. UTC | #3 
On 23/08/2021 11:30, Kyrylo Tkachov wrote:
>
>> -----Original Message-----
>> From: Gcc-patches <gcc-patches-
>> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Christophe
>> Lyon via Gcc-patches
>> Sent: 16 August 2021 14:13
>> To: gcc-patches@gcc.gnu.org
>> Subject: [PATCH] arm: Fix __arm_vctp16q return type in arm_mve.h
>>
>> __arm_vctp16q actually returns mve_pred16_t rather than int64_t.
>>
> Ok. Does this need a backport?


Good point. I think so: branches gcc-10 and gcc-11 are affected, gcc-9 
did not support MVE yet.


> Thanks,
> Kyrill
>
>> 2021-08-16  Christophe Lyon  <christophe.lyon@foss.st.com>
>>
>> 	gcc/
>> 	* config/arm/arm_mve.h: Fix __arm_vctp16q return type.
>> ---
>>   gcc/config/arm/arm_mve.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
>> index 83f10036990..e04d46218d0 100644
>> --- a/gcc/config/arm/arm_mve.h
>> +++ b/gcc/config/arm/arm_mve.h
>> @@ -3524,7 +3524,7 @@ __arm_vaddlvq_u32 (uint32x4_t __a)
>>     return __builtin_mve_vaddlvq_uv4si (__a);
>>   }
>>
>> -__extension__ extern __inline int64_t
>> +__extension__ extern __inline mve_pred16_t
>>   __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
>>   __arm_vctp16q (uint32_t __a)
>>   {
>> --
>> 2.25.1
Kyrylo Tkachov Aug. 23, 2021, 10:10 a.m. UTC | #4 
> -----Original Message-----
> From: Christophe LYON <christophe.lyon@foss.st.com>
> Sent: 23 August 2021 10:41
> To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] arm: Fix __arm_vctp16q return type in arm_mve.h
> 
> 
> On 23/08/2021 11:30, Kyrylo Tkachov wrote:
> >
> >> -----Original Message-----
> >> From: Gcc-patches <gcc-patches-
> >> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of
> Christophe
> >> Lyon via Gcc-patches
> >> Sent: 16 August 2021 14:13
> >> To: gcc-patches@gcc.gnu.org
> >> Subject: [PATCH] arm: Fix __arm_vctp16q return type in arm_mve.h
> >>
> >> __arm_vctp16q actually returns mve_pred16_t rather than int64_t.
> >>
> > Ok. Does this need a backport?
> 
> 
> Good point. I think so: branches gcc-10 and gcc-11 are affected, gcc-9
> did not support MVE yet.

Ok, please backport it wherever it's needed.
Thanks,
Kyrill

> 
> 
> > Thanks,
> > Kyrill
> >
> >> 2021-08-16  Christophe Lyon  <christophe.lyon@foss.st.com>
> >>
> >> 	gcc/
> >> 	* config/arm/arm_mve.h: Fix __arm_vctp16q return type.
> >> ---
> >>   gcc/config/arm/arm_mve.h | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
> >> index 83f10036990..e04d46218d0 100644
> >> --- a/gcc/config/arm/arm_mve.h
> >> +++ b/gcc/config/arm/arm_mve.h
> >> @@ -3524,7 +3524,7 @@ __arm_vaddlvq_u32 (uint32x4_t __a)
> >>     return __builtin_mve_vaddlvq_uv4si (__a);
> >>   }
> >>
> >> -__extension__ extern __inline int64_t
> >> +__extension__ extern __inline mve_pred16_t
> >>   __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
> >>   __arm_vctp16q (uint32_t __a)
> >>   {
> >> --
> >> 2.25.1
Christophe Lyon Aug. 23, 2021, 12:04 p.m. UTC | #5 
On 23/08/2021 12:10, Kyrylo Tkachov wrote:
>
>> -----Original Message-----
>> From: Christophe LYON <christophe.lyon@foss.st.com>
>> Sent: 23 August 2021 10:41
>> To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
>> Cc: gcc-patches@gcc.gnu.org
>> Subject: Re: [PATCH] arm: Fix __arm_vctp16q return type in arm_mve.h
>>
>>
>> On 23/08/2021 11:30, Kyrylo Tkachov wrote:
>>>> -----Original Message-----
>>>> From: Gcc-patches <gcc-patches-
>>>> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of
>> Christophe
>>>> Lyon via Gcc-patches
>>>> Sent: 16 August 2021 14:13
>>>> To: gcc-patches@gcc.gnu.org
>>>> Subject: [PATCH] arm: Fix __arm_vctp16q return type in arm_mve.h
>>>>
>>>> __arm_vctp16q actually returns mve_pred16_t rather than int64_t.
>>>>
>>> Ok. Does this need a backport?
>>
>> Good point. I think so: branches gcc-10 and gcc-11 are affected, gcc-9
>> did not support MVE yet.
> Ok, please backport it wherever it's needed.
> Thanks,
> Kyrill

Thanks, committed to trunk, gcc-11 and gcc-10.


Christophe


>>
>>> Thanks,
>>> Kyrill
>>>
>>>> 2021-08-16  Christophe Lyon  <christophe.lyon@foss.st.com>
>>>>
>>>> 	gcc/
>>>> 	* config/arm/arm_mve.h: Fix __arm_vctp16q return type.
>>>> ---
>>>>    gcc/config/arm/arm_mve.h | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
>>>> index 83f10036990..e04d46218d0 100644
>>>> --- a/gcc/config/arm/arm_mve.h
>>>> +++ b/gcc/config/arm/arm_mve.h
>>>> @@ -3524,7 +3524,7 @@ __arm_vaddlvq_u32 (uint32x4_t __a)
>>>>      return __builtin_mve_vaddlvq_uv4si (__a);
>>>>    }
>>>>
>>>> -__extension__ extern __inline int64_t
>>>> +__extension__ extern __inline mve_pred16_t
>>>>    __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
>>>>    __arm_vctp16q (uint32_t __a)
>>>>    {
>>>> --
>>>> 2.25.1
diff mbox series

Patch

diff --git a/gcc/config/arm/arm_mve.h b/gcc/config/arm/arm_mve.h
index 83f10036990..e04d46218d0 100644
--- a/gcc/config/arm/arm_mve.h
+++ b/gcc/config/arm/arm_mve.h
@@ -3524,7 +3524,7 @@  __arm_vaddlvq_u32 (uint32x4_t __a)
   return __builtin_mve_vaddlvq_uv4si (__a);
 }
 
-__extension__ extern __inline int64_t
+__extension__ extern __inline mve_pred16_t
 __attribute__ ((__always_inline__, __gnu_inline__, __artificial__))
 __arm_vctp16q (uint32_t __a)
 {