From patchwork Wed May 5 19:36:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 1474544 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=sotXO1V5; dkim-atps=neutral Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fb6Rb4gWNz9sPf for ; Thu, 6 May 2021 05:37:15 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 987D33A4E87D; Wed, 5 May 2021 19:37:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 987D33A4E87D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1620243425; bh=i8tMgBhKUa1KxTz9dVJak7zq/VY0h9agqTkFXx2j9+w=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sotXO1V5RLGU3SmeHjGPo9La9urHbHgFskYXtu9zq4OwiV4gG5Fx6tPP1FQGB3Ity kXc8IxjMTcytYi1Bz/nyglaoLQ3gCrpdCTtX20ucEE0iCy+/vZ3tLAl5oadmz7VgXU 3B2vRrFKQ/G7TjUhqdz7sGR6oAfSpBsODFhbS+TU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by sourceware.org (Postfix) with ESMTPS id 0407138618D7; Wed, 5 May 2021 19:37:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0407138618D7 Received: by mail-ed1-f42.google.com with SMTP id bf4so3367263edb.11; Wed, 05 May 2021 12:37:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i8tMgBhKUa1KxTz9dVJak7zq/VY0h9agqTkFXx2j9+w=; b=tmaA6I+uqWhU3XEtSIZEfEypaoP4HZiv5t5MUgtnx6Q+6xlJFyZ2HDAkmilnwlqiUe 2pu/jAxCREpKmMjvz10SgPc7HcRL2OwFCuFk+ar3HGqLZpirBkZyoPbGnutx70jbFTAW 6F27o0BwzM+LLDiRpZGFektg9PI9CUvvhdoWEGuNK/LVT9bRiRsvvyqi6DJmth+ABlqG wBCNwb/gFk5ISAnoXQnZZRV0IuY4JUCYtkrhkRg67em7Ns/w0zLX2Qd3UzaxRJ03/8bY 0qm8N+k0QJKNp7PpUr6Es6vRXNFIMM8BYZUnM0DTanWoL27DTS9bW2C65a2834k4jpdz J1kA== X-Gm-Message-State: AOAM5310VGTmfEbSGkTOtTcWvgUkW1kKeYZLKgJ+56MSoksLXRtji6l/ XMlirP/ZgrsVMeOuDjLsDkWdDStjfEaWdpCB X-Google-Smtp-Source: ABdhPJxvZAJ97PHEacjWq5HjXuOX1qgijnmmZfhLL1CerXFvZwzg7W4dy4G8zzb0GyOBeyW2Amcnqw== X-Received: by 2002:a05:6402:354b:: with SMTP id f11mr690179edd.139.1620243421811; Wed, 05 May 2021 12:37:01 -0700 (PDT) Received: from beast.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id t7sm60531eds.26.2021.05.05.12.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 12:37:01 -0700 (PDT) To: gcc-patches@gcc.gnu.org Subject: [PATCH v2 02/10] RISC-V: Emit proper memory ordering suffixes for AMOs [PR 100265] Date: Wed, 5 May 2021 21:36:43 +0200 Message-Id: <20210505193651.2075405-3-cmuellner@gcc.gnu.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210505193651.2075405-1-cmuellner@gcc.gnu.org> References: <20210505193651.2075405-1-cmuellner@gcc.gnu.org> MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christoph Muellner via Gcc-patches From: =?utf-8?q?Christoph_M=C3=BCllner?= Reply-To: Christoph Muellner Cc: Kito Cheng Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" The ratified A extension supports '.aq', '.rl' and '.aqrl' as memory ordering suffixes. Let's emit them in case we get a '%A' conversion specifier for riscv_print_operand(). As '%A' was already used for a similar, but restricted, purpose (only '.aq' was emitted so far), this does not require any other changes. gcc/ PR 100265 * config/riscv/riscv.c (riscv_memmodel_needs_amo_acquire): Remove function. * config/riscv/riscv.c (riscv_print_amo_memory_ordering_suffix): Add function to emit AMO memory ordering suffixes. * config/riscv/riscv.c (riscv_print_operand): Call riscv_print_amo_memory_ordering_suffix() instead of riscv_memmodel_needs_amo_acquire(). --- gcc/config/riscv/riscv.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c index 545f3d0cb82c..3edd5c239d7c 100644 --- a/gcc/config/riscv/riscv.c +++ b/gcc/config/riscv/riscv.c @@ -3346,24 +3346,26 @@ riscv_print_operand_reloc (FILE *file, rtx op, bool hi_reloc) fputc (')', file); } -/* Return true if the .AQ suffix should be added to an AMO to implement the - acquire portion of memory model MODEL. */ +/* Print the memory ordering suffix for AMOs. */ -static bool -riscv_memmodel_needs_amo_acquire (const enum memmodel model) +static void +riscv_print_amo_memory_ordering_suffix (FILE *file, const enum memmodel model) { switch (model) { - case MEMMODEL_ACQ_REL: - case MEMMODEL_SEQ_CST: - case MEMMODEL_ACQUIRE: + case MEMMODEL_RELAXED: + break; case MEMMODEL_CONSUME: - return true; - + case MEMMODEL_ACQUIRE: + fputs (".aq", file); + break; case MEMMODEL_RELEASE: - case MEMMODEL_RELAXED: - return false; - + fputs (".rl", file); + break; + case MEMMODEL_ACQ_REL: + case MEMMODEL_SEQ_CST: + fputs (".aqrl", file); + break; default: gcc_unreachable (); } @@ -3428,8 +3430,7 @@ riscv_print_operand (FILE *file, rtx op, int letter) break; case 'A': - if (riscv_memmodel_needs_amo_acquire (model)) - fputs (".aq", file); + riscv_print_amo_memory_ordering_suffix (file, model); break; case 'F':