| Message ID | 20210429094742.GG1179226@tucnak |
|---|---|
| State | New |
| Headers | show |
| Series | [committed] testsuite: Remove dg-options from pr100305.c [PR100305] | expand |
Jakub Jelinek <jakub@redhat.com> writes: > Hi! > > The test FAILs on i?86-linux (due to -Wpsabi warnings). But, on closer > inspection it seems there is another problem, the dg-options in the testcase > means that the test is compiled with -O0 -O, -O1 -O, -O2 -O, -O3 -O, -Os -O > etc. options, so effectively is tested multiple times with the same options. > > Fixed by dropping the dg-options line, then we have -w by default and iterate > over all the optimization levels (including the -O). Gah, sorry about that. It started life as an aarch64-specific test, where the dg-options was needed. I forgot to remove it when moving the test. Richard > Tested on x86_64-linux with > RUNTESTFLAGS='--target_board=unix\{-m32/-mno-sse,-m32,-m64\} compile.exp=pr100305.c' > and committed to trunk and 11 as obvious. > > 2021-04-29 Jakub Jelinek <jakub@redhat.com> > > PR target/100305 > * gcc.c-torture/compile/pr100305.c: Remove dg-options. Add PR line. > > --- gcc/testsuite/gcc.c-torture/compile/pr100305.c.jj 2021-04-29 11:07:58.877205739 +0200 > +++ gcc/testsuite/gcc.c-torture/compile/pr100305.c 2021-04-29 11:39:42.161152369 +0200 > @@ -1,4 +1,4 @@ > -/* { dg-options "-O" } */ > +/* PR target/100305 */ > > typedef double v2df __attribute__((vector_size(16))); > > > > Jakub
--- gcc/testsuite/gcc.c-torture/compile/pr100305.c.jj 2021-04-29 11:07:58.877205739 +0200 +++ gcc/testsuite/gcc.c-torture/compile/pr100305.c 2021-04-29 11:39:42.161152369 +0200 @@ -1,4 +1,4 @@ -/* { dg-options "-O" } */ +/* PR target/100305 */ typedef double v2df __attribute__((vector_size(16)));
Hi! The test FAILs on i?86-linux (due to -Wpsabi warnings). But, on closer inspection it seems there is another problem, the dg-options in the testcase means that the test is compiled with -O0 -O, -O1 -O, -O2 -O, -O3 -O, -Os -O etc. options, so effectively is tested multiple times with the same options. Fixed by dropping the dg-options line, then we have -w by default and iterate over all the optimization levels (including the -O). Tested on x86_64-linux with RUNTESTFLAGS='--target_board=unix\{-m32/-mno-sse,-m32,-m64\} compile.exp=pr100305.c' and committed to trunk and 11 as obvious. 2021-04-29 Jakub Jelinek <jakub@redhat.com> PR target/100305 * gcc.c-torture/compile/pr100305.c: Remove dg-options. Add PR line. Jakub