From patchwork Tue Mar 30 15:00:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1460097 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=tpg7K9th; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4F8t2g4LGpz9sVm for ; Wed, 31 Mar 2021 02:02:02 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 34B393861800; Tue, 30 Mar 2021 15:01:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34B393861800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1617116519; bh=bV5wUSNqYPPWPOYI1JEOkMerUz/6Leg/22SxBmDsNVI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tpg7K9thReP7ErUSCb+Fg8YSk5nm8w6wRD0EVQTgY2dBCaT1kMoj+AMbk0YvQYVYU GID1r2+jpJniPyIDIR8XS5lU39OKwyGJlYbu5u04vH5iI9/bmK0RiZa39w90VBN7iq 4TGn9aUlTSAtuSFUp3vgQlKAAPoNb+REocxfuNXM= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 5EE1B3858002 for ; Tue, 30 Mar 2021 15:01:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5EE1B3858002 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-oD8GZSFHPQOY_hc1SYhXvQ-1; Tue, 30 Mar 2021 11:01:11 -0400 X-MC-Unique: oD8GZSFHPQOY_hc1SYhXvQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0D99108E85D; Tue, 30 Mar 2021 15:00:51 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-95.ams2.redhat.com [10.36.112.95]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16ECC1001B2C; Tue, 30 Mar 2021 15:00:50 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 12UF0nkl1744307 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 30 Mar 2021 17:00:49 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 12UF0mpJ1744306; Tue, 30 Mar 2021 17:00:48 +0200 Date: Tue, 30 Mar 2021 17:00:48 +0200 To: Richard Biener Subject: [PATCH] testsuite, v2: Disable zero-scratch-regs-{8,9,10,11}.c on all but ... [PR97680] Message-ID: <20210330150048.GK1179226@tucnak> References: <20210330104358.GH1179226@tucnak> <20210330115553.GJ1179226@tucnak> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jakub Jelinek via Gcc-patches From: Jakub Jelinek Reply-To: Jakub Jelinek Cc: GCC Patches Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" On Tue, Mar 30, 2021 at 02:33:17PM +0200, Richard Biener via Gcc-patches wrote: > > I don't know, perhaps. > > Seems the target hook is only defined on > > config/i386/i386.c:#undef TARGET_ZERO_CALL_USED_REGS > > config/i386/i386.c:#define TARGET_ZERO_CALL_USED_REGS ix86_zero_call_used_regs > > config/sparc/sparc.c:#undef TARGET_ZERO_CALL_USED_REGS > > config/sparc/sparc.c:#define TARGET_ZERO_CALL_USED_REGS sparc_zero_call_used_regs > > but apparently many of the tests actually succeed on various targets that > > don't define those hooks. E.g. I haven't seen them to fail on aarch64, > > on arm only the -10.c fails, on powerpc*/s390* all {8,9,10,11} fail (plus > > 5 is skipped on power*-aix*). > > On ia64 according to testresults {6,7,8,9,10,11} fail, some with ICEs. > > On mipsel according to testresults {9,10,11} fail, some with ICEs. > > On nvptx at least 1-9 succeed, 10-11 don't know, don't have assert.h around. > > > > So, do we want to fill in negative dg-skip-if for the 6-11 tests or > > positive? In any case, is there any hope any of the maintainers or the > > original submitter will change anything for GCC 12, or are we going to end > > up with a very narrowly supported feature? > > It looks like the latter - I've seen no attempt by the original authors to make > the feature work on more targets than they cared for. So, like this instead? I've kept {5,6,7} with aix,ia64,ia64 skipped because those seems like outliers, it works pretty much everywhere but on those. The rest have known good targets. Tested on x86_64-linux, verified all tests are run there. 2021-03-30 Jakub Jelinek PR testsuite/97680 * c-c++-common/zero-scratch-regs-6.c: Skip on ia64. * c-c++-common/zero-scratch-regs-7.c: Likewise. * c-c++-common/zero-scratch-regs-8.c: Change from dg-skip-if of selected unsupported triplets to all targets but selected triplets of supported targets. * c-c++-common/zero-scratch-regs-9.c: Likewise. * c-c++-common/zero-scratch-regs-10.c: Likewise. * c-c++-common/zero-scratch-regs-11.c: Likewise. Jakub --- gcc/testsuite/c-c++-common/zero-scratch-regs-6.c.jj 2020-10-31 17:41:19.793739605 +0100 +++ gcc/testsuite/c-c++-common/zero-scratch-regs-6.c 2021-03-30 16:19:00.509582587 +0200 @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-skip-if "not implemented" { ia64*-*-* } } */ /* { dg-options "-O2 -fzero-call-used-regs=all-gpr-arg" } */ #include "zero-scratch-regs-1.c" --- gcc/testsuite/c-c++-common/zero-scratch-regs-7.c.jj 2020-10-31 17:41:19.793739605 +0100 +++ gcc/testsuite/c-c++-common/zero-scratch-regs-7.c 2021-03-30 16:19:12.059454807 +0200 @@ -1,4 +1,5 @@ /* { dg-do run } */ +/* { dg-skip-if "not implemented" { ia64*-*-* } } */ /* { dg-options "-O2 -fzero-call-used-regs=all-gpr" } */ #include "zero-scratch-regs-1.c" --- gcc/testsuite/c-c++-common/zero-scratch-regs-8.c.jj 2020-11-11 01:46:03.392696119 +0100 +++ gcc/testsuite/c-c++-common/zero-scratch-regs-8.c 2021-03-30 16:21:28.453945834 +0200 @@ -1,5 +1,5 @@ /* { dg-do run } */ -/* { dg-skip-if "not implemented" { powerpc*-*-* } } */ +/* { dg-skip-if "not implemented" { ! { i?86*-*-* x86_64*-*-* sparc*-*-* aarch64*-*-* arm*-*-* nvptx*-*-* } } } */ /* { dg-options "-O2 -fzero-call-used-regs=all-arg" } */ #include "zero-scratch-regs-1.c" --- gcc/testsuite/c-c++-common/zero-scratch-regs-9.c.jj 2020-11-11 01:46:03.392696119 +0100 +++ gcc/testsuite/c-c++-common/zero-scratch-regs-9.c 2021-03-30 16:21:41.711799156 +0200 @@ -1,5 +1,5 @@ /* { dg-do run } */ -/* { dg-skip-if "not implemented" { powerpc*-*-* } } */ +/* { dg-skip-if "not implemented" { ! { i?86*-*-* x86_64*-*-* sparc*-*-* aarch64*-*-* arm*-*-* nvptx*-*-* } } } */ /* { dg-options "-O2 -fzero-call-used-regs=all" } */ #include "zero-scratch-regs-1.c" --- gcc/testsuite/c-c++-common/zero-scratch-regs-10.c.jj 2021-03-18 15:32:56.459617723 +0100 +++ gcc/testsuite/c-c++-common/zero-scratch-regs-10.c 2021-03-30 16:21:55.017651951 +0200 @@ -1,6 +1,5 @@ /* { dg-do run } */ -/* { dg-skip-if "not implemented" { powerpc*-*-* } } */ -/* { dg-skip-if "not implemented" { arm*-*-* } } */ +/* { dg-skip-if "not implemented" { ! { i?86*-*-* x86_64*-*-* sparc*-*-* aarch64*-*-* nvptx*-*-* } } } */ /* { dg-options "-O2" } */ #include --- gcc/testsuite/c-c++-common/zero-scratch-regs-11.c.jj 2020-11-11 01:46:03.392696119 +0100 +++ gcc/testsuite/c-c++-common/zero-scratch-regs-11.c 2021-03-30 16:22:04.439547999 +0200 @@ -1,5 +1,5 @@ /* { dg-do run } */ -/* { dg-skip-if "not implemented" { powerpc*-*-* } } */ +/* { dg-skip-if "not implemented" { ! { i?86*-*-* x86_64*-*-* sparc*-*-* aarch64*-*-* arm*-*-* nvptx*-*-* } } } */ /* { dg-options "-O2 -fzero-call-used-regs=all" } */ #include "zero-scratch-regs-10.c"