diff mbox series

rs6000: clean up testsuite power10_hw check

Message ID 20200713212742.126876-1-acsawdey@linux.ibm.com
State New
Headers show
Series rs6000: clean up testsuite power10_hw check | expand

Commit Message

Aaron Sawdey July 13, 2020, 9:27 p.m. UTC 
Because the check for power10_hw is not called
check_effective_target_power10_hw, it needs to be looked
for by is-effective-target-keyword. Also reorder things
in is-effective-target to put power10_hw with the other
ppc stuff.

These little fixes for power10 dejagnu support were pre-approved
for trunk and 10 by Segher. Posting before pushing.

  Aaron

gcc/testsuite/

	* lib/target-supports.exp (is-effective-target):
	Reorder to put powerpc stuff together.
	(is-effective-target-keyword): Add power10_hw.
---
 gcc/testsuite/lib/target-supports.exp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Segher Boessenkool July 14, 2020, 5:20 p.m. UTC | #1 
Hi!

On Mon, Jul 13, 2020 at 04:27:42PM -0500, Aaron Sawdey via Gcc-patches wrote:
> Because the check for power10_hw is not called
> check_effective_target_power10_hw, it needs to be looked
> for by is-effective-target-keyword.

Ah, so *that* is the reason we have this...  So probably we should just
call the function check_effective_target_power10_hw and then everything
works as we want?

(For future consideration, of course :-) )


Segher
diff mbox series

Patch

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 2e4c696fdd1..57eed3012b9 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -7851,6 +7851,7 @@  proc is-effective-target { arg } {
 	  "p8vector_hw"    { set selected [check_p8vector_hw_available] }
 	  "p9vector_hw"    { set selected [check_p9vector_hw_available] }
 	  "p9modulo_hw"    { set selected [check_p9modulo_hw_available] }
+	  "power10_hw"     { set selected [check_power10_hw_available] }
 	  "ppc_float128_sw" { set selected [check_ppc_float128_sw_available] }
 	  "ppc_float128_hw" { set selected [check_ppc_float128_hw_available] }
 	  "ppc_recip_hw"   { set selected [check_ppc_recip_hw_available] }
@@ -7861,7 +7862,6 @@  proc is-effective-target { arg } {
 	  "named_sections" { set selected [check_named_sections_available] }
 	  "gc_sections"    { set selected [check_gc_sections_available] }
 	  "cxa_atexit"     { set selected [check_cxa_atexit_available] }
-	  "power10_hw" { set selected [check_power10_hw_available] }
 	  default          { error "unknown effective target keyword `$arg'" }
 	}
     }
@@ -7883,6 +7883,7 @@  proc is-effective-target-keyword { arg } {
 	  "p8vector_hw"    { return 1 }
 	  "p9vector_hw"    { return 1 }
 	  "p9modulo_hw"    { return 1 }
+	  "power10_hw"     { return 1 }
 	  "ppc_float128_sw" { return 1 }
 	  "ppc_float128_hw" { return 1 }
 	  "ppc_recip_hw"   { return 1 }