Message ID | 20200317101859.GE2156@tucnak |
---|---|
State | New |
Headers | show
Return-Path: <gcc-patches-bounces@gcc.gnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=aQKP/Zjs; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48hTfm71cPz9sPR for <incoming@patchwork.ozlabs.org>; Tue, 17 Mar 2020 21:19:11 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 860753885C3E; Tue, 17 Mar 2020 10:19:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 860753885C3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1584440347; bh=VPObKTKUNCtsVGlNe5D+yfp7k5zsJnoFl/68lOVEg4o=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=aQKP/ZjsEMqS9HJMXB8zCcyJFgUgG/fnBgW+81vrFXicthM5U6HxGOoWP1zySESF9 Vxs7+ozV4BN95k/kMFUN5ui+Cf51OpbadqC8awAtyKV0tPKF3ER17ft85hh9hPTj3q ApIUSjmu60SGeXTCBMYLtdymyg/uIWwvqRxaH/8w= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by sourceware.org (Postfix) with ESMTP id 87AF6385F022 for <gcc-patches@gcc.gnu.org>; Tue, 17 Mar 2020 10:19:05 +0000 (GMT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-90-TDXsvuoQOjGJUgWdEXB-Hw-1; Tue, 17 Mar 2020 06:19:03 -0400 X-MC-Unique: TDXsvuoQOjGJUgWdEXB-Hw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1131100550E for <gcc-patches@gcc.gnu.org>; Tue, 17 Mar 2020 10:19:02 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-22.ams2.redhat.com [10.36.112.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 573305C1BB; Tue, 17 Mar 2020 10:19:02 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 02HAJ0Y6006269; Tue, 17 Mar 2020 11:19:00 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 02HAIxXC006268; Tue, 17 Mar 2020 11:18:59 +0100 Date: Tue, 17 Mar 2020 11:18:59 +0100 To: Vladimir Makarov <vmakarov@redhat.com> Subject: [committed] testsuite: Fix pr94185.C testcase on i686-linux with C++98 [PR94185] Message-ID: <20200317101859.GE2156@tucnak> References: <b0037b07-7a3d-535e-d22e-598b7ff0ecbb@redhat.com> MIME-Version: 1.0 In-Reply-To: <b0037b07-7a3d-535e-d22e-598b7ff0ecbb@redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Spam-Status: No, score=-10.2 required=5.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <http://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <http://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <http://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Jakub Jelinek via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Jakub Jelinek <jakub@redhat.com> Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org> Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces@gcc.gnu.org> |
Series |
[committed] testsuite: Fix pr94185.C testcase on i686-linux with C++98 [PR94185]
|
expand
|
--- gcc/testsuite/g++.target/i386/pr94185.C.jj 2020-03-16 22:56:55.000000000 +0100 +++ gcc/testsuite/g++.target/i386/pr94185.C 2020-03-17 11:11:10.158846926 +0100 @@ -22,7 +22,7 @@ int d; void l(char *, ar m, long n) { switch (m.au[d]) case 0: - n &= 4294967295; + n &= 4294967295U; bb.h(0).g(n); } void o() {
Hi! On Mon, Mar 16, 2020 at 04:47:05PM -0400, Vladimir Makarov via Gcc-patches wrote: > The following committed patch solves I'm getting on i686-linux FAIL: g++.target/i386/pr94185.C -std=gnu++98 (test for excess errors) This is because of a diagnostic that 4294967295 is unsigned only in ISO C90. Adding U suffix fixes it and the testcase still ICEs with unfixed gcc and passes with current trunk. Tested on x86_64-linux with check-c++-all RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} i386.exp=pr94185.C' both using older GCC where it ICEs and current where it now all PASSes, committed to trunk as obvious. 2020-03-17 Jakub Jelinek <jakub@redhat.com> PR target/94185 * g++.target/i386/pr94185.C (l): Use 4294967295U instead of 4294967295 to avoid FAIL with -m32 -std=c++98. Jakub