From patchwork Wed Oct 30 09:22:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 1186609 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-512023-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="KGOJMVVK"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4732zw5NTVz9s4Y for ; Wed, 30 Oct 2019 20:22:49 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=oYQGITemiOesidlQrK2UDhttHUu23pB123e/t2Hw5m1LnMBJX/BC1 Riq9w88AmRGy8SUvhJOn/HKrDoYM1jjUlyCxSJ3toCD/MIVe5DDhffSPiVOLABCp PuWsGFvxEuveMD69v5YHFC4ZCPlUYusbaEBLxOSCrbj437M9pVYGFs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=mnPh1csiIVMRK5Br925PM8rkkGE=; b=KGOJMVVKD+Q5MusqGH2L Dwti5LwRES2tevyvgZKIsUtzmGZ3yk0sN1NaY9x7viTEuuHr8TklNhfI6XMIljYE yRnu+5HvWv/dsRjukgOjL2XXRl1FCBHGEo8o0xlaydDMkpLyBJ7HJqiE3fccxZaN WwTDHo+L1w1zppQUIyvC30A= Received: (qmail 10782 invoked by alias); 30 Oct 2019 09:22:41 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10767 invoked by uid 89); 30 Oct 2019 09:22:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=site X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 09:22:38 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 80F79280834; Wed, 30 Oct 2019 10:22:36 +0100 (CET) Date: Wed, 30 Oct 2019 10:22:36 +0100 From: Jan Hubicka To: gcc-patches@gcc.gnu.org, mjambor@suse.cz Subject: Watch for missing summaries even more Message-ID: <20191030092236.og3pjotzqrzsaifs@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Hi, this patch fixes another place we may have missing argument summary. Here the situation is that the call site being inlined has no jump functions while function which is being inlines has another call with jump function. This can validly happen when we inline into functions with indirect inlining and ipa-cp disabled but I am not 100% why it happens i.e. during Firefox builds. Martin, do you have any ideas? Honza * ipa-prop.c (update_jump_functions_after_inlining): Watch for missing summaries. Index: ipa-prop.c =================================================================== --- ipa-prop.c (revision 277573) +++ ipa-prop.c (working copy) @@ -2660,6 +2660,11 @@ update_jump_functions_after_inlining (st for (i = 0; i < count; i++) { struct ipa_jump_func *dst = ipa_get_ith_jump_func (args, i); + if (!top) + { + ipa_set_jf_unknown (dst); + continue; + } class ipa_polymorphic_call_context *dst_ctx = ipa_get_ith_polymorhic_call_context (args, i);