From patchwork Wed Nov 23 14:46:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikael Pettersson X-Patchwork-Id: 127317 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4CD001007D4 for ; Thu, 24 Nov 2011 01:47:10 +1100 (EST) Received: (qmail 9719 invoked by alias); 23 Nov 2011 14:47:08 -0000 Received: (qmail 9708 invoked by uid 22791); 23 Nov 2011 14:47:06 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fanny.its.uu.se (HELO fanny.its.uu.se) (130.238.4.241) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 14:46:43 +0000 Received: from fanny.its.uu.se (localhost [127.0.0.1]) by fanny.its.uu.se (Postfix) with ESMTP id A2FC064EC; Wed, 23 Nov 2011 15:46:40 +0100 (MEZ) Received: from pilspetsen.it.uu.se (pilspetsen.it.uu.se [130.238.18.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by fanny.its.uu.se (Postfix) with ESMTP id 1E6CB63BE; Wed, 23 Nov 2011 15:46:40 +0100 (MEZ) Received: (from mikpe@localhost) by pilspetsen.it.uu.se (8.14.4+Sun/8.14.4) id pANEkdH9015868; Wed, 23 Nov 2011 15:46:39 +0100 (MET) MIME-Version: 1.0 Message-ID: <20173.1871.63866.22607@pilspetsen.it.uu.se> Date: Wed, 23 Nov 2011 15:46:39 +0100 From: Mikael Pettersson To: Mikael Pettersson Cc: Richard Henderson , gcc-patches@gcc.gnu.org, schwab@linux-m68k.org Subject: Re: [PATCH 0/2] Add atomic support to m68k In-Reply-To: <20167.41419.270316.923667@pilspetsen.it.uu.se> References: <1321643506-31962-1-git-send-email-rth@redhat.com> <20167.41419.270316.923667@pilspetsen.it.uu.se> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Mikael Pettersson writes: > Richard Henderson writes: > > The first patch adds support for the m68k-linux syscall. The second > > patch adds native support for the m680[2346]0 CAS instruction, and > > the m68000/Coldfire TAS instruction. > > > > Both tested only via cross-compile. > > > > Please test... > > Thanks Richard. I'm currently bootstrapping and regtesting this > "natively" on aranym. Bootstrapped fine and tested mostly OK. Seems to have eliminated all atomics-related regressions in 4.7-20111112. Compared to 4.7-20111105 I have the following test suite result changes: FAIL: gcc.c-torture/execute/ieee/compare-fp-1.c execution, -O0 FAIL: gcc.c-torture/execute/ieee/compare-fp-1.c execution, -O1 FAIL: gcc.c-torture/execute/ieee/compare-fp-1.c execution, -O2 @@ -194,6 +210,9 @@ FAIL: gcc.dg/pr46309.c scan-tree-dump-times reassoc1 "Optimizing range tests a_[0-9]*.D. -.128, 159. and -.192, 223.[ FAIL: gcc.dg/pr46309.c scan-tree-dump-times reassoc2 "Optimizing range tests D.[0-9]*_[0-9]* -.0, 31. and -.128, 159.[ FAIL: gcc.dg/pr46647.c scan-tree-dump-not optimized "memset" +FAIL: c-c++-common/gomp/atomic-10.c scan-tree-dump-times ompexp "__atomic_fetch_add" 4 +FAIL: c-c++-common/gomp/atomic-3.c scan-tree-dump-times ompexp "xyzzy, 4" 1 +FAIL: c-c++-common/gomp/atomic-9.c scan-tree-dump-times ompexp "__atomic_fetch_add" 1 XPASS: gcc.dg/guality/example.c -O0 execution test XPASS: gcc.dg/guality/example.c -O1 execution test WARNING: program timed out. @@ -462,18 +481,26 @@ === gcc Summary === -# of expected passes 60413 -# of unexpected failures 256 +# of expected passes 60718 +# of unexpected failures 261 # of unexpected successes 26 -# of expected failures 116 -# of unsupported tests 1072 -/mnt/scratch/objdir47/gcc/xgcc version 4.7.0 20111105 (experimental) (GCC) +# of expected failures 127 +# of unresolved testcases 2 +# of unsupported tests 1142 +/mnt/scratch/objdir47/gcc/xgcc version 4.7.0 20111112 (experimental) (GCC) === libgomp tests === Running target unix +FAIL: libgomp.c/atomic-10.c execution test +FAIL: libgomp.c/atomic-3.c execution test FAIL: libgomp.c/autopar-1.c execution test +FAIL: libgomp.c/pr26943-2.c execution test +FAIL: libgomp.c/pr26943-3.c execution test +FAIL: libgomp.c/pr26943-4.c execution test +FAIL: libgomp.c/reduction-2.c execution test +FAIL: libgomp.c/reduction-3.c execution test FAIL: libgomp.c++/for-1.C -O3 -fomit-frame-pointer -funroll-loops execution test FAIL: libgomp.c++/for-1.C -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions execution test FAIL: libgomp.c++/for-2.C -O3 -fomit-frame-pointer -funroll-loops execution test @@ -486,18 +513,19 @@ FAIL: libgomp.c++/for-5.C -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions execution test FAIL: libgomp.c++/for-8.C -O3 -fomit-frame-pointer -funroll-loops execution test FAIL: libgomp.c++/for-8.C -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions execution test +FAIL: libgomp.c++/reduction-2.C -O execution test +FAIL: libgomp.c++/reduction-3.C -O execution test === libgomp Summary === -# of expected passes 1214 -# of unexpected failures 13 +# of expected passes 1205 +# of unexpected failures 22 # of unsupported tests 8 === libstdc++ tests === Running target unix FAIL: 20_util/shared_ptr/thread/mutex_weaktoshared.cc execution test -WARNING: program timed out. FAIL: 22_locale/locale/cons/12658_thread-1.cc execution test FAIL: 22_locale/locale/cons/12658_thread-2.cc execution test FAIL: 23_containers/list/pthread1.cc execution test @@ -505,7 +533,7 @@ FAIL: 23_containers/map/pthread6.cc execution test FAIL: 26_numerics/complex/pow.cc execution test FAIL: 27_io/basic_ofstream/pthread2.cc execution test -FAIL: tr1/2_general_utilities/shared_ptr/thread/default_weaktoshared.cc execution test +FAIL: 27_io/basic_ostringstream/pthread3.cc execution test FAIL: tr1/2_general_utilities/shared_ptr/thread/mutex_weaktoshared.cc execution test FAIL: tr1/5_numerical_facilities/special_functions/12_ellint_1/check_nan.cc execution test FAIL: tr1/5_numerical_facilities/special_functions/13_ellint_2/check_nan.cc execution test @@ -513,15 +541,15 @@ === libstdc++ Summary === -# of expected passes 8323 +# of expected passes 8523 # of unexpected failures 13 -# of expected failures 46 -# of unsupported tests 249 +# of expected failures 45 +# of unsupported tests 160 --- mail-report-4.7-20111105-0 2011-11-09 21:31:02.000000000 +0100 +++ mail-report-4.7-20111112-with-atomics 2011-11-23 04:59:39.000000000 +0100 @@ -1,5 +1,5 @@ cat <<'EOF' | -LAST_UPDATED: Obtained from SVN: trunk revision 181017 +LAST_UPDATED: Obtained from SVN: trunk revision 181327 Native configuration is m68k-unknown-linux-gnu @@ -12,8 +12,20 @@ FAIL: tmpdir-g++.dg-struct-layout-1/t016 cp_compat_x_tst.o-cp_compat_y_tst.o execute FAIL: tmpdir-g++.dg-struct-layout-1/t025 cp_compat_x_tst.o-cp_compat_y_tst.o execute FAIL: tmpdir-g++.dg-struct-layout-1/t027 cp_compat_x_tst.o-cp_compat_y_tst.o execute -FAIL: g++.dg/cdce3.C scan-tree-dump cdce "cdce3.C:98: note: function call is shrink-wrapped into error conditions." -FAIL: g++.dg/cdce3.C scan-tree-dump cdce "cdce3.C:108: note: function call is shrink-wrapped into error conditions." +FAIL: g++.dg/cdce3.C -std=gnu++98 scan-tree-dump cdce "cdce3.C:98: note: function call is shrink-wrapped into error conditions." +FAIL: g++.dg/cdce3.C -std=gnu++98 scan-tree-dump cdce "cdce3.C:108: note: function call is shrink-wrapped into error conditions." +FAIL: g++.dg/cdce3.C -std=gnu++11 scan-tree-dump cdce "cdce3.C:98: note: function call is shrink-wrapped into error conditions." +FAIL: g++.dg/cdce3.C -std=gnu++11 scan-tree-dump cdce "cdce3.C:108: note: function call is shrink-wrapped into error conditions." +FAIL: g++.dg/opt/cfg3.C -std=gnu++98 (internal compiler error) +FAIL: g++.dg/opt/cfg3.C -std=gnu++98 (test for excess errors) +FAIL: g++.dg/opt/cfg3.C -std=gnu++11 (internal compiler error) +FAIL: g++.dg/opt/cfg3.C -std=gnu++11 (test for excess errors) +FAIL: c-c++-common/gomp/atomic-10.c -std=gnu++98 scan-tree-dump-times ompexp "__atomic_fetch_add" 4 +FAIL: c-c++-common/gomp/atomic-10.c -std=gnu++11 scan-tree-dump-times ompexp "__atomic_fetch_add" 4 +FAIL: c-c++-common/gomp/atomic-3.c -std=gnu++98 scan-tree-dump-times ompexp "xyzzy, 4" 1 +FAIL: c-c++-common/gomp/atomic-3.c -std=gnu++11 scan-tree-dump-times ompexp "xyzzy, 4" 1 +FAIL: c-c++-common/gomp/atomic-9.c -std=gnu++98 scan-tree-dump-times ompexp "__atomic_fetch_add" 1 +FAIL: c-c++-common/gomp/atomic-9.c -std=gnu++11 scan-tree-dump-times ompexp "__atomic_fetch_add" 1 FAIL: g++.dg/guality/redeclaration1.C -O0 line 17 i == 24 FAIL: g++.dg/guality/redeclaration1.C -O1 line 17 i == 24 FAIL: g++.dg/guality/redeclaration1.C -O2 line 17 i == 24 @@ -106,11 +118,11 @@ === g++ Summary === -# of expected passes 26073 -# of unexpected failures 96 -# of expected failures 151 -# of unsupported tests 413 -/mnt/scratch/objdir47/gcc/testsuite/g++/../../g++ version 4.7.0 20111105 (experimental) (GCC) +# of expected passes 43635 +# of unexpected failures 108 +# of expected failures 280 +# of unsupported tests 633 +/mnt/scratch/objdir47/gcc/testsuite/g++/../../g++ version 4.7.0 20111112 (experimental) (GCC) === gcc tests === @@ -150,6 +162,10 @@ FAIL: gcc.c-torture/execute/arith-rand-ll.c execution, -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions FAIL: gcc.c-torture/execute/arith-rand-ll.c execution, -O3 -g FAIL: gcc.c-torture/execute/arith-rand-ll.c execution, -Os +FAIL: gcc.c-torture/execute/stdarg-3.c compilation, -O3 -fomit-frame-pointer -funroll-loops (internal compiler error) +UNRESOLVED: gcc.c-torture/execute/stdarg-3.c execution, -O3 -fomit-frame-pointer -funroll-loops +FAIL: gcc.c-torture/execute/stdarg-3.c compilation, -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions (internal compiler error) +UNRESOLVED: gcc.c-torture/execute/stdarg-3.c execution, -O3 -fomit-frame-pointer -funroll-all-loops -finline-functions (Ignore this one, it's also in vanilla 4.7-20111112.)