diff mbox

S/390: Xfail some tests in insv-[12].c.

Message ID 20160719094017.GA22306@linux.vnet.ibm.com
State New
Headers show

Commit Message

Dominik Vogt July 19, 2016, 9:40 a.m. UTC 
The attached patch XFAILs some of the "insv" testcases as
discussed internally.  Tested on s390x biarch and s390.

Ciao

Dominik ^_^  ^_^

Comments

Andreas Krebbel July 20, 2016, 5:09 p.m. UTC | #1 
On 07/19/2016 11:40 AM, Dominik Vogt wrote:
> The attached patch XFAILs some of the "insv" testcases as
> discussed internally.  Tested on s390x biarch and s390.

Applied.  Thanks!

-Andreas-
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/s390/insv-1.c b/gcc/testsuite/gcc.target/s390/insv-1.c
index e6c1b8b..8d464f5 100644
--- a/gcc/testsuite/gcc.target/s390/insv-1.c
+++ b/gcc/testsuite/gcc.target/s390/insv-1.c
@@ -108,4 +108,11 @@  foo4c (unsigned long a, unsigned long b)
 #endif
 }
 
-/* { dg-final { scan-assembler-times "risbg" 6 } } */
+/* The functions foo3, foo4, foo3b, foo4b no longer use risbg but rosbg instead.
+
+   On s390x, four risbg go away and four new ones appear in other functions ...
+     { dg-final { scan-assembler-times "risbg" 6 { target { s390x-*-* } } } }
+
+   but not on s390.
+     { dg-final { scan-assembler-times "risbg" 2 { target { s390-*-* } } } }
+*/
diff --git a/gcc/testsuite/gcc.target/s390/insv-2.c b/gcc/testsuite/gcc.target/s390/insv-2.c
index 2ba6d6c..70af123 100644
--- a/gcc/testsuite/gcc.target/s390/insv-2.c
+++ b/gcc/testsuite/gcc.target/s390/insv-2.c
@@ -108,4 +108,17 @@  foo4c (unsigned long a, unsigned long b)
 #endif
 }
 
-/* { dg-final { scan-assembler-times "risbgn" 6 } } */
+/* The functions foo3, foo4, foo3b, foo4b no longer use risbgn but rosbg instead
+   which is slightly worse.  Combine prefers to use the simpler two insn
+   combinations possible with rosbg instead of the more complicated three insn
+   combinations that result in risbgn.  This problem has been introduced with
+   the commit
+
+     S/390: Add patterns for r<nox>sbg instructions.
+
+   (3rd of May, 2016).  This should be fixed some time in the future, but for
+   now just adapt the expected result:
+
+   { dg-final { scan-assembler-times "risbgn" 6 { xfail { *-*-* } } } }
+   { dg-final { scan-assembler-times "risbgn" 2 } }
+*/