From patchwork Wed Jan 27 16:11:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Enkovich X-Patchwork-Id: 574069 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 15D0B140BDE for ; Thu, 28 Jan 2016 03:12:27 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=YU7ymEBj; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=QChx5O4uxPMUO0qBc 6JdgQma94LXgI6inqGwXnbrqyXHuAR5L4xWex5jRy5/Q2zvORhfpLZlELKIoo2hu WG0Ik00MM9py+X5R8jdluiceY4xe1JOimgvBdVZBemitWSUrduEQ+nksG1TYsBSO FoJgPbOVUC2u0shger7Qr+wvmU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=HU440s0o5aESjaBUCwhr60w +OFI=; b=YU7ymEBj2RSPakOfhliTe//x7SluXlPhYf99eN8Ozz5dt/PaBwsrycx HBHBm7OFi0Rby3YKWzaJnAII395bih1r4cG0F7fa/+jzCFr2Q1xe3eMBJcS83CUJ CYB7yzaF8pCqDRtwmmDxflO21Q4z33anC/xDReYGUoqFxNQ/6B+c= Received: (qmail 5113 invoked by alias); 27 Jan 2016 16:12:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5098 invoked by uid 89); 27 Jan 2016 16:12:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=enkovich.gnu@gmail.com, enkovichgnugmailcom X-HELO: mail-wm0-f48.google.com Received: from mail-wm0-f48.google.com (HELO mail-wm0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 27 Jan 2016 16:12:17 +0000 Received: by mail-wm0-f48.google.com with SMTP id n5so33990614wmn.0 for ; Wed, 27 Jan 2016 08:12:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=tvZK3FAGW5nW3dg0yndJcnKoXDSIAGs8XhpcdJg8r1c=; b=YX+qBtLRtHvEh9Xt+uHxoX8iegsCMPA8AhntOBCcbHCYhvzENVpoNuRckw7hXW5Jl+ uLDawyssXA8c5/g+0HDmMFbI9l/vpHiwrd3E4/OxdrUfLqAn2R7NyNHj/hmLrwmEgbVM T47hr3FJ1mV1TnRISnc/25TmK4DzdRfVIwcB7kRPgESiOnisFFDp7szvODg3u1u2Ps4g 6PmzOUOgNYm73FurYLcO46yqaJQXtG8aEUPacD8byIixSVlGODJfSX4zlYOZkax0EtJy xQ5gto69lLBSFWRWI8imf6yK587XH10Ou5Nx9TgSwxwISH8IDZJxbT3yUvL66qhtxE7i CIYw== X-Gm-Message-State: AG10YOSIy31SIcqKpQsKfzKHHQwF+smzbAZZQe8LOUAf/uosoo57Rhbsl0WTsWgVCnIhFA== X-Received: by 10.28.229.20 with SMTP id c20mr29487417wmh.79.1453911134451; Wed, 27 Jan 2016 08:12:14 -0800 (PST) Received: from msticlxl57.ims.intel.com (irdmzpr01-ext.ir.intel.com. [192.198.151.36]) by smtp.gmail.com with ESMTPSA id 79sm8368017wmo.7.2016.01.27.08.12.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jan 2016 08:12:13 -0800 (PST) Date: Wed, 27 Jan 2016 19:11:37 +0300 From: Ilya Enkovich To: Jakub Jelinek Cc: Uros Bizjak , gcc-patches@gcc.gnu.org Subject: Re: [PATCH, PR target/69454] Disable TARGET_STV when stack is not properly aligned Message-ID: <20160127161137.GB16081@msticlxl57.ims.intel.com> References: <20160127153441.GA16081@msticlxl57.ims.intel.com> <20160127154448.GQ3017@tucnak.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160127154448.GQ3017@tucnak.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes On 27 Jan 16:44, Jakub Jelinek wrote: > On Wed, Jan 27, 2016 at 06:34:41PM +0300, Ilya Enkovich wrote: > > @@ -5453,6 +5443,11 @@ ix86_option_override_internal (bool main_args_p, > > opts->x_target_flags |= MASK_VZEROUPPER; > > if (!(opts_set->x_target_flags & MASK_STV)) > > opts->x_target_flags |= MASK_STV; > > + /* Disable STV if -mpreferred-stack-boundary={2,3} - the needed > > The comment doesn't match the code, you disable STV only for > -mpreferred-stack-boundary=2. Thanks, here is an updated version. Ilya --- gcc/ 2016-01-27 Jakub Jelinek Ilya Enkovich PR target/69454 * config/i386/i386.c (convert_scalars_to_vector): Remove stack alignment fixes. (ix86_option_override_internal): Disable TARGET_STV if stack is not properly aligned. gcc/testsuite/ 2016-01-27 Ilya Enkovich PR target/69454 * gcc.target/i386/pr69454-1.c: New test. * gcc.target/i386/pr69454-2.c: New test. diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 34b57a4..9fb8db8 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -3588,16 +3588,6 @@ convert_scalars_to_vector () bitmap_obstack_release (NULL); df_process_deferred_rescans (); - /* Conversion means we may have 128bit register spills/fills - which require aligned stack. */ - if (converted_insns) - { - if (crtl->stack_alignment_needed < 128) - crtl->stack_alignment_needed = 128; - if (crtl->stack_alignment_estimated < 128) - crtl->stack_alignment_estimated = 128; - } - return 0; } @@ -5453,6 +5443,11 @@ ix86_option_override_internal (bool main_args_p, opts->x_target_flags |= MASK_VZEROUPPER; if (!(opts_set->x_target_flags & MASK_STV)) opts->x_target_flags |= MASK_STV; + /* Disable STV if -mpreferred-stack-boundary=2 - the needed + stack realignment will be extra cost the pass doesn't take into + account and the pass can't realign the stack. */ + if (ix86_preferred_stack_boundary < 64) + opts->x_target_flags &= ~MASK_STV; if (!ix86_tune_features[X86_TUNE_AVX256_UNALIGNED_LOAD_OPTIMAL] && !(opts_set->x_target_flags & MASK_AVX256_SPLIT_UNALIGNED_LOAD)) opts->x_target_flags |= MASK_AVX256_SPLIT_UNALIGNED_LOAD; diff --git a/gcc/testsuite/gcc.target/i386/pr69454-1.c b/gcc/testsuite/gcc.target/i386/pr69454-1.c new file mode 100644 index 0000000..12ecfd3 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr69454-1.c @@ -0,0 +1,11 @@ +/* { dg-do compile { target { ia32 } } } */ +/* { dg-options "-O2 -msse2 -mno-accumulate-outgoing-args -mpreferred-stack-boundary=2" } */ + +typedef struct { long long w64[2]; } V128; +extern V128* fn2(void); +long long a; +V128 b; +void fn1() { + V128 *c = fn2(); + c->w64[0] = a ^ b.w64[0]; +} diff --git a/gcc/testsuite/gcc.target/i386/pr69454-2.c b/gcc/testsuite/gcc.target/i386/pr69454-2.c new file mode 100644 index 0000000..28bab93 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr69454-2.c @@ -0,0 +1,13 @@ +/* { dg-do compile { target { ia32 } } } */ +/* { dg-options "-O2 -mpreferred-stack-boundary=2" } */ + +extern void fn2 (); +long long a, b; + +void fn1 () +{ + long long c = a; + a = b ^ a; + fn2 (); + a = c; +}