| Message ID | 20151102120611.167de789@octopus |
|---|---|
| State | New |
| Headers | show |
On 02/11/15 12:06, Julian Brown wrote: > Hi, > > On Thu, 29 Oct 2015 10:23:58 -0700 > Jim Wilson <jim.wilson@linaro.org> wrote: > >> I noticed a comment typo in this file while using grep to look for >> other stuff. The typo is easy to fix. >> >> I tried running neon-testgen.ml to verify, but it is apparently no >> longer valid ocaml, as it doesn't work with the ocamlc 4.01.0 I have >> on Ubuntu 14.04. I get a syntax error. Someone who knows ocaml will >> have to fix this. Meanwhile, the patch to fix the typo should still >> be OK, as this is a separate problem. > This seems to work for me (semicolons in OCaml are separators not > terminators - I'm not sure why this worked before). OK to apply? Ok. Thanks, Kyrill > Julian > > ChangeLog > > gcc/ > * config/arm/neon-testgen.ml (emit_epilogue): Remove extraneous > brackets and semicolon.
Index: gcc/config/arm/neon-testgen.ml =================================================================== --- gcc/config/arm/neon-testgen.ml (revision 229410) +++ gcc/config/arm/neon-testgen.ml (working copy) @@ -130,14 +130,14 @@ let emit_call chan const_valuator c_type let emit_epilogue chan features regexps = let no_op = List.exists (fun feature -> feature = No_op) features in Printf.fprintf chan "}\n\n"; - (if not no_op then - List.iter (fun regexp -> - Printf.fprintf chan - "/* { dg-final { scan-assembler \"%s\" } } */\n" regexp) + if not no_op then + List.iter (fun regexp -> + Printf.fprintf chan + "/* { dg-final { scan-assembler \"%s\" } } */\n" regexp) regexps - else - () - ); + else + () + (* Check a list of C types to determine which ones are pointers and which ones are const. *)