diff mbox

gcc: fix building w/isl-0.15

Message ID 20150721203253.GA21822@f1.c.bardezibar.internal
State New
Headers show

Commit Message

Sebastian Pop July 21, 2015, 8:32 p.m. UTC 
Jeff Law wrote:
> On 07/14/2015 08:45 AM, Mike Frysinger wrote:
> >---
> >  gcc/config.in               |  6 ++++++
> >  gcc/configure               | 31 +++++++++++++++++++++++++++++++
> >  gcc/configure.ac            | 14 ++++++++++++++
> >  gcc/graphite-dependences.c  | 14 +++++++-------
> >  gcc/graphite-optimize-isl.c |  8 ++++++--
> >  gcc/graphite-poly.h         |  5 +++++
> >  6 files changed, 69 insertions(+), 9 deletions(-)
> Thanks.  I needed Bernhard's follow-up to get a successful build
> with isl-0.15 installed.
> 
> For testing I verified there were no regressions using bootstrapped
> compilers built with isl-0.13 vs isl-0.15.  I also verified that GCC
> would bootstrap with the patch installed, but no ISL installed.
> 
> I've installed both patches on the trunk.

Thanks Jeff.

Could somebody with access to sourceware.org upload a tar.bz2 of the required
version of isl from http://isl.gforge.inria.fr/isl-0.15.tar.bz2?

Also, once that is done, I will commit the following patch updating the
documentation.

Thanks,
Sebastian

From 189565d5f0cdcb54aac309316316456b88957ef6 Mon Sep 17 00:00:00 2001
From: Sebastian Pop <sebpop@gmail.com>
Date: Tue, 21 Jul 2015 20:26:36 +0000
Subject: [PATCH] update doc for required isl version

---
 gcc/doc/install.texi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mike Stump July 21, 2015, 8:57 p.m. UTC | #1 
On Jul 21, 2015, at 1:32 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> 
> Thanks Jeff.
> 
> Could somebody with access to sourceware.org upload a tar.bz2 of the required
> version of isl from http://isl.gforge.inria.fr/isl-0.15.tar.bz2?
> 
> Also, once that is done, I will commit the following patch updating the
> documentation.

Hold on.  Is something wrong with isl-0.14?  If not, then we should leave the minimum version alone (though, updating the recommended version is fine).  Most of the other packages list “or later” to denote that later packages work (or are expected to work).

If we do need to update to isl 0.15 for the trunk, I’d request that any patches that are needed for the gcc-5 release branch to work with isl 0.15 to work be applied to the 5 release branch first, before we update the iso version.

> -@item ISL Library version 0.14 (or 0.12.2)
> +@item ISL Library version 0.15
Jeff Law July 23, 2015, 5:59 p.m. UTC | #2 
On 07/21/2015 02:32 PM, Sebastian Pop wrote:
>
> Could somebody with access to sourceware.org upload a tar.bz2 of the required
> version of isl from http://isl.gforge.inria.fr/isl-0.15.tar.bz2?
>
> Also, once that is done, I will commit the following patch updating the
> documentation.
I've put isl-0.15.tar.bz2 into the ftp directory.

However, I don't think we've changed the required version of ISL for 
gcc.  If we were changing the required version, then I wouldn't have 
bothered to verify that the trunk still works with 0.13 (and the patch 
itself would have been simpler).

What I think we've done is merely allow the use of a newer ISL, possibly 
changing the recommended version, but not the base required version.

Jeff
diff mbox

Patch

diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 212008a..192ca91 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -383,11 +383,11 @@  installed but it is not in your default library search path, the
 @option{--with-mpc} configure option should be used.  See also
 @option{--with-mpc-lib} and @option{--with-mpc-include}.
 
-@item ISL Library version 0.14 (or 0.12.2)
+@item ISL Library version 0.15
 
 Necessary to build GCC with the Graphite loop optimizations.
 It can be downloaded from @uref{ftp://gcc.gnu.org/pub/gcc/infrastructure/}
-as @file{isl-0.12.2.tar.bz2}.  If an ISL source distribution is found
+as @file{isl-0.15.tar.bz2}.  If an ISL source distribution is found
 in a subdirectory of your GCC sources named @file{isl}, it will be
 built together with GCC.  Alternatively, the @option{--with-isl} configure
 option should be used if ISL is not installed in your default library