From patchwork Fri May 15 14:55:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Kargl X-Patchwork-Id: 472826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 108AC1409BB for ; Sat, 16 May 2015 00:55:28 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=mcdyFvLZ; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; q=dns; s= default; b=Wsu6d1CGavdrdtlPmeKHih2EmpVo9SIt04zSQkKDPKwXGLRiNs0zw pDWxJI5R1c63qj7yIWWDm3jscQmDipSXuMjES7GK1u7e8X7CqcchNUUEXMBllZ6S Z1F7fRjpT6UwNuT1ryiFaMEIoPp0sm8Tst+nQ/Kg33b3QZPhmCRZPI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:mime-version:content-type; s= default; bh=6QAxCZjh4xMMqJG1BVqqae0IaNU=; b=mcdyFvLZmzgkvsxwc4tb d+p0yVmaI4KqCfxN8WLyH4tCYhlvjaAYF3TB2Nj58AlOdF/MoavJ3q8an8XLlMTf zawPxu4fqIFdmTANh9mPiQm2DBEgjlS95yCCLhaJNjtuf+SEonOmIzoMa/vZw9Pq UT1K3c9j/9ABowQ4jxDPMwA= Received: (qmail 127786 invoked by alias); 15 May 2015 14:55:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 127763 invoked by uid 89); 15 May 2015 14:55:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.2 required=5.0 tests=AWL, BAYES_50, KAM_ASCII_DIVIDERS, KAM_LAZY_DOMAIN_SECURITY, T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: troutmask.apl.washington.edu Received: from troutmask.apl.washington.edu (HELO troutmask.apl.washington.edu) (128.95.76.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 May 2015 14:55:14 +0000 Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.14.9/8.14.9) with ESMTP id t4FEtCFU082793 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 15 May 2015 07:55:12 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.9/8.14.9/Submit) id t4FEtCjV082792; Fri, 15 May 2015 07:55:12 -0700 (PDT) (envelope-from sgk) Date: Fri, 15 May 2015 07:55:12 -0700 From: Steve Kargl To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [PATCH] fortran/66039 -- Check for mangled file positioning Message-ID: <20150515145512.GB82729@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) The attached patch checks for mangled/incomplete file positioning statements. Regression tested on trunk with no new failures? OK to commit 2015-05-XX Steven G. Kargl PR fortran/66039 * io.c (match_filepos): Check for incomplete/mangled REWIND, FLUSH, BACKSPACE, and ENDFILE statements 2015-05-XX Steven G. Kargl PR fortran/66039 * gfortran.dg/filepos1.f90: New test Index: gcc/fortran/io.c =================================================================== --- gcc/fortran/io.c (revision 223094) +++ gcc/fortran/io.c (working copy) @@ -2382,9 +2382,7 @@ match_filepos (gfc_statement st, gfc_exe if (m == MATCH_NO) { m = gfc_match_expr (&fp->unit); - if (m == MATCH_ERROR) - goto done; - if (m == MATCH_NO) + if (m == MATCH_ERROR || m == MATCH_NO) goto syntax; } Index: gcc/testsuite/gfortran.dg/filepos1.f90 =================================================================== --- gcc/testsuite/gfortran.dg/filepos1.f90 (revision 0) +++ gcc/testsuite/gfortran.dg/filepos1.f90 (working copy) @@ -0,0 +1,25 @@ +! { dg-do compile } +! PR fortran/66039 +! +! Original code from Gerhard Steinmetz +! +subroutine p1 + rewind (( ! { dg-error "Syntax error in REWIND" } + rewind (- ! { dg-error "Syntax error in REWIND" } +end subroutine p1 + +subroutine p2 + flush (( ! { dg-error "Syntax error in FLUSH" } + flush (- ! { dg-error "Syntax error in FLUSH" } +end subroutine p2 + +subroutine p4 + backspace (( ! { dg-error "Syntax error in BACKSPACE" } + backspace (- ! { dg-error "Syntax error in BACKSPACE" } +end subroutine p4 + +subroutine p3 + endfile (( ! { dg-error "Expecting END SUBROUTINE" } + endfile (- ! { dg-error "Expecting END SUBROUTINE" } +end subroutine p3 +