From patchwork Sat Sep 27 15:35:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andi Kleen X-Patchwork-Id: 394070 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DBB4140139 for ; Sun, 28 Sep 2014 01:36:01 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=dk3T3LEUv7/ZbULvH /6rrYpBc5eq7SzB1QW1q3S05yUP76WMff8ORm4ztMM9ONPf6EbaV4p2VEvFRQyqN qzgWR8hfiHW+h2Upbirr0cV4/O0M9UGynO/ev/n4f6Uj96tR+pR6ssPvH8QHP/Ui SOlYboLQfxRp9P8Mww01G7uHdU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=zp4LSA7FJrdKuyeG8Fe9zzg 3mTw=; b=RwaWqAFWgpUVC0iuTMCf27+4r6VQJ0qUOa//tU+GHfjTbxMp0sEBdwg 1lnhdwVDaKpagsDSVR0r27Q6TsJMTUOuRrVisk8NJ18BfvITwNN8pscZRPw27YvR DJUvEuGZJQ0CmtDV1fqaLPt9udDJQ0lFWTtTabPttVT9ar1jFS7U= Received: (qmail 10407 invoked by alias); 27 Sep 2014 15:35:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10396 invoked by uid 89); 27 Sep 2014 15:35:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: one.firstfloor.org Received: from one.firstfloor.org (HELO one.firstfloor.org) (193.170.194.197) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 27 Sep 2014 15:35:52 +0000 Received: by one.firstfloor.org (Postfix, from userid 503) id 02D58869A8; Sat, 27 Sep 2014 17:35:48 +0200 (CEST) Date: Sat, 27 Sep 2014 17:35:47 +0200 From: Andi Kleen To: Dominique Dhumieres Cc: andi@firstfloor.org, law@redhat.com, gcc-patches@gcc.gnu.org Subject: Re: [PING] [PATCH] Add direct support for Linux kernel __fentry__ patching Message-ID: <20140927153547.GH2905@two.firstfloor.org> References: <20140927112129.D8A9D100@mailhost.lps.ens.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140927112129.D8A9D100@mailhost.lps.ens.fr> User-Agent: Mutt/1.5.20 (2009-06-14) On Sat, Sep 27, 2014 at 01:21:29PM +0200, Dominique Dhumieres wrote: > The new tests fail on darwin: > > /opt/gcc/work/gcc/testsuite/gcc.target/i386/nop-mcount.c:1:0: error: -mnop-mcount is not implemented for -fPIC > > and gcc.target/i386/record-mcount.c fails because mcount_loc is not found in the assembly. Sorry. Here's a patch. I'll install it as obvious unless someone complains. Also I hope it's the last mcount patch for now :-) -Andi diff --git a/gcc/testsuite/gcc.target/i386/nop-mcount.c b/gcc/testsuite/gcc.target/i386/nop-mcount.c index 2592231..942cae0 100644 --- a/gcc/testsuite/gcc.target/i386/nop-mcount.c +++ b/gcc/testsuite/gcc.target/i386/nop-mcount.c @@ -1,5 +1,5 @@ /* Test -mnop-mcount */ -/* { dg-do compile } */ +/* { dg-do compile { target *-*-linux* } } */ /* { dg-options "-pg -mfentry -mrecord-mcount -mnop-mcount" } */ /* { dg-final { scan-assembler-not "__fentry__" } } */ /* Origin: Andi Kleen */ diff --git a/gcc/testsuite/gcc.target/i386/record-mcount.c b/gcc/testsuite/gcc.target/i386/record-mcount.c index dae413e..26b0dbc 100644 --- a/gcc/testsuite/gcc.target/i386/record-mcount.c +++ b/gcc/testsuite/gcc.target/i386/record-mcount.c @@ -1,5 +1,5 @@ /* Test -mrecord-mcount */ -/* { dg-do compile } */ +/* { dg-do compile { target *-*-linux* } } */ /* { dg-options "-pg -mrecord-mcount" } */ /* { dg-final { scan-assembler "mcount_loc" } } */ /* Origin: Andi Kleen */