diff mbox

[testsuite] PR61453 gfortran.dg/bind_c_array_params_2.f90 for targets where a call insn isn't "call"

Message ID 20140708153603.51C1C105@mailhost.lps.ens.fr
State New
Headers show

Commit Message

Dominique d'Humières July 8, 2014, 3:36 p.m. UTC 
> I just checked.  It doesn't work on hppa64-hp-hpux11.11 due to following
> statement:
>
>          .type   myBindC, @function

So can we settle for


? If yes, could someone give me the "green light". The patch will fix the failures 
for the targets it has been tested.

TIA

Dominique

Comments

John David Anglin July 8, 2014, 6:10 p.m. UTC | #1 
On 7/8/2014 11:36 AM, Dominique Dhumieres wrote:
> So can we settle for
>
> --- ../_clean/gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90	2014-05-24 16:17:53.000000000 +0200
> +++ gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90	2014-07-07 19:15:47.000000000 +0200
> @@ -16,7 +16,7 @@ integer :: aa(4,4)
>   call test(aa)
>   end
>   
> -! { dg-final { scan-assembler-times "call\[^\n\r\]*myBindC" 1 { target { ! { hppa*-*-hpux* } } } } }
> -! { dg-final { scan-assembler-times "call\[^\n\r\]*myBindC,%r2" 1 { target { hppa*-*-hpux* } } } }
> +! { dg-final { scan-assembler-times "\[ \t\]\[$,_0-9\]*myBindC" 1 { target { ! { hppa*-*-hpux* } } } } }
> +! { dg-final { scan-assembler-times "myBindC,%r2" 1 { target { hppa*-*-hpux* } } } }
>   ! { dg-final { scan-tree-dump-times "test \\\(&parm\\." 1 "original" } }
>   ! { dg-final { cleanup-tree-dump "original" } }
As mentioned before, I would prefer that you change "hppa*-*-hpux*" to 
"hppa*-*-*".

Dave
Dominique d'Humières July 8, 2014, 9:07 p.m. UTC | #2 
> As mentioned before, I would prefer that you change "hppa*-*-hpux*" to
> "hppa*-*-*".

Done in my tree so I won't forget. Now someone has to approve the patch!

Dominique
Mike Stump July 9, 2014, 12:40 a.m. UTC | #3 
On Jul 8, 2014, at 2:07 PM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>> As mentioned before, I would prefer that you change "hppa*-*-hpux*" to
>> "hppa*-*-*".
> 
> Done in my tree so I won't forget. Now someone has to approve the patch!

Ok.

:-)  I usually just expect people to check in such minor stuff once the discussion dies down and all the good feedback is incorporated.
Dominique d'Humières July 9, 2014, 5:37 p.m. UTC | #4 
> Ok.
>
> :-)  I usually just expect people to check in such minor stuff once the discussion dies down
> and all the good feedback is incorporated.

Thanks for the tip. I am still learning the rules.

Cheers,

Dominique
diff mbox

Patch

--- ../_clean/gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90	2014-05-24 16:17:53.000000000 +0200
+++ gcc/testsuite/gfortran.dg/bind_c_array_params_2.f90	2014-07-07 19:15:47.000000000 +0200
@@ -16,7 +16,7 @@  integer :: aa(4,4)
 call test(aa)
 end
 
-! { dg-final { scan-assembler-times "call\[^\n\r\]*myBindC" 1 { target { ! { hppa*-*-hpux* } } } } }
-! { dg-final { scan-assembler-times "call\[^\n\r\]*myBindC,%r2" 1 { target { hppa*-*-hpux* } } } }
+! { dg-final { scan-assembler-times "\[ \t\]\[$,_0-9\]*myBindC" 1 { target { ! { hppa*-*-hpux* } } } } }
+! { dg-final { scan-assembler-times "myBindC,%r2" 1 { target { hppa*-*-hpux* } } } }
 ! { dg-final { scan-tree-dump-times "test \\\(&parm\\." 1 "original" } }
 ! { dg-final { cleanup-tree-dump "original" } }