diff mbox

[i386,AVX-512] Fix conditions for 2 patterns.

Message ID 20140110100754.GA63041@msticlxl57.ims.intel.com
State New
Headers show

Commit Message

Kirill Yukhin Jan. 10, 2014, 10:07 a.m. UTC 
Hello,
We've [at least] 2 patterns with wrong conditions.

Bootstrapped.

AVX-512 testsuite more complicated.
Few tests are fail, and it seems that not because of
the patch. I am trying to find guilty commit.

Failing this tests: avx512f-vpmovsxbd-2.c and
other *-extension insns.

gcc/
	* config/i386/sse.md (avx512f_maskcmp<mode>3): Fix condition.
	(avx512f_cvtdq2pd512_2): Ditto.

Ok to install?

--
Thanks, K

---
 gcc/config/i386/sse.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kirill Yukhin Jan. 10, 2014, 11:19 a.m. UTC | #1 
On 10 Jan 13:07, Kirill Yukhin wrote:
> Few tests are fail, and it seems that not because of
> the patch. I am trying to find guilty commit.
I filed PR59754 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59754)

--
Thanks, K
Uros Bizjak Jan. 10, 2014, 11:20 a.m. UTC | #2 
On Fri, Jan 10, 2014 at 11:07 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello,
> We've [at least] 2 patterns with wrong conditions.
>
> Bootstrapped.
>
> AVX-512 testsuite more complicated.
> Few tests are fail, and it seems that not because of
> the patch. I am trying to find guilty commit.
>
> Failing this tests: avx512f-vpmovsxbd-2.c and
> other *-extension insns.
>
> gcc/
>         * config/i386/sse.md (avx512f_maskcmp<mode>3): Fix condition.
>         (avx512f_cvtdq2pd512_2): Ditto.
>
> Ok to install?

OK.

Thanks,
Uros.
diff mbox

Patch

diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md
index dfc98ba..59e82cb 100644
--- a/gcc/config/i386/sse.md
+++ b/gcc/config/i386/sse.md
@@ -2234,7 +2234,7 @@ 
        (match_operator:<avx512fmaskmode> 3 "sse_comparison_operator"
          [(match_operand:VF 1 "register_operand" "v")
           (match_operand:VF 2 "nonimmediate_operand" "vm")]))]
-  "TARGET_SSE"
+  "TARGET_AVX512F"
   "vcmp%D3<ssemodesuffix>\t{%2, %1, %0|%0, %1, %2}"
   [(set_attr "type" "ssecmp")
    (set_attr "length_immediate" "1")
@@ -3937,7 +3937,7 @@ 
                       (const_int 2) (const_int 3)
                       (const_int 4) (const_int 5)
                       (const_int 6) (const_int 7)]))))]
-  "TARGET_AVX"
+  "TARGET_AVX512F"
   "vcvtdq2pd\t{%t1, %0|%0, %t1}"
   [(set_attr "type" "ssecvt")
    (set_attr "prefix" "evex")