From patchwork Thu Sep 19 15:38:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 275980 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id EBFED2C00C5 for ; Fri, 20 Sep 2013 01:38:31 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=lz9t/y9sbz6+/67cG ZEo6aFx8r6NXubDFAytCMlAeLV6O8+CobqW8Cevl2VwWYWLkgiBe+nOEI4UEwUb4 GaTidJDPD83fFBVCosOXaMp5f2b/YOGng7+GtmMajJMdIDpJX4I2YbA1G6+o4IpP dWFYg++6fjwId1C9y0lM2dLIh8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=EyHhrPcAXw3vbbPWwF7DUxq +MZk=; b=t6UqmDU9wTxzSdfMjcnts2tlJ3jEOr0AaU9u6SBfUpb5ivPpNCybqj/ KzRbJioIbRjh5VwGOEeWkCh3b6g4GNlq/vHs8CZ4tm8jLbrDPCvquf4qgBr+7uN7 INroRBgemCqd7Q+AQONragCiHWv+7+vrrVM1+7fBpYwAMPNFOsDc= Received: (qmail 2383 invoked by alias); 19 Sep 2013 15:38:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2369 invoked by uid 89); 19 Sep 2013 15:38:25 -0000 Received: from atrey.karlin.mff.cuni.cz (HELO atrey.karlin.mff.cuni.cz) (195.113.26.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Sep 2013 15:38:25 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, NO_RELAYS autolearn=ham version=3.3.2 X-HELO: atrey.karlin.mff.cuni.cz Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 4018) id 81C27816A4; Thu, 19 Sep 2013 17:38:22 +0200 (CEST) Date: Thu, 19 Sep 2013 17:38:22 +0200 From: Jan Hubicka To: Ian Lance Taylor Cc: Jan Hubicka , gcc-patches , Michael Matz , "H.J. Lu" Subject: Re: Drop generic32 cost model Message-ID: <20130919153822.GB8296@atrey.karlin.mff.cuni.cz> References: <20130918203949.GB11466@kam.mff.cuni.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes > > > decide_alg is being called from ix86_expand_movmem, from > expand_builtin_memcpy, for the call at line 61 of go-append.c. > __builtin_memcpy (n, a.__values, a.__count * element_size); > > I'm continuing to look. Indeed it is problem of this patch - the issue is that generic64 had dummy 32bit alg entries (those should not cause infinite loop, I will fix that too) I am testing: > > Ian Index: i386.c =================================================================== --- i386.c (revision 202741) +++ i386.c (working copy) @@ -1648,11 +1648,13 @@ struct processor_costs slm_cost = { and btver1 (and newer chips). */ static stringop_algs generic_memcpy[2] = { - DUMMY_STRINGOP_ALGS, + {libcall, {{32, loop, false}, {8192, rep_prefix_4_byte, false}, + {-1, libcall, false}}}, {libcall, {{32, loop, false}, {8192, rep_prefix_8_byte, false}, {-1, libcall, false}}}}; static stringop_algs generic_memset[2] = { - DUMMY_STRINGOP_ALGS, + {libcall, {{32, loop, false}, {8192, rep_prefix_4_byte, false}, + {-1, libcall, false}}}, {libcall, {{32, loop, false}, {8192, rep_prefix_8_byte, false}, {-1, libcall, false}}}}; static const