From patchwork Fri Aug 30 14:26:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joern Rennecke X-Patchwork-Id: 271300 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "www.sourceware.org", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 6E6A92C0085 for ; Sat, 31 Aug 2013 00:26:10 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=b/4UwrdkpolNdECh xEH3iGqkviA5xQhbk0fIBiO1fCefwOscVfOjzlknpcfcVADPt31gZYA3Vap84shK sgScmuP8aK2czPrr+835Lsc+jmTZzgxd8FGABoqOA+giRdorxSg4mUqQdFVt2V0C +DQr54ES3QxMMvKfYfnlNFZNVYw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding; s=default; bh=sWGLblyH7Z6wjvYZMm/U5E ZZ6ng=; b=mchtxJGXcAvRNpNL2lR22AujV/9LPnfZOIlOaIs/wCDByVtZr6o1hA HbZy77KKd1jbOUqaySCsS+2l8pDn3yCe6d+sI+MXaYoAx7hTacENpT9r6En9j1m9 ilqRri5pFmobZr/DH9m4JqXU5EGntpK0A3XUv+MwftJBtZ4YrPahM= Received: (qmail 32200 invoked by alias); 30 Aug 2013 14:26:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 32188 invoked by uid 89); 30 Aug 2013 14:26:03 -0000 Received: from c62.cesmail.net (HELO c62.cesmail.net) (216.154.195.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Aug 2013 14:26:03 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, FSL_HELO_NON_FQDN_1, RDNS_NONE autolearn=no version=3.3.2 X-HELO: c62.cesmail.net Received: from unknown (HELO delta2) ([192.168.1.50]) by c62.cesmail.net with ESMTP; 30 Aug 2013 10:26:01 -0400 Received: from cust213-dsl91-135-11.idnet.net (cust213-dsl91-135-11.idnet.net [91.135.11.213]) by webmail.spamcop.net (Horde MIME library) with HTTP; Fri, 30 Aug 2013 10:26:01 -0400 Message-ID: <20130830102601.rbgh6p005k4004cg-nzlynne@webmail.spamcop.net> Date: Fri, 30 Aug 2013 10:26:01 -0400 From: Joern Rennecke To: gcc-patches@gcc.gnu.org Subject: Committed: avoid null-pointer dereference in verify_changes MIME-Version: 1.0 User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) I got nine ICEs in verify_changes for compile/20110401-1.c on ARC. Fixed by checking changes[i].old before dereferencing it. Bootstrapped on i686-pc-linux.gnu. Committed as obvious. 2013-05-20 Joern Rennecke * recog.c (verify_changes): Verify that changes[i].old is non-zero before applying REG_P. Index: recog.c =================================================================== --- recog.c (revision 202106) +++ recog.c (working copy) @@ -397,7 +397,10 @@ verify_changes (int num) MEM_ADDR_SPACE (object))) break; } - else if (REG_P (changes[i].old) + else if (/* changes[i].old might be zero, e.g. when putting a + REG_FRAME_RELATED_EXPR into a previously empty list. */ + changes[i].old + && REG_P (changes[i].old) && asm_noperands (PATTERN (object)) > 0 && REG_EXPR (changes[i].old) != NULL_TREE && DECL_ASSEMBLER_NAME_SET_P (REG_EXPR (changes[i].old))