From patchwork Sun Jun 9 10:46:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Dominique_d=27Humi=C3=A8res?= X-Patchwork-Id: 250024 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id E4D3E2C02C3 for ; Sun, 9 Jun 2013 20:46:43 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :to:cc:subject:mime-version:content-type :content-transfer-encoding:message-id:from; q=dns; s=default; b= jv/j0E4hK6Cw4NvyAu4zhjRm/Ezgx13/vsUwlQj6J8LY1PXaYmWtl2smo75oOiEt q46KPEoBi8qCmasVeEwZBeK2y2cnShXd4ZLnKWRtb7h9fcvOVeLdgthuEppMGgof uepKhrjdrsn0aMPkZGU1EsVmjRyjbSgWUELR8SQPGFU= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :to:cc:subject:mime-version:content-type :content-transfer-encoding:message-id:from; s=default; bh=/csiCB F7l+AQR6Vp2HYEM7qYeyw=; b=ew9X3J1Jpr7IrxKBz96Ia30XXm/NvCWmxUBQgP HiZPtHqiyBwbdWsU+3EYagP5slCkIzCYK+/y49qiTXIOV2H+F/cIwuhEcuWMs1dA mc44hy/6RlgSQG/1704sHXcdceaC2DoHeuTNS8vMf+8iu+66sBc/uqVwTLgZFygy U5jMs= Received: (qmail 9592 invoked by alias); 9 Jun 2013 10:46:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9546 invoked by uid 89); 9 Jun 2013 10:46:25 -0000 X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD autolearn=ham version=3.3.1 X-Spam-User: qpsmtpd, 2 recipients Received: from nef2.ens.fr (HELO nef2.ens.fr) (129.199.96.40) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Sun, 09 Jun 2013 10:46:24 +0000 Received: from mailhost.lps.ens.fr (tournesol.lps.ens.fr [129.199.120.1]) by nef2.ens.fr (8.13.6/1.01.28121999) with ESMTP id r59AkKRR013274 ; Sun, 9 Jun 2013 12:46:21 +0200 (CEST) X-Envelope-To: gcc-patches@gcc.gnu.org Received: from localhost (localhost [127.0.0.1]) by mailhost.lps.ens.fr (Postfix) with ESMTP id BBDC03BAB9; Sun, 9 Jun 2013 12:46:20 +0200 (CEST) Received: from mailhost.lps.ens.fr ([127.0.0.1]) by localhost (tournesol.lps.ens.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YIjBGi31hQXE; Sun, 9 Jun 2013 12:46:20 +0200 (CEST) Received: by mailhost.lps.ens.fr (Postfix, from userid 8513) id A97DF3BE1B; Sun, 9 Jun 2013 12:46:20 +0200 (CEST) Date: Sun, 09 Jun 2013 12:46:20 +0200 To: fortran@gcc.gnu.org Cc: gcc-patches@gcc.gnu.org, hjl.tools@gmail.com, mikael.morin@sfr.fr, burnus@net-b.de Subject: Re: *PING* / Re: [Patch, Fortran] Finalize nonallocatables with INTENT(out) User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Message-Id: <20130609104620.A97DF3BE1B@mailhost.lps.ens.fr> From: dominiq@lps.ens.fr (Dominique Dhumieres) Dear Tobias, The test gfortran.dg/finalize_10.f90 fails in 32 bit mode (see http://gcc.gnu.org/ml/gcc-testresults/2013-06/msg00842.html FAIL: gfortran.dg/finalize_10.f90 -O scan-tree-dump-times original "__builtin_memcpy \\\\(\\\\(void .\\\\) y->_data, \\\\(void .\\\\) y->_vptr->_def_init, \\\\(unsigned long\\\\) y->_vptr->_size\\\\);" 1) because "unsigned long" is replaced with "unsigned int". The following patch fixes it I have tried to weaken the test by not using any target and using a regexp of the kind "(int|long)", but I did not succeeded. CAVEAT: I don't know if the targets work for x32. TIA Dominique --- ../_clean/gcc/testsuite/gfortran.dg/finalize_10.f90 2013-06-08 21:50:32.000000000 +0200 +++ gcc/testsuite/gfortran.dg/finalize_10.f90 2013-06-09 11:33:12.000000000 +0200 @@ -26,7 +26,8 @@ end subroutine foo ! Finalize CLASS + set default init ! { dg-final { scan-tree-dump-times "y->_vptr->_final \\(&desc.\[0-9\]+, y->_vptr->_size, 0\\);" 1 "original" } } -! { dg-final { scan-tree-dump-times "__builtin_memcpy \\(\\(void .\\) y->_data, \\(void .\\) y->_vptr->_def_init, \\(unsigned long\\) y->_vptr->_size\\);" 1 "original" } } +! { dg-final { scan-tree-dump-times "__builtin_memcpy \\(\\(void .\\) y->_data, \\(void .\\) y->_vptr->_def_init, \\(unsigned long\\) y->_vptr->_size\\);" 1 "original" { target lp64 } } } +! { dg-final { scan-tree-dump-times "__builtin_memcpy \\(\\(void .\\) y->_data, \\(void .\\) y->_vptr->_def_init, \\(unsigned int\\) y->_vptr->_size\\);" 1 "original" { target ilp32 } } } ! { dg-final { scan-tree-dump-times "x->_vptr->_final \\(&x->_data, x->_vptr->_size, 0\\);" 1 "original" } } ! { dg-final { scan-tree-dump-times "x->_vptr->_copy \\(x->_vptr->_def_init, &x->_data\\);" 1 "original" } }