From patchwork Wed Apr 3 18:08:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 233562 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 782DA2C0127 for ; Thu, 4 Apr 2013 05:08:44 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=jFnATOfZmYy3ZHnjZ 6rzSQCvQ6gz5Zk6AI3KCWIwpWBkUjpJwMaJ3Chw3tHJ4udzdZCDxy15QoPm8RcRn /u2rEvxTI0GdpjO5gNIkXARkmB0+97Kh/ABnlDlnytgSSfqb/TLZgY3KxcT3n6xh dS6318juZoFBDbOm5b+i8k5LT0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:in-reply-to; s=default; bh=9ItB+gvbyUi9LEiBWp+3fXE HhFc=; b=m/2AUOformYKq3DRz3enElpz2dF38pIP05qVPQvM/mArxH4jvMHk1Km Ddd4nOV3KwZU9SbQnPM+L4qAA+lkvSyiOClEVn8wr4dbC8sr5hzZQAnKSvLWqnXQ 64dW3yXdRH7WgSS6bxzdPGoIhA+qDUQPbkFl7dGbXSrZx9qj9Qzo= Received: (qmail 9582 invoked by alias); 3 Apr 2013 18:08:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9477 invoked by uid 89); 3 Apr 2013 18:08:28 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 03 Apr 2013 18:08:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r33I8RZ6010029 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 3 Apr 2013 14:08:27 -0400 Received: from zalov.cz (vpn1-6-38.ams2.redhat.com [10.36.6.38]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r33I8PKs022248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Apr 2013 14:08:26 -0400 Received: from zalov.cz (localhost [127.0.0.1]) by zalov.cz (8.14.5/8.14.5) with ESMTP id r33I8Ogo007892; Wed, 3 Apr 2013 20:08:24 +0200 Received: (from jakub@localhost) by zalov.cz (8.14.5/8.14.5/Submit) id r33I8ODr007891; Wed, 3 Apr 2013 20:08:24 +0200 Date: Wed, 3 Apr 2013 20:08:23 +0200 From: Jakub Jelinek To: Uros Bizjak Cc: Wei Mi , Richard Biener , Steven Bosscher , GCC Patches , David Li , Kirill Yukhin Subject: Re: extend fwprop optimization Message-ID: <20130403180823.GH4201@tucnak.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) On Thu, Mar 28, 2013 at 04:49:47PM +0100, Uros Bizjak wrote: > 2013-03-27 Wei Mi > > * config/i386/i386.md: Do shift truncation in define_insn > instead of define_insn_and_split. > > Please write ChangeLog as: > > * config/i386/i386.md (*ashl3_mask): Rewrite as define_insn. > Truncate operand 2 using %b asm operand modifier. > (*3_mask): Ditto. > (*3_mask): Ditto. > > OK for mainline and all release branches with these changes. This broke bootstrap on x86_64-linux as well as i686-linux on the 4.6 branch. Fixed thusly, committed as obvious after bootstrapping/regtesting on those targets. 2013-04-03 Jakub Jelinek * config/i386/i386.md (*3_mask): Use instead of . Jakub --- gcc/config/i386/i386.md.jj 2013-04-03 16:11:07.000000000 +0200 +++ gcc/config/i386/i386.md 2013-04-03 17:42:15.034672014 +0200 @@ -9827,7 +9827,7 @@ (define_insn "*3_mas && (INTVAL (operands[3]) & (GET_MODE_BITSIZE (mode)-1)) == GET_MODE_BITSIZE (mode)-1" { - return "{}\t{%b2, %0|%0, %b2}"; + return "{}\t{%b2, %0|%0, %b2}"; } [(set_attr "type" "ishift") (set_attr "mode" "")])