diff mbox

Fix PR52402

Message ID 20120228233935.GE18768@tyan-ft48-01.lab.bos.redhat.com
State New
Headers show

Commit Message

Jakub Jelinek Feb. 28, 2012, 11:39 p.m. UTC 
On Tue, Feb 28, 2012 at 09:34:37PM +0100, Jakub Jelinek wrote:
> On Mon, Feb 27, 2012 at 04:38:01PM +0100, Richard Guenther wrote:
> > This fixes PR52402 in a similar way as PR50444.  IPA SRA needs to be
> > careful about alignment when constructing accesses.
> > 
> > Bootstrap and regtest pending on x86_64, any comments?
> 
> The test fails on i386-linux, adding "-w -Wno-psabi" to options
> disables the
> /usr/src/gcc/gcc/testsuite/gcc.dg/torture/pr52402.c: In function ‘foo.isra.0’:
> /usr/src/gcc/gcc/testsuite/gcc.dg/torture/pr52402.c:7:1: note: The ABI for passing parameters with 16-byte alignment has changed in GCC 4.6
> /usr/src/gcc/gcc/testsuite/gcc.dg/torture/pr52402.c:7:1: warning: SSE vector argument without SSE enabled changes the ABI [enabled by default]
> warnings it otherwise prints.

Here is a fix, bootstrapped/regtested on x86_64-linux and i686-linux,
ok for trunk?

2012-02-28  Jakub Jelinek  <jakub@redhat.com>

	* gcc.dg/torture/pr52402.c: Add -w -Wno-psabi to dg-options.



	Jakub

Comments

Mike Stump Feb. 29, 2012, 1:58 a.m. UTC | #1 
On Feb 28, 2012, at 3:39 PM, Jakub Jelinek wrote:
> Here is a fix, bootstrapped/regtested on x86_64-linux and i686-linux,
> ok for trunk?

Sure, but, I can't find -Wpsabi in the docs.  :-(  If -Wno-abi works, at least it is documented.  Ok either way.
Jakub Jelinek Feb. 29, 2012, 7:45 a.m. UTC | #2 
On Tue, Feb 28, 2012 at 05:58:14PM -0800, Mike Stump wrote:
> On Feb 28, 2012, at 3:39 PM, Jakub Jelinek wrote:
> > Here is a fix, bootstrapped/regtested on x86_64-linux and i686-linux,
> > ok for trunk?
> 
> Sure, but, I can't find -Wpsabi in the docs.  :-(  If -Wno-abi works, at least it is documented.  Ok either way.

While not documented, 46 other tests are already using it.  -Wno-abi works
too, but is less specific in what it disables.
CCing H.J. for the missing documentation (both in c-family/c.opt and
doc/invoke.texi).

	Jakub
diff mbox

Patch

--- gcc/testsuite/gcc.dg/torture/pr52402.c.jj	2012-02-28 17:28:58.245648184 +0100
+++ gcc/testsuite/gcc.dg/torture/pr52402.c	2012-02-28 21:47:06.787445156 +0100
@@ -1,4 +1,5 @@ 
 /* { dg-do run } */
+/* { dg-options "-w -Wno-psabi" } */
 
 typedef int v4si __attribute__((vector_size(16)));
 struct T { v4si i[2]; int j; } __attribute__((packed));